From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67890C433E1 for ; Fri, 14 Aug 2020 14:24:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E44D21744 for ; Fri, 14 Aug 2020 14:24:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IKlqOFJn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728680AbgHNOYx (ORCPT ); Fri, 14 Aug 2020 10:24:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728012AbgHNOYw (ORCPT ); Fri, 14 Aug 2020 10:24:52 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EA93C061384; Fri, 14 Aug 2020 07:24:52 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id e11so598282ils.10; Fri, 14 Aug 2020 07:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ggMXgX7RUq22IK8MLaR6J65bRRwoutct0090dW6uEgw=; b=IKlqOFJnaBfJOoWsHY8UwOXQ4vWIVHOQ9cHFWJ/Yj4+Q5myA06cA4pxzNHWNeVCEuj K1C032wALPmBsr7wXqR/sGzkjo5MIplBaBt2+o6hjwJ0YMNuF8k4L0vg0kgsop05Wq3t 1VPqZHYz7U8Z2wT0h9HCgJkMoErzCNAPVxywOh5UNZ9D9tFVpSwIRLutCICVJ1At1Mx2 DnKIzOxQ23bC10EPBpdpg91/wXpp3J9vh4lJWRJwnkNB15+DpCOAKHNafy3tRm7gQN3F FFRvxr8Sx/x1/7TrM1jkphLoqhfetY5yu8AE0VRah+1AJ0g/+jsjiTLSaIShPAV3qBVr 8/xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ggMXgX7RUq22IK8MLaR6J65bRRwoutct0090dW6uEgw=; b=nv9tyzgnLvOfZZNHl3tBW63smTKZBhppHtwjlFUBbuxuF1DHbFmEEw+nXweWPUWVu/ RZ8te5UdGfOV9hWSKrSDMfBpij3SmVdcdBbOV7Qb2NFOXOD86UTBrY3dW1m6Q+PiZHhy T0takF1y3jfvsNjreEj5diSQFJqqo7CiBIlT6pElt/jGwHT7Jgqh/tTTwaXRnNgXj3A+ Wcqh2SvzQ9QVipPORh9ozKXkjQpc4GvPtXDu8uM9HhM3hkAT7lFdDk/eNzakOAsdOjdX 2PsT/8KUin7OP9D8wnJzsbDRHEen8ujZJDFM5oZnis8xgaYQebacZbY8+dITrHGLiR3g Z9WA== X-Gm-Message-State: AOAM5301PBgfEhVoXEioQf0y9WLJ7jALLUP/EL4Ta/uG2PXC5I+QDsPG mp6N22gVXTWJ4K4zdx7eFHRa0kXpGIt4LpJ8fs4= X-Google-Smtp-Source: ABdhPJwiVqDpFE9EY+SU+lxLzSIFEiSNcLq5aeOYf0OBc+yqsDmi0262ufou83smjiKGswFbd1La404xNmJyHd+7seM= X-Received: by 2002:a05:6e02:143:: with SMTP id j3mr2472545ilr.97.1597415091428; Fri, 14 Aug 2020 07:24:51 -0700 (PDT) MIME-Version: 1.0 References: <20200813035100.13054.25671.stgit@localhost.localdomain> <20200813040232.13054.82417.stgit@localhost.localdomain> <6c072332-ff16-757d-99dd-b8fbae131a0c@linux.alibaba.com> In-Reply-To: <6c072332-ff16-757d-99dd-b8fbae131a0c@linux.alibaba.com> From: Alexander Duyck Date: Fri, 14 Aug 2020 07:24:40 -0700 Message-ID: Subject: Re: [RFC PATCH 2/3] mm: Drop use of test_and_set_skip in favor of just setting skip To: Alex Shi Cc: Yang Shi , kbuild test robot , Rong Chen , Konstantin Khlebnikov , "Kirill A. Shutemov" , Hugh Dickins , LKML , Daniel Jordan , linux-mm , Shakeel Butt , Matthew Wilcox , Johannes Weiner , Tejun Heo , cgroups@vger.kernel.org, Andrew Morton , Wei Yang , Mel Gorman , Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 14, 2020 at 12:19 AM Alex Shi wrot= e: > > > > =E5=9C=A8 2020/8/13 =E4=B8=8B=E5=8D=8812:02, Alexander Duyck =E5=86=99=E9= =81=93: > > > > Since we have dropped the late abort case we can drop the code that was > > clearing the LRU flag and calling page_put since the abort case will no= w > > not be holding a reference to a page. > > > > Signed-off-by: Alexander Duyck > > seems the case-lru-file-mmap-read case drop about 3% on this patch in a r= ough testing. > on my 80 core machine. I'm not sure how it could have that much impact on the performance since the total effect would just be dropping what should be a redundant test since we tested the skip bit before we took the LRU bit, so we shouldn't need to test it again after. I finally got my test setup working last night. I'll have to do some testing in my environment and I can start trying to see what is going on. Thanks. - Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4521DC433DF for ; Fri, 14 Aug 2020 14:24:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0352C2074D for ; Fri, 14 Aug 2020 14:24:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IKlqOFJn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0352C2074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 82E6B6B0005; Fri, 14 Aug 2020 10:24:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DEBA6B0007; Fri, 14 Aug 2020 10:24:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F5296B000C; Fri, 14 Aug 2020 10:24:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id 5AC646B0005 for ; Fri, 14 Aug 2020 10:24:53 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 200B3824805A for ; Fri, 14 Aug 2020 14:24:53 +0000 (UTC) X-FDA: 77149395666.21.wash90_3d1608b26ffd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id C0D18180442C0 for ; Fri, 14 Aug 2020 14:24:52 +0000 (UTC) X-HE-Tag: wash90_3d1608b26ffd X-Filterd-Recvd-Size: 4470 Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Fri, 14 Aug 2020 14:24:52 +0000 (UTC) Received: by mail-il1-f194.google.com with SMTP id k4so8564233ilr.12 for ; Fri, 14 Aug 2020 07:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ggMXgX7RUq22IK8MLaR6J65bRRwoutct0090dW6uEgw=; b=IKlqOFJnaBfJOoWsHY8UwOXQ4vWIVHOQ9cHFWJ/Yj4+Q5myA06cA4pxzNHWNeVCEuj K1C032wALPmBsr7wXqR/sGzkjo5MIplBaBt2+o6hjwJ0YMNuF8k4L0vg0kgsop05Wq3t 1VPqZHYz7U8Z2wT0h9HCgJkMoErzCNAPVxywOh5UNZ9D9tFVpSwIRLutCICVJ1At1Mx2 DnKIzOxQ23bC10EPBpdpg91/wXpp3J9vh4lJWRJwnkNB15+DpCOAKHNafy3tRm7gQN3F FFRvxr8Sx/x1/7TrM1jkphLoqhfetY5yu8AE0VRah+1AJ0g/+jsjiTLSaIShPAV3qBVr 8/xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ggMXgX7RUq22IK8MLaR6J65bRRwoutct0090dW6uEgw=; b=jwGIUIrlD5WaIbS0fAi+/1oR0ozJdtsNCQX56fIv+3phaO5tnM7L3ppOuF9JdHF+JB cdpFu9ErR5YrqBnPqtjfmThQSO39tb5KG1JSGYq1XDkRtnzX0BCDVhoO4yN1iX882Z7S yCj0BnW1N4kTxMFGOUknnIEYQ72zvLxsPEAxauv2mSQJGiqI1ItnU5L7JAvk4r3ONGbC 2JcxAU9PDuZw5Pw1ImzOUy5EOCtwxHwR1guNghScVBVKr1zv7heqHTbPIR5Y3QAayIER eCr+pGBNDR3kv2+MF5NdEFFELZb434uZ0qiAI6MQ9rj3qvrt/Sqd2wqMlidNjswbJWOx JUhg== X-Gm-Message-State: AOAM533ExbAeCTQWK6Z9eGElAao4SBo0BAdh8Jw1FuDmB1kyy/yzatxF XpU5FxBVLJIpRExRiMuABOlXW3SPuHbfyLOQ5/k= X-Google-Smtp-Source: ABdhPJwiVqDpFE9EY+SU+lxLzSIFEiSNcLq5aeOYf0OBc+yqsDmi0262ufou83smjiKGswFbd1La404xNmJyHd+7seM= X-Received: by 2002:a05:6e02:143:: with SMTP id j3mr2472545ilr.97.1597415091428; Fri, 14 Aug 2020 07:24:51 -0700 (PDT) MIME-Version: 1.0 References: <20200813035100.13054.25671.stgit@localhost.localdomain> <20200813040232.13054.82417.stgit@localhost.localdomain> <6c072332-ff16-757d-99dd-b8fbae131a0c@linux.alibaba.com> In-Reply-To: <6c072332-ff16-757d-99dd-b8fbae131a0c@linux.alibaba.com> From: Alexander Duyck Date: Fri, 14 Aug 2020 07:24:40 -0700 Message-ID: Subject: Re: [RFC PATCH 2/3] mm: Drop use of test_and_set_skip in favor of just setting skip To: Alex Shi Cc: Yang Shi , kbuild test robot , Rong Chen , Konstantin Khlebnikov , "Kirill A. Shutemov" , Hugh Dickins , LKML , Daniel Jordan , linux-mm , Shakeel Butt , Matthew Wilcox , Johannes Weiner , Tejun Heo , cgroups@vger.kernel.org, Andrew Morton , Wei Yang , Mel Gorman , Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C0D18180442C0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 14, 2020 at 12:19 AM Alex Shi wrot= e: > > > > =E5=9C=A8 2020/8/13 =E4=B8=8B=E5=8D=8812:02, Alexander Duyck =E5=86=99=E9= =81=93: > > > > Since we have dropped the late abort case we can drop the code that was > > clearing the LRU flag and calling page_put since the abort case will no= w > > not be holding a reference to a page. > > > > Signed-off-by: Alexander Duyck > > seems the case-lru-file-mmap-read case drop about 3% on this patch in a r= ough testing. > on my 80 core machine. I'm not sure how it could have that much impact on the performance since the total effect would just be dropping what should be a redundant test since we tested the skip bit before we took the LRU bit, so we shouldn't need to test it again after. I finally got my test setup working last night. I'll have to do some testing in my environment and I can start trying to see what is going on. Thanks. - Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Duyck Subject: Re: [RFC PATCH 2/3] mm: Drop use of test_and_set_skip in favor of just setting skip Date: Fri, 14 Aug 2020 07:24:40 -0700 Message-ID: References: <20200813035100.13054.25671.stgit@localhost.localdomain> <20200813040232.13054.82417.stgit@localhost.localdomain> <6c072332-ff16-757d-99dd-b8fbae131a0c@linux.alibaba.com> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ggMXgX7RUq22IK8MLaR6J65bRRwoutct0090dW6uEgw=; b=IKlqOFJnaBfJOoWsHY8UwOXQ4vWIVHOQ9cHFWJ/Yj4+Q5myA06cA4pxzNHWNeVCEuj K1C032wALPmBsr7wXqR/sGzkjo5MIplBaBt2+o6hjwJ0YMNuF8k4L0vg0kgsop05Wq3t 1VPqZHYz7U8Z2wT0h9HCgJkMoErzCNAPVxywOh5UNZ9D9tFVpSwIRLutCICVJ1At1Mx2 DnKIzOxQ23bC10EPBpdpg91/wXpp3J9vh4lJWRJwnkNB15+DpCOAKHNafy3tRm7gQN3F FFRvxr8Sx/x1/7TrM1jkphLoqhfetY5yu8AE0VRah+1AJ0g/+jsjiTLSaIShPAV3qBVr 8/xg== In-Reply-To: <6c072332-ff16-757d-99dd-b8fbae131a0c-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="utf-8" To: Alex Shi Cc: Yang Shi , kbuild test robot , Rong Chen , Konstantin Khlebnikov , "Kirill A. Shutemov" , Hugh Dickins , LKML , Daniel Jordan , linux-mm , Shakeel Butt , Matthew Wilcox , Johannes Weiner , Tejun Heo , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrew Morton , Wei Yang , Mel Gorman , Joonsoo Kim On Fri, Aug 14, 2020 at 12:19 AM Alex Shi wrot= e: > > > > =E5=9C=A8 2020/8/13 =E4=B8=8B=E5=8D=8812:02, Alexander Duyck =E5=86=99=E9= =81=93: > > > > Since we have dropped the late abort case we can drop the code that was > > clearing the LRU flag and calling page_put since the abort case will no= w > > not be holding a reference to a page. > > > > Signed-off-by: Alexander Duyck > > seems the case-lru-file-mmap-read case drop about 3% on this patch in a r= ough testing. > on my 80 core machine. I'm not sure how it could have that much impact on the performance since the total effect would just be dropping what should be a redundant test since we tested the skip bit before we took the LRU bit, so we shouldn't need to test it again after. I finally got my test setup working last night. I'll have to do some testing in my environment and I can start trying to see what is going on. Thanks. - Alex