From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB5DC433DF for ; Fri, 31 Jul 2020 21:31:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCD7D22B42 for ; Fri, 31 Jul 2020 21:31:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZqlUeZYl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728652AbgGaVbV (ORCPT ); Fri, 31 Jul 2020 17:31:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727995AbgGaVbV (ORCPT ); Fri, 31 Jul 2020 17:31:21 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23186C061574; Fri, 31 Jul 2020 14:31:21 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id q75so24895983iod.1; Fri, 31 Jul 2020 14:31:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IPQ4YxQDiIfVNt/lLYL1uBZHZt0DN0r5SckeWlUL42o=; b=ZqlUeZYlm3G5RmGJ/gBq3usEdl293NPeNsf49vRwQFLjpkFcMWw+/wHHQF6OC4lnEP UYDZlF8vFK8pP7i3LP5yfgXYgTcpyUR4UwcUnE6SMXnXfcK4/ymgbvAloDaeW1XQ/7sF mIoGy57n/qQO2ubYE7SWThSVcKDv9ygK/qFBuHnT+K103p4/RMBjdNGuzR8h/3BotrLk SnIDwhtP7EWGGpssFryMLmnyNz0ZvHxRrqEA7eBsskIgqQkumayrOCdAFLfOvEnNbK1W FNwJP/oozmm4xtxuJ+f8VMzsh2DtO8LvNBSg3tUjEuW/ft6bstP8wUjPiuE/+DZsY7Lz n/ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IPQ4YxQDiIfVNt/lLYL1uBZHZt0DN0r5SckeWlUL42o=; b=nVNWeuScYVXly+pKPeu42JlUvkjkT3jvPQ+bONHg4gxFunoEqppnAT/5IeOYXDlHzH gSPtDHXOWB3k8F9vS5xBJuFguyTO5+op2whk+OO1cbTBm9ZF0T3T4LWuNDKiQ5wBUEO6 3lXNVSGuUKhpNHnJVcJTEHPj0BOAdI/a3zFRjAEJwzYlxhArbTqARKQx0VpmfCRdqsBb 3pFKbdlOdBulzfq8j2Zg2/e3D0+NRwe850wrEMNhr/x+2e4PLd+wmrbbLfnrnRM+jl9G DWdior71SifO7poGCdJaQ23cvsPeslGVsTdTkA6/O+qTy+uk5tGXjR0zgMzL6Hob7sfM 8wHQ== X-Gm-Message-State: AOAM533HbBEDRQGlqxywQD4IKQd2C8Hu5QJty95eH6SlMvM+mwFPxJpL T4Mb1lYp6SRBaHcXzabrg+cNNDp+ImGbwgDB5Ew= X-Google-Smtp-Source: ABdhPJwdLNEFCnWUSxtOXLRAFdZSVwbu2VSbb24NWwr7R+O5oVVHBXi1NoFBl5lk5aI8qoQlxhxMOXQ/bRMFkEeE1gI= X-Received: by 2002:a6b:da0d:: with SMTP id x13mr5550869iob.138.1596231080492; Fri, 31 Jul 2020 14:31:20 -0700 (PDT) MIME-Version: 1.0 References: <1595681998-19193-1-git-send-email-alex.shi@linux.alibaba.com> In-Reply-To: <1595681998-19193-1-git-send-email-alex.shi@linux.alibaba.com> From: Alexander Duyck Date: Fri, 31 Jul 2020 14:31:09 -0700 Message-ID: Subject: Re: [PATCH v17 00/21] per memcg lru lock To: Alex Shi Cc: Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Matthew Wilcox , Johannes Weiner , kbuild test robot , linux-mm , LKML , cgroups@vger.kernel.org, Shakeel Butt , Joonsoo Kim , Wei Yang , "Kirill A. Shutemov" , Rong Chen Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 25, 2020 at 6:00 AM Alex Shi wrote: > > The new version which bases on v5.8-rc6. It includes Hugh Dickins fix in > mm/swap.c and mm/mlock.c fix which Alexander Duyck pointed out, then > removes 'mm/mlock: reorder isolation sequence during munlock' > > Hi Johanness & Hugh & Alexander & Willy, > > Could you like to give a reviewed by since you address much of issue and > give lots of suggestions! Many thanks! > I just finished getting a test pass done on the patches. I'm still seeing a regression on the will-it-scale/page_fault3 test but it is now only 3% instead of the 20% that it was so it may just be noise at this point. I'll try to make sure to get my review feedback wrapped up early next week. Thanks. - Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE891C433E0 for ; Fri, 31 Jul 2020 21:31:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9A78F2087C for ; Fri, 31 Jul 2020 21:31:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZqlUeZYl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A78F2087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3D39C8D005F; Fri, 31 Jul 2020 17:31:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 385348D000B; Fri, 31 Jul 2020 17:31:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 273CD8D005F; Fri, 31 Jul 2020 17:31:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 1349D8D000B for ; Fri, 31 Jul 2020 17:31:22 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B7AA03629 for ; Fri, 31 Jul 2020 21:31:21 +0000 (UTC) X-FDA: 77099667162.01.tin56_510972326f87 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 824501004E102 for ; Fri, 31 Jul 2020 21:31:21 +0000 (UTC) X-HE-Tag: tin56_510972326f87 X-Filterd-Recvd-Size: 4002 Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Fri, 31 Jul 2020 21:31:21 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id a5so17801589ioa.13 for ; Fri, 31 Jul 2020 14:31:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IPQ4YxQDiIfVNt/lLYL1uBZHZt0DN0r5SckeWlUL42o=; b=ZqlUeZYlm3G5RmGJ/gBq3usEdl293NPeNsf49vRwQFLjpkFcMWw+/wHHQF6OC4lnEP UYDZlF8vFK8pP7i3LP5yfgXYgTcpyUR4UwcUnE6SMXnXfcK4/ymgbvAloDaeW1XQ/7sF mIoGy57n/qQO2ubYE7SWThSVcKDv9ygK/qFBuHnT+K103p4/RMBjdNGuzR8h/3BotrLk SnIDwhtP7EWGGpssFryMLmnyNz0ZvHxRrqEA7eBsskIgqQkumayrOCdAFLfOvEnNbK1W FNwJP/oozmm4xtxuJ+f8VMzsh2DtO8LvNBSg3tUjEuW/ft6bstP8wUjPiuE/+DZsY7Lz n/ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IPQ4YxQDiIfVNt/lLYL1uBZHZt0DN0r5SckeWlUL42o=; b=U+ilG/zajxNRFs1bEaIkVe7ho9bj0C3AENiHpEsDKcT2mro2RcfDOZh5/u3BIPPU4V i0WoKoJWKp5EM//rehNW11/rIpgvbwxFFxN2ihLIyHgcTNeip8aBfXX8i78kj9IE5hKH +b7aPHg+rP6k3yU5DGuhCS6k8s2hjTq8nyKc4C+FJeMaYLv3W9YoleZBTlyV/TLVUJ2H pAFmI9bRa4rUuTmoPzC3kPxxdvoGwXP3RklBnDZCeS4gWmDTWRH0yS4VLaX4wkNJMlKn dA93usJGRdnAFD+gbMzb9ts1W3YFz9vWvmTug2x4GJUeakse3HdKnoUp8ZnZdNuv74zF J6vA== X-Gm-Message-State: AOAM533qteRBEF0tNobAiCvj8Qfcf0EazMh7LAERRdbbDzKBtD8nSmDC 7vlysrtuVDmRtLvUzMpjcIajAEtP1Ulpy5MURSI= X-Google-Smtp-Source: ABdhPJwdLNEFCnWUSxtOXLRAFdZSVwbu2VSbb24NWwr7R+O5oVVHBXi1NoFBl5lk5aI8qoQlxhxMOXQ/bRMFkEeE1gI= X-Received: by 2002:a6b:da0d:: with SMTP id x13mr5550869iob.138.1596231080492; Fri, 31 Jul 2020 14:31:20 -0700 (PDT) MIME-Version: 1.0 References: <1595681998-19193-1-git-send-email-alex.shi@linux.alibaba.com> In-Reply-To: <1595681998-19193-1-git-send-email-alex.shi@linux.alibaba.com> From: Alexander Duyck Date: Fri, 31 Jul 2020 14:31:09 -0700 Message-ID: Subject: Re: [PATCH v17 00/21] per memcg lru lock To: Alex Shi Cc: Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Matthew Wilcox , Johannes Weiner , kbuild test robot , linux-mm , LKML , cgroups@vger.kernel.org, Shakeel Butt , Joonsoo Kim , Wei Yang , "Kirill A. Shutemov" , Rong Chen Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 824501004E102 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 25, 2020 at 6:00 AM Alex Shi wrote: > > The new version which bases on v5.8-rc6. It includes Hugh Dickins fix in > mm/swap.c and mm/mlock.c fix which Alexander Duyck pointed out, then > removes 'mm/mlock: reorder isolation sequence during munlock' > > Hi Johanness & Hugh & Alexander & Willy, > > Could you like to give a reviewed by since you address much of issue and > give lots of suggestions! Many thanks! > I just finished getting a test pass done on the patches. I'm still seeing a regression on the will-it-scale/page_fault3 test but it is now only 3% instead of the 20% that it was so it may just be noise at this point. I'll try to make sure to get my review feedback wrapped up early next week. Thanks. - Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Duyck Subject: Re: [PATCH v17 00/21] per memcg lru lock Date: Fri, 31 Jul 2020 14:31:09 -0700 Message-ID: References: <1595681998-19193-1-git-send-email-alex.shi@linux.alibaba.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IPQ4YxQDiIfVNt/lLYL1uBZHZt0DN0r5SckeWlUL42o=; b=ZqlUeZYlm3G5RmGJ/gBq3usEdl293NPeNsf49vRwQFLjpkFcMWw+/wHHQF6OC4lnEP UYDZlF8vFK8pP7i3LP5yfgXYgTcpyUR4UwcUnE6SMXnXfcK4/ymgbvAloDaeW1XQ/7sF mIoGy57n/qQO2ubYE7SWThSVcKDv9ygK/qFBuHnT+K103p4/RMBjdNGuzR8h/3BotrLk SnIDwhtP7EWGGpssFryMLmnyNz0ZvHxRrqEA7eBsskIgqQkumayrOCdAFLfOvEnNbK1W FNwJP/oozmm4xtxuJ+f8VMzsh2DtO8LvNBSg3tUjEuW/ft6bstP8wUjPiuE/+DZsY7Lz n/ag== In-Reply-To: <1595681998-19193-1-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alex Shi Cc: Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Matthew Wilcox , Johannes Weiner , kbuild test robot , linux-mm , LKML , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shakeel Butt , Joonsoo Kim , Wei Yang , "Kirill A. Shutemov" , Rong Chen On Sat, Jul 25, 2020 at 6:00 AM Alex Shi wrote: > > The new version which bases on v5.8-rc6. It includes Hugh Dickins fix in > mm/swap.c and mm/mlock.c fix which Alexander Duyck pointed out, then > removes 'mm/mlock: reorder isolation sequence during munlock' > > Hi Johanness & Hugh & Alexander & Willy, > > Could you like to give a reviewed by since you address much of issue and > give lots of suggestions! Many thanks! > I just finished getting a test pass done on the patches. I'm still seeing a regression on the will-it-scale/page_fault3 test but it is now only 3% instead of the 20% that it was so it may just be noise at this point. I'll try to make sure to get my review feedback wrapped up early next week. Thanks. - Alex