From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A1D9C433EF for ; Mon, 17 Jan 2022 12:30:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239882AbiAQMaQ (ORCPT ); Mon, 17 Jan 2022 07:30:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231537AbiAQMaP (ORCPT ); Mon, 17 Jan 2022 07:30:15 -0500 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19D01C061574; Mon, 17 Jan 2022 04:30:15 -0800 (PST) Received: by mail-ot1-x32c.google.com with SMTP id 60-20020a9d0142000000b0059103eb18d4so19509217otu.2; Mon, 17 Jan 2022 04:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Xp4+4+Wf5tUKljhMRbkkPD6L+kcOJd/sxyMiSoMO1F8=; b=OfdJFKiAlYwn1IT48NdRrcoE/gTwmk3XVMQFUqA2U8dTNaQ3/elLCLqDvlU2ojCIMa L4E8269GygXEjsMK4aBgOBHW6TX9+T2vNFN5YHdkNz3TwOW+22AtOVfoWG1IA5JN2Mvz scVHgGfrfq1LSUGg6ggMA0yJL7BVpjqChodCUmojEOW8lpgz0AYfbL2BKc3I7WrLZpb9 1NkCiiNxcOp9aeox2XZhcDqgJGS5hxs5D9jqylZ4hB9GSOTfiqglHBddjnSfonod+XmM Q47X3ZmlC1pu6XqHKqsD4TPs/jmbAXvsCpDswjQVyQjbXN+Ft8XM0J5PgIpRD3ZTlcYQ zG1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Xp4+4+Wf5tUKljhMRbkkPD6L+kcOJd/sxyMiSoMO1F8=; b=N1AGXRB8k+J3CJhSZGa3LixdiSQLswXA96lqZ55ZbMSss1gyPpJZC8D8jHwHzxGZ+M KkOzL1sCJheMz6XCknDsZLyrTCBxhu8NzIJCMXF9DJWy/IOiNsU0Ojyp/ZFo1H65EnmJ 0cgoCyjz0lSvhOytjHh1XT7kDxLtuHED3Gd6jcWpZFAyw8atdF/ZbWtufx6ufs/QqjXd iIpXwHIeJHyER0/1EYd02xh5kYg7qhihNVowDarSHqGt2Q7RJJddSP/04UD6Wxa+Fnp9 wXrw0S3stzAT8LvSA/WlUT1iuE11O2jI94NJRHnsGbqerB7cj+0UoxCgCsQMbcrNlwoo 3C5g== X-Gm-Message-State: AOAM531/i5UzM9+PSKzxrPimthc8AZmHNLgVUfIGWx3E6hwE8J9Ossgs tXJrR677PVEz1TvDYiRaBkgx3Ge2nSTDwJq0UW4r9/5UdUM= X-Google-Smtp-Source: ABdhPJz4HHHPGxTLEZqNI3Bi+FfcVyBZCrg7v/hyl0ovPK3zpRfgk4Sncfbh/+u+Jqouz2UpX4d5AOHo5YavyfgWfis= X-Received: by 2002:a9d:d08:: with SMTP id 8mr16850521oti.334.1642422614470; Mon, 17 Jan 2022 04:30:14 -0800 (PST) MIME-Version: 1.0 References: <20220114233904.907918-1-sean.anderson@seco.com> In-Reply-To: <20220114233904.907918-1-sean.anderson@seco.com> From: Jun Li Date: Mon, 17 Jan 2022 20:30:03 +0800 Message-ID: Subject: Re: [PATCH 0/6] usb: dwc3: Calculate REFCLKPER et. al. from reference clock To: Sean Anderson , Li Jun Cc: Greg Kroah-Hartman , Linux USB List , lkml , Robert Hancock , Baruch Siach , Felipe Balbi , Balaji Prakash J , Andy Gross , Bjorn Andersson , Michal Simek , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel , linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Sean Anderson =E4=BA=8E2022=E5=B9=B41=E6=9C=8815= =E6=97=A5=E5=91=A8=E5=85=AD 10:11=E5=86=99=E9=81=93=EF=BC=9A > > This is a rework of patches 3-5 of [1]. It attempts to correctly program > REFCLKPER and REFCLK_FLADJ based on the reference clock frequency. Since > we no longer need a special property duplicating this configuration, > snps,ref-clock-period-ns is deprecated. > > Please test this! Patches 3/4 in this series have the effect of > programming REFCLKPER and REFCLK_FLADJ on boards which already configure > the "ref" clock. I have build tested, but not much else. DWC3 databook states a *condition* for program those settings: This field must be programmed to a non-zero value only if GFLADJ_REFCLK_LPM_SEL is set to '1' or GCTL.SOFITPSYNC is set to '1'. The value is derived as follows: FLADJ_REF_CLK_FLADJ=3D((125000/ref_clk_period_integer)-(125000/ref_clk_peri= od)) * ref_clk_period where =E2=96=A0 the ref_clk_period_integer is the integer value of the ref_clk period got by truncating the decimal (fractional) value that is programmed in the GUCTL.REF_CLK_PERIOD field. =E2=96=A0 the ref_clk_period is the ref_clk period including the fractional= value. So you may need a condition check, with that, only required users are effected even with "ref" clock specified. Li Jun > > [1] https://lore.kernel.org/linux-usb/20220114044230.2677283-1-robert.han= cock@calian.com/ > > > Sean Anderson (6): > dt-bindings: usb: dwc3: Deprecate snps,ref-clock-period-ns > usb: dwc3: Get clocks individually > usb: dwc3: Calculate REFCLKPER based on reference clock > usb: dwc3: Handle fractional reference clocks > arm64: dts: zynqmp: Move USB clocks to dwc3 node > arm64: dts: ipq6018: Use reference clock to set dwc3 period > > .../devicetree/bindings/usb/snps,dwc3.yaml | 7 +- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 3 +- > .../arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi | 4 +- > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 +- > drivers/usb/dwc3/core.c | 98 ++++++++++++++++--- > drivers/usb/dwc3/core.h | 6 +- > 6 files changed, 98 insertions(+), 24 deletions(-) > > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62A5FC433EF for ; Mon, 17 Jan 2022 12:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6bmKdRQ4EHc7+AWN3MQCkV0hhe/1Y8+gWraiuFF4H+I=; b=cCPgFy2BiaDqPS G4C9joHfyzAHopbS8TH+QPowTZMfH/omRJZwduZS9en6JZxb924cYu7E9eirl0RVTByHsoArJD4m+ O988kMKcaIicZYcTEkUrbL2Lte65BFsme6yIM+pMh1+oN1c9vxGYdPmUb/IYtUxpJgjHSKOKh+VjT fTktI/czusuofOhCDaZDC64EPITcDGF4mqqxLA1eDdkeHz/f/0L48uop+1d+SJznwQmMJPYwD1IWf 0upgFht2yzCHsVanQkkDj6EdLAWLlP0gBQFAFN9fVy81/v/zHaZV2z5bzgLGC8v8Z1wYP+L+kreuT RdjBkiEENMDSO3R2IDdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9R9P-00EuKY-GV; Mon, 17 Jan 2022 12:30:19 +0000 Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9R9M-00EuJr-Dx for linux-arm-kernel@lists.infradead.org; Mon, 17 Jan 2022 12:30:17 +0000 Received: by mail-ot1-x335.google.com with SMTP id m8-20020a9d4c88000000b00592bae7944bso16375229otf.1 for ; Mon, 17 Jan 2022 04:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Xp4+4+Wf5tUKljhMRbkkPD6L+kcOJd/sxyMiSoMO1F8=; b=OfdJFKiAlYwn1IT48NdRrcoE/gTwmk3XVMQFUqA2U8dTNaQ3/elLCLqDvlU2ojCIMa L4E8269GygXEjsMK4aBgOBHW6TX9+T2vNFN5YHdkNz3TwOW+22AtOVfoWG1IA5JN2Mvz scVHgGfrfq1LSUGg6ggMA0yJL7BVpjqChodCUmojEOW8lpgz0AYfbL2BKc3I7WrLZpb9 1NkCiiNxcOp9aeox2XZhcDqgJGS5hxs5D9jqylZ4hB9GSOTfiqglHBddjnSfonod+XmM Q47X3ZmlC1pu6XqHKqsD4TPs/jmbAXvsCpDswjQVyQjbXN+Ft8XM0J5PgIpRD3ZTlcYQ zG1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Xp4+4+Wf5tUKljhMRbkkPD6L+kcOJd/sxyMiSoMO1F8=; b=b7lZ97535QJwfTjiDLVMj8f1oR+h0yIH/Am71Bu1B8uPrq6bjxUm/VYMzSAOY4ZMnG uvdnnCxFDn6YWVDo9tn1XvWPcHQUu0t+uEzYIrHEIQOeMOuHET1gPCZpXitCFIgIfdFg s3Y5E6psstAHmh57/7GFo56Q/AjbwA5rnEbWCuY/hE9skE1q/OXwiuYr/j6yiOp/6lzL AikccRo1+XlF7v250isVOE6FKdkPdj29hqswGJzTrtYIh1/lespi0M2NKnbBvF/B0VSV 2SqpDeWkDf3hHzByZkLPtwucaCuyqTsqSiPhFzHqQ4Ow2h38tNCfe8oLQazwxqKPC9Fm hsVg== X-Gm-Message-State: AOAM533+PeqIIFdjNo4URKNGDaGJsFuwnFwaCT2Mvza9QBBIs6J5Pjvs G8Cc/aYwiL+a/tbNj9/yNjJBOc9cEpaisrnBUus= X-Google-Smtp-Source: ABdhPJz4HHHPGxTLEZqNI3Bi+FfcVyBZCrg7v/hyl0ovPK3zpRfgk4Sncfbh/+u+Jqouz2UpX4d5AOHo5YavyfgWfis= X-Received: by 2002:a9d:d08:: with SMTP id 8mr16850521oti.334.1642422614470; Mon, 17 Jan 2022 04:30:14 -0800 (PST) MIME-Version: 1.0 References: <20220114233904.907918-1-sean.anderson@seco.com> In-Reply-To: <20220114233904.907918-1-sean.anderson@seco.com> From: Jun Li Date: Mon, 17 Jan 2022 20:30:03 +0800 Message-ID: Subject: Re: [PATCH 0/6] usb: dwc3: Calculate REFCLKPER et. al. from reference clock To: Sean Anderson , Li Jun Cc: Greg Kroah-Hartman , Linux USB List , lkml , Robert Hancock , Baruch Siach , Felipe Balbi , Balaji Prakash J , Andy Gross , Bjorn Andersson , Michal Simek , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel , linux-arm-msm@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220117_043016_495556_1C600CA0 X-CRM114-Status: GOOD ( 13.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org U2VhbiBBbmRlcnNvbiA8c2Vhbi5hbmRlcnNvbkBzZWNvLmNvbT4g5LqOMjAyMuW5tDHmnIgxNeaX peWRqOWFrSAxMDoxMeWGmemBk++8mgo+Cj4gVGhpcyBpcyBhIHJld29yayBvZiBwYXRjaGVzIDMt NSBvZiBbMV0uIEl0IGF0dGVtcHRzIHRvIGNvcnJlY3RseSBwcm9ncmFtCj4gUkVGQ0xLUEVSIGFu ZCBSRUZDTEtfRkxBREogYmFzZWQgb24gdGhlIHJlZmVyZW5jZSBjbG9jayBmcmVxdWVuY3kuIFNp bmNlCj4gd2Ugbm8gbG9uZ2VyIG5lZWQgYSBzcGVjaWFsIHByb3BlcnR5IGR1cGxpY2F0aW5nIHRo aXMgY29uZmlndXJhdGlvbiwKPiBzbnBzLHJlZi1jbG9jay1wZXJpb2QtbnMgaXMgZGVwcmVjYXRl ZC4KPgo+IFBsZWFzZSB0ZXN0IHRoaXMhIFBhdGNoZXMgMy80IGluIHRoaXMgc2VyaWVzIGhhdmUg dGhlIGVmZmVjdCBvZgo+IHByb2dyYW1taW5nIFJFRkNMS1BFUiBhbmQgUkVGQ0xLX0ZMQURKIG9u IGJvYXJkcyB3aGljaCBhbHJlYWR5IGNvbmZpZ3VyZQo+IHRoZSAicmVmIiBjbG9jay4gSSBoYXZl IGJ1aWxkIHRlc3RlZCwgYnV0IG5vdCBtdWNoIGVsc2UuCgpEV0MzIGRhdGFib29rIHN0YXRlcyBh ICpjb25kaXRpb24qIGZvciBwcm9ncmFtIHRob3NlIHNldHRpbmdzOgoKVGhpcyBmaWVsZCBtdXN0 IGJlIHByb2dyYW1tZWQgdG8gYSBub24temVybyB2YWx1ZSBvbmx5IGlmCkdGTEFESl9SRUZDTEtf TFBNX1NFTCBpcyBzZXQgdG8gJzEnIG9yIEdDVEwuU09GSVRQU1lOQyBpcyBzZXQgdG8gJzEnLgpU aGUgdmFsdWUgaXMgZGVyaXZlZCBhcyBmb2xsb3dzOgpGTEFESl9SRUZfQ0xLX0ZMQURKPSgoMTI1 MDAwL3JlZl9jbGtfcGVyaW9kX2ludGVnZXIpLSgxMjUwMDAvcmVmX2Nsa19wZXJpb2QpKQoqIHJl Zl9jbGtfcGVyaW9kIHdoZXJlCuKWoCB0aGUgcmVmX2Nsa19wZXJpb2RfaW50ZWdlciBpcyB0aGUg aW50ZWdlciB2YWx1ZSBvZiB0aGUgcmVmX2NsawpwZXJpb2QgZ290IGJ5IHRydW5jYXRpbmcgdGhl IGRlY2ltYWwgKGZyYWN0aW9uYWwpIHZhbHVlIHRoYXQgaXMKcHJvZ3JhbW1lZCBpbiB0aGUgR1VD VEwuUkVGX0NMS19QRVJJT0QgZmllbGQuCuKWoCB0aGUgcmVmX2Nsa19wZXJpb2QgaXMgdGhlIHJl Zl9jbGsgcGVyaW9kIGluY2x1ZGluZyB0aGUgZnJhY3Rpb25hbCB2YWx1ZS4KClNvIHlvdSBtYXkg bmVlZCBhIGNvbmRpdGlvbiBjaGVjaywgd2l0aCB0aGF0LCBvbmx5IHJlcXVpcmVkIHVzZXJzCmFy ZSBlZmZlY3RlZCBldmVuIHdpdGggInJlZiIgY2xvY2sgc3BlY2lmaWVkLgoKTGkgSnVuCgo+Cj4g WzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LXVzYi8yMDIyMDExNDA0NDIzMC4yNjc3 MjgzLTEtcm9iZXJ0LmhhbmNvY2tAY2FsaWFuLmNvbS8KPgo+Cj4gU2VhbiBBbmRlcnNvbiAoNik6 Cj4gICBkdC1iaW5kaW5nczogdXNiOiBkd2MzOiBEZXByZWNhdGUgc25wcyxyZWYtY2xvY2stcGVy aW9kLW5zCj4gICB1c2I6IGR3YzM6IEdldCBjbG9ja3MgaW5kaXZpZHVhbGx5Cj4gICB1c2I6IGR3 YzM6IENhbGN1bGF0ZSBSRUZDTEtQRVIgYmFzZWQgb24gcmVmZXJlbmNlIGNsb2NrCj4gICB1c2I6 IGR3YzM6IEhhbmRsZSBmcmFjdGlvbmFsIHJlZmVyZW5jZSBjbG9ja3MKPiAgIGFybTY0OiBkdHM6 IHp5bnFtcDogTW92ZSBVU0IgY2xvY2tzIHRvIGR3YzMgbm9kZQo+ICAgYXJtNjQ6IGR0czogaXBx NjAxODogVXNlIHJlZmVyZW5jZSBjbG9jayB0byBzZXQgZHdjMyBwZXJpb2QKPgo+ICAuLi4vZGV2 aWNldHJlZS9iaW5kaW5ncy91c2Ivc25wcyxkd2MzLnlhbWwgICAgfCAgNyArLQo+ICBhcmNoL2Fy bTY0L2Jvb3QvZHRzL3Fjb20vaXBxNjAxOC5kdHNpICAgICAgICAgfCAgMyArLQo+ICAuLi4vYXJt NjQvYm9vdC9kdHMveGlsaW54L3p5bnFtcC1jbGstY2NmLmR0c2kgfCAgNCArLQo+ICBhcmNoL2Fy bTY0L2Jvb3QvZHRzL3hpbGlueC96eW5xbXAuZHRzaSAgICAgICAgfCAgNCArLQo+ICBkcml2ZXJz L3VzYi9kd2MzL2NvcmUuYyAgICAgICAgICAgICAgICAgICAgICAgfCA5OCArKysrKysrKysrKysr KysrLS0tCj4gIGRyaXZlcnMvdXNiL2R3YzMvY29yZS5oICAgICAgICAgICAgICAgICAgICAgICB8 ICA2ICstCj4gIDYgZmlsZXMgY2hhbmdlZCwgOTggaW5zZXJ0aW9ucygrKSwgMjQgZGVsZXRpb25z KC0pCj4KPiAtLQo+IDIuMjUuMQo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==