From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF0E4C433FE for ; Tue, 11 Oct 2022 13:28:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbiJKN2v (ORCPT ); Tue, 11 Oct 2022 09:28:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230052AbiJKN2r (ORCPT ); Tue, 11 Oct 2022 09:28:47 -0400 Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BA8F46D8D for ; Tue, 11 Oct 2022 06:28:45 -0700 (PDT) Received: by mail-vs1-xe32.google.com with SMTP id k6so12124556vsp.0 for ; Tue, 11 Oct 2022 06:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eclypsium.com; s=google; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=raH7WVDSsvCPKQIhYgmZFVAAGSUF5nc09Zedq+rsMAU=; b=RIe4dBR0aMf5OdrqYm/Utd+N0OJj8M7yVRnxQt0SWrAE+Icqli8dm198FiWu1zyE4K ThFkWDgg/9Td5d2IRDtyLEfSPwokGQrcFSl+ZlD2K4af69I3g3EB9B1emQIrMWvScJHw r+I3aZYKyOKoXo9+c2guSFePs38N6mNAHs3VoFJnnpA5I08Jok+DXwlLOgxNK3KgfAUZ XdH4LxlWpNY4uzGhO4Af+xDw0bOM1Vadya5Rtbe4apuRaNOzWyL2aYvjt49BUK4JI6Dw lHsf8fQMu1jQgOb7cxH8q3pAtHNmlqi/rQWzUKfzGN0Ycw4ppIGnoOMf/vkNLy9aLTOC /peA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=raH7WVDSsvCPKQIhYgmZFVAAGSUF5nc09Zedq+rsMAU=; b=ZebRJge5dJz6jAjUmV+HxGKp8FD6buIxRIYqlAdBIFpLc2QXI93JsXoxxU2oDi4ZIU oWVVmG+vrHxzVqsaTTCSQPeJJOl7nAMvvR8FRE2zPzKj0RjNiKQ/C1dY86pGUBtNbxAk O8lT7liwkWoV/4TlcXGWhNYqj2wgar5HeilqWn/2Cxfz6jOBESRXYYuOOt6y8h90J5HI l4b9O0bRFcVK+iZhi0YXtqfRO8QcIk8vXqEGyKYY/l8TNpTkpP8WoyPrgq2dODBdk7Bw LW6d9m84o7l0T4+8QsXcCD2gVKwcgNmig7e2X+KHmiyFxXSnEDQmyzuI0pC+pCxZycBf 1d9w== X-Gm-Message-State: ACrzQf1wv3fi8t4gs7vyJdTf3FXYUKSQmbsjndirw6ub2PjyaI/u3h9D 0hNFPX5NaQB8yT1nGJ9nqtKGOANdocJKd0p/cvi4fA== X-Google-Smtp-Source: AMsMyM4RCzDu9DE1SgMdp+TCHAnmXWjm2D/kY89a9RpcBY1OK3SAh2E+19si06YAqT4aoi2eeQCzNy8ngm5l9Ym0oU4= X-Received: by 2002:a05:6102:301a:b0:3a7:8755:2b7e with SMTP id s26-20020a056102301a00b003a787552b7emr4741009vsa.32.1665494924704; Tue, 11 Oct 2022 06:28:44 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ab0:136f:0:b0:3d2:4916:f286 with HTTP; Tue, 11 Oct 2022 06:28:44 -0700 (PDT) In-Reply-To: <20221007155323.ue4cdthkilfy4lbd@box.shutemov.name> References: <20220704135833.1496303-1-martin.fernandez@eclypsium.com> <20220704135833.1496303-3-martin.fernandez@eclypsium.com> <20221007155323.ue4cdthkilfy4lbd@box.shutemov.name> From: Martin Fernandez Date: Tue, 11 Oct 2022 10:28:44 -0300 Message-ID: Subject: Re: [PATCH v9 2/9] mm/mmzone: Tag pg_data_t with crypto capabilities To: "Kirill A. Shutemov" Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, ardb@kernel.org, dvhart@infradead.org, andy@infradead.org, gregkh@linuxfoundation.org, rafael@kernel.org, rppt@kernel.org, akpm@linux-foundation.org, daniel.gutson@eclypsium.com, hughsient@gmail.com, alex.bazhaniuk@eclypsium.com, alison.schofield@intel.com, keescook@chromium.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/7/22, Kirill A. Shutemov wrote: > On Mon, Jul 04, 2022 at 10:58:26AM -0300, Martin Fernandez wrote: >> Add a new member in the pg_data_t struct to tell whether the node >> corresponding to that pg_data_t is able to do hardware memory >> encryption. >> >> This will be read from sysfs. >> >> Signed-off-by: Martin Fernandez >> --- >> include/linux/mmzone.h | 3 +++ >> mm/page_alloc.c | 1 + >> 2 files changed, 4 insertions(+) >> >> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h >> index aab70355d64f..6fd4785f1d05 100644 >> --- a/include/linux/mmzone.h >> +++ b/include/linux/mmzone.h >> @@ -883,6 +883,9 @@ typedef struct pglist_data { >> struct task_struct *kcompactd; >> bool proactive_compact_trigger; >> #endif >> + >> + bool crypto_capable; >> + > > There's already pgdat->flags. Any reason we cannot encode it there? Not really a reason, I'll considerate when I send then next version. I tried to quickly find for references of what kind of flags does it have, I didn't find any. Do you suggest it should work? >> /* >> * This is a per-node reserve of pages that are not available >> * to userspace allocations. >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index e008a3df0485..147437329ac7 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -7729,6 +7729,7 @@ static void __init free_area_init_node(int nid) >> pgdat->node_id = nid; >> pgdat->node_start_pfn = start_pfn; >> pgdat->per_cpu_nodestats = NULL; >> + pgdat->crypto_capable = memblock_node_is_crypto_capable(nid); >> >> if (start_pfn != end_pfn) { >> pr_info("Initmem setup node %d [mem %#018Lx-%#018Lx]\n", nid, >> -- >> 2.30.2 >> > > -- > Kiryl Shutsemau / Kirill A. Shutemov >