Re: [Intel-gfx] [PATCH] drm/i915/tgl: Remove require_force_probe protection

[Lucas De Marchi <lucas.de.marchi@gmail.com>]

On Tue, Feb 18, 2020 at 3:07 PM José Roberto de Souza
<jose.souza@intel.com> wrote:
>
> We have a few TGL machines in our CI and it is mostly green with
> failures in tests that will not impact future Linux installations.
> Also there is no warnings, errors, flickering or any visual defects
> while doing ordinary tasks like browsing and editing documents in a
> dual monitor setup.
>
> As a reminder i915.require_force_probe was created to protect
> future Linux installation's iso images that might contain a
> kernel from the enabling time of the new platform. Without this
> protection most of linux installation was recommending
> nomodeset option during installation that was getting stick
> there after installation.
>
> Reference: https://intel-gfx-ci.01.org/tree/drm-tip/fi-tgl-u.html
> Reference: https://intel-gfx-ci.01.org/tree/drm-tip/shard-tglb.html
> Cc: James Ausmus <james.ausmus@intel.com>
> Cc: Jani Saarinen <jani.saarinen@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>

Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Also, I think it would be good to have this in 5.6 rather than 5.7.
Yes, it's late in the merge window, but it falls in the case of "New
device IDs and quirks are also accepted." of the stable kernel rules,
so could as well just go directly to this kernel. Rodrigo, is it
possible?

thanks
Lucas De Marchi

> ---
>  drivers/gpu/drm/i915/i915_pci.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 24b1f0ce8743..2146b9a865ba 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -822,7 +822,6 @@ static const struct intel_device_info tgl_info = {
>         GEN12_FEATURES,
>         PLATFORM(INTEL_TIGERLAKE),
>         .pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D),
> -       .require_force_probe = 1,
>         .display.has_modular_fia = 1,
>         .engine_mask =
>                 BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VCS2),
> --
> 2.25.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx