From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas De Marchi Subject: Re: [PATCH 5/5] drm/i915: allow shared plls to be non-consecutive Date: Thu, 17 Jan 2019 14:06:38 -0800 Message-ID: References: <20190117202113.5190-1-lucas.demarchi@intel.com> <20190117202113.5190-6-lucas.demarchi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB7486F593 for ; Thu, 17 Jan 2019 22:06:50 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id u4so12795202wrp.3 for ; Thu, 17 Jan 2019 14:06:50 -0800 (PST) In-Reply-To: <20190117202113.5190-6-lucas.demarchi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKYW4gMTcsIDIwMTkgYXQgMTI6MjEgUE0gTHVjYXMgRGUgTWFyY2hpCjxsdWNhcy5k ZW1hcmNoaUBpbnRlbC5jb20+IHdyb3RlOgo+Cj4gUmlnaHQgbm93IHdoZW4gc2VhcmNoaW5nIGZv ciBzaGFyZWQgcGxscyB3ZSBtYW5kYXRlIHRoYXQgdGhleSBoYXZlCj4gY29uc2VjdXRpdmUgSURz IHNpbmNlIHdlIGp1c3QgcGFzcyB0aGUgbWluIGFuZCBtYXggaWQgYW5kIGxvb3Agb3ZlciB0aGUK PiByYW5nZS4gSG93ZXZlciB0aGUgSURzIGNhbid0IGJlIGFyYml0cmFyaWx5IGRlZmluZWQgc2lu Y2UgdGhleSBhcmUgdXNlZAo+IGFzIGluZGV4IHRvIHRoZSBNTUlPIGFkZHJlc3MsIGhlbmNlIGRl cGVuZGVudCBvbiB3aGF0IHRoZSBoYXJkd2FyZQo+IGltcGxlbWVudHMuCj4KPiBUaGlzIGFsbG93 cyB1cyB0byB1c2UgUExMcyB0aGF0IGFyZSBub3QgY29uc2VjdXRpdmUgKGFsdGhvdWdoIHdlIGRv bid0Cj4gY3VycmVudGx5IGhhdmUgYW55IGNhc2UpIHdoaWxlIGNsYXJpZnlpbmcgdGhlIGNvZGUg cGF0aHMgaW4gd2hpY2ggb25seQo+IG9uZSBQTEwgaXMgc3VwcG9zZWQgdG8gYmUgdXNlZC4KCk90 aGVyIHBvc3NpYmxlIGFwcHJvYWNoIGZvciBpZi93aGVuIHdlIG5lZWQgdGhpcyB3b3VsZCBiZSB0 byB1c2UgYSBkaWZmZXJlbnQKbWFjcm8gdGhhdCBkb2Vzbid0IHVzZSB0aGUgaWQgYXMgdGhlIGlu ZGV4IGZvciB0aGUgcmVnaXN0ZXJzLi4uIE5vdApzdXJlIHdoaWNoIG9uZSBpcyBiZXR0ZXIuCgpM dWNhcyBEZSBNYXJjaGkKCj4KPiBTaWduZWQtb2ZmLWJ5OiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2Fz LmRlbWFyY2hpQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHBsbF9tZ3IuYyB8IDQxICsrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwbGxfbWdyLmMKPiBpbmRleCA4ZjcwODM4YWM3ZDguLjEwM2U0MmNmYTJlMyAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+IEBAIC0yNDMsOCArMjQz LDcgQEAgdm9pZCBpbnRlbF9kaXNhYmxlX3NoYXJlZF9kcGxsKGNvbnN0IHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICBzdGF0aWMgc3RydWN0IGludGVsX3NoYXJlZF9kcGxs ICoKPiAgaW50ZWxfZmluZF9zaGFyZWRfZHBsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAg ICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRl LAo+IC0gICAgICAgICAgICAgICAgICAgICAgZW51bSBpbnRlbF9kcGxsX2lkIHJhbmdlX21pbiwK PiAtICAgICAgICAgICAgICAgICAgICAgIGVudW0gaW50ZWxfZHBsbF9pZCByYW5nZV9tYXgpCj4g KyAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIHBsbF9tYXNrKQo+ICB7Cj4gICAg ICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNydGMtPmJh c2UuZGV2KTsKPiAgICAgICAgIHN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqcGxsLCAqdW51c2Vk X3BsbCA9IE5VTEw7Cj4gQEAgLTI1Myw3ICsyNTIsNyBAQCBpbnRlbF9maW5kX3NoYXJlZF9kcGxs KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+Cj4gICAgICAgICBzaGFyZWRfZHBsbCA9IGludGVs X2F0b21pY19nZXRfc2hhcmVkX2RwbGxfc3RhdGUoY3J0Y19zdGF0ZS0+YmFzZS5zdGF0ZSk7Cj4K PiAtICAgICAgIGZvciAoaSA9IHJhbmdlX21pbjsgaSA8PSByYW5nZV9tYXg7IGkrKykgewo+ICsg ICAgICAgZm9yX2VhY2hfc2V0X2JpdChpLCAmcGxsX21hc2ssIEk5MTVfTlVNX1BMTFMpIHsKPiAg ICAgICAgICAgICAgICAgcGxsID0gJmRldl9wcml2LT5zaGFyZWRfZHBsbHNbaV07Cj4KPiAgICAg ICAgICAgICAgICAgLyogT25seSB3YW50IHRvIGNoZWNrIGVuYWJsZWQgdGltaW5ncyBmaXJzdCAq Lwo+IEBAIC00MzYsOCArNDM1LDggQEAgaWJ4X2dldF9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpj cnRjLCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBwbGwtPmluZm8tPm5hbWUpOwo+ICAgICAgICAgfSBlbHNlIHsKPiAg ICAgICAgICAgICAgICAgcGxsID0gaW50ZWxfZmluZF9zaGFyZWRfZHBsbChjcnRjLCBjcnRjX3N0 YXRlLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERQTExf SURfUENIX1BMTF9BLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIERQTExfSURfUENIX1BMTF9CKTsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBHRU5NQVNLKERQTExfSURfUENIX1BMTF9CLAo+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRFBMTF9JRF9QQ0hfUExMX0Ep KTsKPiAgICAgICAgIH0KPgo+ICAgICAgICAgaWYgKCFwbGwpCj4gQEAgLTc4MCw3ICs3NzksNyBA QCBzdGF0aWMgc3RydWN0IGludGVsX3NoYXJlZF9kcGxsICpoc3dfZGRpX2hkbWlfZ2V0X2RwbGwo aW50IGNsb2NrLAo+ICAgICAgICAgY3J0Y19zdGF0ZS0+ZHBsbF9od19zdGF0ZS53cnBsbCA9IHZh bDsKPgo+ICAgICAgICAgcGxsID0gaW50ZWxfZmluZF9zaGFyZWRfZHBsbChjcnRjLCBjcnRjX3N0 YXRlLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBEUExMX0lEX1dSUExM MSwgRFBMTF9JRF9XUlBMTDIpOwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBHRU5NQVNLKERQTExfSURfV1JQTEwyLCBEUExMX0lEX1dSUExMMSkpOwo+Cj4gICAgICAgICBp ZiAoIXBsbCkKPiAgICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gQEAgLTg0MCw3ICs4Mzks NyBAQCBoc3dfZ2V0X2RwbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMsIHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAgICAgICAgICAgICAgICAgICAgICAgIFNQTExfUExM X0VOQUJMRSB8IFNQTExfUExMX0ZSRVFfMTM1ME1IeiB8IFNQTExfUExMX1NTQzsKPgo+ICAgICAg ICAgICAgICAgICBwbGwgPSBpbnRlbF9maW5kX3NoYXJlZF9kcGxsKGNydGMsIGNydGNfc3RhdGUs Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRFBMTF9JRF9T UExMLCBEUExMX0lEX1NQTEwpOwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIEJJVChEUExMX0lEX1NQTEwpKTsKPiAgICAgICAgIH0gZWxzZSB7Cj4gICAgICAg ICAgICAgICAgIHJldHVybiBOVUxMOwo+ICAgICAgICAgfQo+IEBAIC0xMzg5LDYgKzEzODgsNyBA QCBza2xfZ2V0X2RwbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMsIHN0cnVjdCBpbnRlbF9jcnRj X3N0YXRlICpjcnRjX3N0YXRlLAo+ICAgICAgICAgaW50IGNsb2NrID0gY3J0Y19zdGF0ZS0+cG9y dF9jbG9jazsKPiAgICAgICAgIGJvb2wgYnJldDsKPiAgICAgICAgIHN0cnVjdCBpbnRlbF9kcGxs X2h3X3N0YXRlIGRwbGxfaHdfc3RhdGU7Cj4gKyAgICAgICB1bnNpZ25lZCBsb25nIHBsbF9tYXNr Owo+Cj4gICAgICAgICBtZW1zZXQoJmRwbGxfaHdfc3RhdGUsIDAsIHNpemVvZihkcGxsX2h3X3N0 YXRlKSk7Cj4KPiBAQCAtMTQxMCwxMyArMTQxMCwxMSBAQCBza2xfZ2V0X2RwbGwoc3RydWN0IGlu dGVsX2NydGMgKmNydGMsIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAg ICAgICAgfQo+Cj4gICAgICAgICBpZiAoaW50ZWxfY3J0Y19oYXNfdHlwZShjcnRjX3N0YXRlLCBJ TlRFTF9PVVRQVVRfRURQKSkKPiAtICAgICAgICAgICAgICAgcGxsID0gaW50ZWxfZmluZF9zaGFy ZWRfZHBsbChjcnRjLCBjcnRjX3N0YXRlLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIERQTExfSURfU0tMX0RQTEwwLAo+IC0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIERQTExfSURfU0tMX0RQTEwwKTsKPiArICAgICAgICAg ICAgICAgcGxsX21hc2sgPSBCSVQoRFBMTF9JRF9TS0xfRFBMTDApOwo+ICAgICAgICAgZWxzZQo+ IC0gICAgICAgICAgICAgICBwbGwgPSBpbnRlbF9maW5kX3NoYXJlZF9kcGxsKGNydGMsIGNydGNf c3RhdGUsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRFBM TF9JRF9TS0xfRFBMTDEsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgRFBMTF9JRF9TS0xfRFBMTDMpOwo+ICsgICAgICAgICAgICAgICBwbGxfbWFzayA9IEdF Tk1BU0soRFBMTF9JRF9TS0xfRFBMTDMsIERQTExfSURfU0tMX0RQTEwxKTsKPiArCj4gKyAgICAg ICBwbGwgPSBpbnRlbF9maW5kX3NoYXJlZF9kcGxsKGNydGMsIGNydGNfc3RhdGUsIHBsbF9tYXNr KTsKPiAgICAgICAgIGlmICghcGxsKQo+ICAgICAgICAgICAgICAgICByZXR1cm4gTlVMTDsKPgo+ IEBAIC0yMzkwLDggKzIzODgsOCBAQCBjbmxfZ2V0X2RwbGwoc3RydWN0IGludGVsX2NydGMgKmNy dGMsIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAgICAgICAgfQo+Cj4g ICAgICAgICBwbGwgPSBpbnRlbF9maW5kX3NoYXJlZF9kcGxsKGNydGMsIGNydGNfc3RhdGUsCj4g LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERQTExfSURfU0tMX0RQTEwwLAo+ IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBEUExMX0lEX1NLTF9EUExMMik7 Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdFTk1BU0soRFBMTF9JRF9T S0xfRFBMTDIsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg RFBMTF9JRF9TS0xfRFBMTDApKTsKPiAgICAgICAgIGlmICghcGxsKSB7Cj4gICAgICAgICAgICAg ICAgIERSTV9ERUJVR19LTVMoIk5vIFBMTCBzZWxlY3RlZFxuIik7Cj4gICAgICAgICAgICAgICAg IHJldHVybiBOVUxMOwo+IEBAIC0yODk5LDEzICsyODk3LDEyIEBAIGljbF9nZXRfZHBsbChzdHJ1 Y3QgaW50ZWxfY3J0YyAqY3J0Yywgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUs Cj4gICAgICAgICBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbDsKPiAgICAgICAgIHN0cnVj dCBpbnRlbF9kcGxsX2h3X3N0YXRlIHBsbF9zdGF0ZSA9IHt9Owo+ICAgICAgICAgZW51bSBwb3J0 IHBvcnQgPSBlbmNvZGVyLT5wb3J0Owo+IC0gICAgICAgZW51bSBpbnRlbF9kcGxsX2lkIG1pbiwg bWF4Owo+ICsgICAgICAgdW5zaWduZWQgbG9uZyBwbGxfbWFzazsKPiAgICAgICAgIGludCBjbG9j ayA9IGNydGNfc3RhdGUtPnBvcnRfY2xvY2s7Cj4gICAgICAgICBib29sIHJldDsKPgo+ICAgICAg ICAgaWYgKGludGVsX3BvcnRfaXNfY29tYm9waHkoZGV2X3ByaXYsIHBvcnQpKSB7Cj4gLSAgICAg ICAgICAgICAgIG1pbiA9IERQTExfSURfSUNMX0RQTEwwOwo+IC0gICAgICAgICAgICAgICBtYXgg PSBEUExMX0lEX0lDTF9EUExMMTsKPiArICAgICAgICAgICAgICAgcGxsX21hc2sgPSBHRU5NQVNL KERQTExfSURfSUNMX0RQTEwxLCBEUExMX0lEX0lDTF9EUExMMCk7Cj4gICAgICAgICAgICAgICAg IHJldCA9IGljbF9jYWxjX2RwbGxfc3RhdGUoY3J0Y19zdGF0ZSwgZW5jb2RlciwgY2xvY2ssCj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJnBsbF9zdGF0ZSk7Cj4g ICAgICAgICB9IGVsc2UgaWYgKGludGVsX3BvcnRfaXNfdGMoZGV2X3ByaXYsIHBvcnQpKSB7Cj4g QEAgLTI5MTksMTYgKzI5MTYsMTQgQEAgaWNsX2dldF9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpj cnRjLCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiAgICAgICAgICAgICAg ICAgfQo+Cj4gICAgICAgICAgICAgICAgIGlmIChpbnRlbF9kaWdfcG9ydC0+dGNfdHlwZSA9PSBU Q19QT1JUX1RCVCkgewo+IC0gICAgICAgICAgICAgICAgICAgICAgIG1pbiA9IERQTExfSURfSUNM X1RCVFBMTDsKPiAtICAgICAgICAgICAgICAgICAgICAgICBtYXggPSBtaW47Cj4gKyAgICAgICAg ICAgICAgICAgICAgICAgcGxsX21hc2sgPSBCSVQoRFBMTF9JRF9JQ0xfVEJUUExMKTsKPiAgICAg ICAgICAgICAgICAgICAgICAgICByZXQgPSBpY2xfY2FsY19kcGxsX3N0YXRlKGNydGNfc3RhdGUs IGVuY29kZXIsIGNsb2NrLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJnBsbF9zdGF0ZSk7Cj4gICAgICAgICAgICAgICAgIH0gZWxzZSB7Cj4gICAg ICAgICAgICAgICAgICAgICAgICAgZW51bSB0Y19wb3J0IHRjX3BvcnQ7Cj4KPiAgICAgICAgICAg ICAgICAgICAgICAgICB0Y19wb3J0ID0gaW50ZWxfcG9ydF90b190YyhkZXZfcHJpdiwgcG9ydCk7 Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgbWluID0gaWNsX3RjX3BvcnRfdG9fcGxsX2lkKHRj X3BvcnQpOwo+IC0gICAgICAgICAgICAgICAgICAgICAgIG1heCA9IG1pbjsKPiArICAgICAgICAg ICAgICAgICAgICAgICBwbGxfbWFzayA9IEJJVChpY2xfdGNfcG9ydF90b19wbGxfaWQodGNfcG9y dCkpOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIHJldCA9IGljbF9jYWxjX21nX3BsbF9zdGF0 ZShjcnRjX3N0YXRlLCBlbmNvZGVyLCBjbG9jaywKPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJnBsbF9zdGF0ZSk7Cj4gICAgICAgICAgICAgICAg IH0KPiBAQCAtMjk0NCw3ICsyOTM5LDcgQEAgaWNsX2dldF9kcGxsKHN0cnVjdCBpbnRlbF9jcnRj ICpjcnRjLCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPgo+ICAgICAgICAg Y3J0Y19zdGF0ZS0+ZHBsbF9od19zdGF0ZSA9IHBsbF9zdGF0ZTsKPgo+IC0gICAgICAgcGxsID0g aW50ZWxfZmluZF9zaGFyZWRfZHBsbChjcnRjLCBjcnRjX3N0YXRlLCBtaW4sIG1heCk7Cj4gKyAg ICAgICBwbGwgPSBpbnRlbF9maW5kX3NoYXJlZF9kcGxsKGNydGMsIGNydGNfc3RhdGUsIHBsbF9t YXNrKTsKPiAgICAgICAgIGlmICghcGxsKSB7Cj4gICAgICAgICAgICAgICAgIERSTV9ERUJVR19L TVMoIk5vIFBMTCBzZWxlY3RlZFxuIik7Cj4gICAgICAgICAgICAgICAgIHJldHVybiBOVUxMOwo+ IC0tCj4gMi4yMC4wCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngKCgoKLS0gCkx1Y2FzIERlIE1hcmNoaQpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK