From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0Fry-00062b-2b for qemu-devel@nongnu.org; Thu, 26 Jun 2014 16:02:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0Frt-0003Oj-4m for qemu-devel@nongnu.org; Thu, 26 Jun 2014 16:02:06 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:45669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0Frs-0003Ob-W7 for qemu-devel@nongnu.org; Thu, 26 Jun 2014 16:02:01 -0400 Received: by mail-ob0-f171.google.com with SMTP id nu7so4489966obb.2 for ; Thu, 26 Jun 2014 13:02:00 -0700 (PDT) MIME-Version: 1.0 Sender: camm@ualberta.ca In-Reply-To: References: <87vbs6qjhj.fsf_-_@blackfin.pond.sub.org> <5399CF09.8030803@6wind.com> <87ppidnqmy.fsf@blackfin.pond.sub.org> <539AC3E0.9090404@6wind.com> <539ACDE6.7020709@redhat.com> <539AFF7C.7090702@6wind.com> <539B064D.2050501@redhat.com> <53A00464.8090609@6wind.com> <53A00DEB.8030400@redhat.com> <20140618104849.GH14030@stefanha-thinkpad.redhat.com> <53A1A8BE.3000801@6wind.com> Date: Thu, 26 Jun 2014 14:02:00 -0600 Message-ID: From: Cam Macdonell Content-Type: multipart/alternative; boundary=089e013cc23673dc6804fcc2aa9b Subject: Re: [Qemu-devel] Why I advise against using ivshmem List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Henning Schild , Olivier MATZ , qemu-devel , Linux Virtualization , "thomas.monjalon@6wind.com" , Paolo Bonzini , Vincent JARDIN , David Marchand --089e013cc23673dc6804fcc2aa9b Content-Type: text/plain; charset=UTF-8 Hello, Just to add my two bits. I will fully support getting all the necessary parts of ivshmem into tree where appropriate, both qemu and a driver in Linux. I understand those concerns. I do not have the time to fully maintain ivshmem at the level needed, but I will help as much as I can. Sorry for the delay in contributing to this conversation. Cheers, Cam On Sat, Jun 21, 2014 at 3:34 AM, Stefan Hajnoczi wrote: > On Wed, Jun 18, 2014 at 10:57 PM, David Marchand > wrote: > > On 06/18/2014 12:48 PM, Stefan Hajnoczi wrote: > >> > >> One more thing to add to the list: > >> > >> static void ivshmem_read(void *opaque, const uint8_t * buf, int flags) > >> > >> The "flags" argument should be "size". Size should be checked before > >> accessing buf. > > > > > > You are welcome to send a fix and I will review it. > > I don't plan to send ivshmem patches in the near future because I > don't use or support it. > > I thought you were interested in bringing ivshmem up to a level where > distros feel comfortable enabling and supporting it. Getting there > will require effort from you to audit, clean up, and achieve test > coverage. That's what a maintainer needs to do in a case like this. > > Stefan > _______________________________________________ > Virtualization mailing list > Virtualization@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/virtualization > > --089e013cc23673dc6804fcc2aa9b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello,

Just to add my two bits.

I will fully support getting all the necessary parts of i= vshmem into tree where appropriate, both qemu and a driver in Linux. =C2=A0= I understand those concerns.

I do not have the time to fully maintain ivshmem at the= level needed, but I will help as much as I can.

S= orry for the delay in contributing to this conversation.

Cheers,
Cam

=
On Sat, Jun 21, 2014 at 3:34 AM, Stefan Hajn= oczi <stefanha@gmail.com> wrote:
On Wed, Jun 18, 2014 at 10:5= 7 PM, David Marchand
<david.marchand@6wind.com> wrote:
> On 06/18/2014 12:48 PM, Stefan Hajnoczi wrote:
>>
>> One more thing to add to the list:
>>
>> static void ivshmem_read(void *opaque, const uint8_t * buf, int fl= ags)
>>
>> The "flags" argument should be "size". =C2=A0S= ize should be checked before
>> accessing buf.
>
>
> You are welcome to send a fix and I will review it.

I don't plan to send ivshmem patches in the near future because I=
don't use or support it.

I thought you were interested in bringing ivshmem up to a level where
distros feel comfortable enabling and supporting it. =C2=A0Getting there will require effort from you to audit, clean up, and achieve test
coverage. =C2=A0That's what a maintainer needs to do in a case like thi= s.

Stefan
_____________________= __________________________
Virtualization mailing list
Virtualization= @lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/vir= tualization


--089e013cc23673dc6804fcc2aa9b-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cam Macdonell Subject: Re: [Qemu-devel] Why I advise against using ivshmem Date: Thu, 26 Jun 2014 14:02:00 -0600 Message-ID: References: <87vbs6qjhj.fsf_-_@blackfin.pond.sub.org> <5399CF09.8030803@6wind.com> <87ppidnqmy.fsf@blackfin.pond.sub.org> <539AC3E0.9090404@6wind.com> <539ACDE6.7020709@redhat.com> <539AFF7C.7090702@6wind.com> <539B064D.2050501@redhat.com> <53A00464.8090609@6wind.com> <53A00DEB.8030400@redhat.com> <20140618104849.GH14030@stefanha-thinkpad.redhat.com> <53A1A8BE.3000801@6wind.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8626326949085288923==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Stefan Hajnoczi Cc: Henning Schild , Olivier MATZ , qemu-devel , Linux Virtualization , "thomas.monjalon@6wind.com" , Paolo Bonzini , Vincent JARDIN , David Marchand List-Id: virtualization@lists.linuxfoundation.org --===============8626326949085288923== Content-Type: multipart/alternative; boundary=089e013cc23673dc6804fcc2aa9b --089e013cc23673dc6804fcc2aa9b Content-Type: text/plain; charset=UTF-8 Hello, Just to add my two bits. I will fully support getting all the necessary parts of ivshmem into tree where appropriate, both qemu and a driver in Linux. I understand those concerns. I do not have the time to fully maintain ivshmem at the level needed, but I will help as much as I can. Sorry for the delay in contributing to this conversation. Cheers, Cam On Sat, Jun 21, 2014 at 3:34 AM, Stefan Hajnoczi wrote: > On Wed, Jun 18, 2014 at 10:57 PM, David Marchand > wrote: > > On 06/18/2014 12:48 PM, Stefan Hajnoczi wrote: > >> > >> One more thing to add to the list: > >> > >> static void ivshmem_read(void *opaque, const uint8_t * buf, int flags) > >> > >> The "flags" argument should be "size". Size should be checked before > >> accessing buf. > > > > > > You are welcome to send a fix and I will review it. > > I don't plan to send ivshmem patches in the near future because I > don't use or support it. > > I thought you were interested in bringing ivshmem up to a level where > distros feel comfortable enabling and supporting it. Getting there > will require effort from you to audit, clean up, and achieve test > coverage. That's what a maintainer needs to do in a case like this. > > Stefan > _______________________________________________ > Virtualization mailing list > Virtualization@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/virtualization > > --089e013cc23673dc6804fcc2aa9b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello,

Just to add my two bits.

I will fully support getting all the necessary parts of i= vshmem into tree where appropriate, both qemu and a driver in Linux. =C2=A0= I understand those concerns.

I do not have the time to fully maintain ivshmem at the= level needed, but I will help as much as I can.

S= orry for the delay in contributing to this conversation.

Cheers,
Cam

=
On Sat, Jun 21, 2014 at 3:34 AM, Stefan Hajn= oczi <stefanha@gmail.com> wrote:
On Wed, Jun 18, 2014 at 10:5= 7 PM, David Marchand
<david.marchand@6wind.com> wrote:
> On 06/18/2014 12:48 PM, Stefan Hajnoczi wrote:
>>
>> One more thing to add to the list:
>>
>> static void ivshmem_read(void *opaque, const uint8_t * buf, int fl= ags)
>>
>> The "flags" argument should be "size". =C2=A0S= ize should be checked before
>> accessing buf.
>
>
> You are welcome to send a fix and I will review it.

I don't plan to send ivshmem patches in the near future because I=
don't use or support it.

I thought you were interested in bringing ivshmem up to a level where
distros feel comfortable enabling and supporting it. =C2=A0Getting there will require effort from you to audit, clean up, and achieve test
coverage. =C2=A0That's what a maintainer needs to do in a case like thi= s.

Stefan
_____________________= __________________________
Virtualization mailing list
Virtualization= @lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/vir= tualization


--089e013cc23673dc6804fcc2aa9b-- --===============8626326949085288923== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization --===============8626326949085288923==--