From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6X8d-00080t-OF for qemu-devel@nongnu.org; Mon, 23 Oct 2017 03:27:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e6X8c-0003k2-MJ for qemu-devel@nongnu.org; Mon, 23 Oct 2017 03:27:07 -0400 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:51738) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e6X8c-0003jK-FW for qemu-devel@nongnu.org; Mon, 23 Oct 2017 03:27:06 -0400 Received: by mail-wr0-x243.google.com with SMTP id j15so4124651wre.8 for ; Mon, 23 Oct 2017 00:27:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Alistair Francis Date: Mon, 23 Oct 2017 09:26:33 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH v3 0/5] Add a valid_cpu_types property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis , Peter Maydell Cc: "qemu-devel@nongnu.org Developers" , Eduardo Habkost , Marcel Apfelbaum , Igor Mammedov , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= On Wed, Oct 18, 2017 at 12:31 AM, Alistair Francis wrote: > There are numorous QEMU machines that only have a single or a handful of > valid CPU options. To simplyfy the management of specificying which CPU > is/isn't valid let's create a property that can be set in the machine > init. We can then check to see if the user supplied CPU is in that list > or not. > > I have added the valid_cpu_types for some ARM machines only at the > moment. > > Here is what specifying the CPUs looks like now: > > $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-m3" -S > QEMU 2.10.50 monitor - type 'help' for more information > (qemu) info cpus > * CPU #0: thread_id=24175 > (qemu) q > > $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-m4" -S > QEMU 2.10.50 monitor - type 'help' for more information > (qemu) q > > $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-m5" -S > qemu-system-aarch64: unable to find CPU model 'cortex-m5' > > $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-a9" -S > qemu-system-aarch64: Invalid CPU type: cortex-a9-arm-cpu > The valid types are: cortex-m3-arm-cpu, cortex-m4-arm-cpu It looks like all the patches have been reviewed now. Can this go through your tree Peter? Thanks, Alistair > > V3: > - Make the varialbes static > V2: > - Rebase > - Reorder patches > - Add a Raspberry Pi 2 CPU fix > V1: > - Small fixes to prepare a series instead of RFC > - Add commit messages for the commits > - Expand the machine support to ARM machines > RFC v2: > - Rebase on Igor's work > - Use more QEMUisms inside the code > - List the supported machines in a NULL terminated array > > Alistair Francis (5): > netduino2: Specify the valid CPUs > bcm2836: Use the Cortex-A7 instead of Cortex-A15 > raspi: Specify the valid CPUs > xlnx-zcu102: Specify the valid CPUs > xilinx_zynq: Specify the valid CPUs > > hw/arm/bcm2836.c | 2 +- > hw/arm/netduino2.c | 10 +++++++++- > hw/arm/raspi.c | 7 +++++++ > hw/arm/xilinx_zynq.c | 6 ++++++ > hw/arm/xlnx-zcu102.c | 17 +++++++++++++++++ > 5 files changed, 40 insertions(+), 2 deletions(-) > > -- > 2.11.0 >