Re: [PATCH 2/4] scons.bbclass: use python3-scons

[Alistair Francis <alistair23@gmail.com>]

On Mon, Jun 24, 2019 at 1:20 AM Adrian Bunk <bunk@stusta.de> wrote:
>
> On Sun, Jun 23, 2019 at 07:41:05PM -0700, Alistair Francis wrote:
> > On Thu, Jun 20, 2019 at 5:22 PM Tim Orling <ticotimo@gmail.com> wrote:
> > >
> > >
> > >
> > > On Thu, Jun 20, 2019 at 6:37 AM Khem Raj <raj.khem@gmail.com> wrote:
> > >>
> > >> On Fri, Jun 7, 2019 at 5:50 PM Tim Orling
> > >> <timothy.t.orling@linux.intel.com> wrote:
> > >> >
> > >> > SCons has supported python3 since 3.0.0 release, use it.
> > >> >
> > >> > [YOCTO #13381]
> > >> >
> > >> > Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
> > >> > ---
> > >> >  meta/classes/scons.bbclass | 2 +-
> > >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >> >
> > >> > diff --git a/meta/classes/scons.bbclass b/meta/classes/scons.bbclass
> > >> > index 9ee7d1587d..a8ddae35f7 100644
> > >> > --- a/meta/classes/scons.bbclass
> > >> > +++ b/meta/classes/scons.bbclass
> > >> > @@ -1,4 +1,4 @@
> > >> > -DEPENDS += "python-scons-native"
> > >> > +DEPENDS += "python3-scons-native"
> > >> >
> > >>
> > >> some packages haven't upgraded to py3 but use scons see
> > >> https://errors.yoctoproject.org/Errors/Details/249271/
> > >
> > >
> > >
> > > Thank you for reporting this. I was of course expecting some breakage and am committed to fixes. Please do report any other issues.
> >
> > This also breaks the gpsd install, I tried upgrading to the latest
> > release and that didn't help. I am going to send a patch for the
> > upgrade which I tested with this patch reverted.
>
> This is already workarounded:
> http://git.openembedded.org/meta-openembedded/commit/?h=master-next&id=22bfe06d15e07cac0df3f34566a9d33007663bae

Argh, I must not have pulled recently enough.

>
> There are post-3.18.1 changes required for Python 3 scons,
> but I went for this hack after seeing that a proper fix
> would involve all of:
> 1. upgrading to 3.18.1
> 2. rebasing oe-only patches to 3.18.1

I sent a patch (with you CCed) that does the first two.

> 3. adding post-3.18.1 patches

How hard would this be? I'm happy to look into it but I didn't see
anything in the gpsd tree that seemed to fix the issue.

Alistair

>
> > Alistair
>
> cu
> Adrian
>
> --
>
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
>