From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EAE8C00140 for ; Wed, 10 Aug 2022 22:03:25 +0000 (UTC) Received: from localhost ([::1]:42576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLtnQ-0008Fk-KO for qemu-devel@archiver.kernel.org; Wed, 10 Aug 2022 18:03:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLtjj-0005jy-HB; Wed, 10 Aug 2022 17:59:36 -0400 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:40704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLtjh-0002tb-VY; Wed, 10 Aug 2022 17:59:35 -0400 Received: by mail-pg1-x52f.google.com with SMTP id f11so15505102pgj.7; Wed, 10 Aug 2022 14:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=DNpQsd4YfubZwp4IIujnt4Jmh8W5T0Br99zl1yh92OQ=; b=DtCXwE/8qa14r0TP1qUH07FikkYJj3y71cKMbzne0lkJgNJha2LFvq2uSMiRweNJTe a9yR7uFZ81wx6JfCV9ILXKgi+SyzSR+ZPXP76I65s1f0T6rwVjtNRczPMYDTTzAT7fgc 3CNs6D7gwRqMuObzfRtaUO5lthBSCXRXDB2zt6C/+fuXPrcK7MDttM8czG+72sISkf9n ERIwf9YU5aLrHlzdjlqcsw8sSfptCx5wDD6Zrs6DartZ/dY9YzwgNRJ4Zdsc7ey8lnyJ osHy6hpDR62/C170mXEliUBQkq39H6fnwf9RNQa9tu+v7NcCgR3bRUT1jDhXAmZ64pMH v+Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=DNpQsd4YfubZwp4IIujnt4Jmh8W5T0Br99zl1yh92OQ=; b=pu66C9yewTFOnJ8+1W+Jktkj3fLhuJxPS2J5HL2mqY+aY9sQbM30r6i8UGwIHFslr8 VjWgzm1Fv2EPGSHOVGnRP5fhYU/j6RaI0UBbx6FE/LE6VGnLYr1iOKxnX5jPQKHC9PhS l8TJEu7vWsUegUzEOb6A+F0yPn278FlDSF2igXk/rQvDkKH1S6J7n5QAfdiDUBiiqypD rt30DkeP6lCPqAZa6HVHiUvQlw7LIQaHJ7YJ7HbJw5ufq1RSkcyihEBffqvWTclF1bcs 2DJDbrDQdAHVrnRalE4qE0v1VVRh3xKwxeKYUjdlPTYA1JQcha1AJIrrgvF5LvwTJBhe kXwg== X-Gm-Message-State: ACgBeo0hI0kGfCt8dbWA9xADTvGo9EOBtCRXixVet+Qxl3BOrZuPMkN3 0iGXNliGtos5nMMAabX6E+D85Sb7BJ+txkGVP2Y= X-Google-Smtp-Source: AA6agR45Kzt9NZP38B559dQi+ykDS+4fa7bvQyXt5GTjk7YNWBilyrXKhObjBbfvqZwW4Wj4oDZxGsy+5EVuG7ZKkQc= X-Received: by 2002:a63:f14c:0:b0:41a:b83d:a636 with SMTP id o12-20020a63f14c000000b0041ab83da636mr24443983pgk.361.1660168771843; Wed, 10 Aug 2022 14:59:31 -0700 (PDT) MIME-Version: 1.0 References: <20220809185639.750345-1-qemu@ben.fluff.org> <20220809185639.750345-5-qemu@ben.fluff.org> In-Reply-To: <20220809185639.750345-5-qemu@ben.fluff.org> From: Alistair Francis Date: Thu, 11 Aug 2022 07:59:05 +1000 Message-ID: Subject: Re: [PATCH v4 4/6] hw/core: use qemu_fdt_setprop_strings() To: Ben Dooks Cc: "qemu-devel@nongnu.org Developers" , "open list:RISC-V" , Alistair Francis , Peter Maydell , qemu-arm Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=alistair23@gmail.com; helo=mail-pg1-x52f.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Aug 10, 2022 at 5:13 AM Ben Dooks wrote: > > Change to using the qemu_fdt_setprop_strings() helper in > hw/core code. > > Signed-off-by: Ben Dooks Reviewed-by: Alistair Francis Alistair > --- > hw/core/guest-loader.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/hw/core/guest-loader.c b/hw/core/guest-loader.c > index c61ebc4144..7b8e32e06f 100644 > --- a/hw/core/guest-loader.c > +++ b/hw/core/guest-loader.c > @@ -56,18 +56,15 @@ static void loader_insert_platform_data(GuestLoaderState *s, int size, > qemu_fdt_setprop(fdt, node, "reg", ®_attr, sizeof(reg_attr)); > > if (s->kernel) { > - const char *compat[2] = { "multiboot,module", "multiboot,kernel" }; > - qemu_fdt_setprop_string_array(fdt, node, "compatible", > - (char **) &compat, > - ARRAY_SIZE(compat)); > + qemu_fdt_setprop_strings(fdt, node, "compatible", > + "multiboot,module", "multiboot,kernel"); > + > if (s->args) { > qemu_fdt_setprop_string(fdt, node, "bootargs", s->args); > } > } else if (s->initrd) { > - const char *compat[2] = { "multiboot,module", "multiboot,ramdisk" }; > - qemu_fdt_setprop_string_array(fdt, node, "compatible", > - (char **) &compat, > - ARRAY_SIZE(compat)); > + qemu_fdt_setprop_strings(fdt, node, "compatible", > + "multiboot,module", "multiboot,ramdisk"); > } > } > > -- > 2.35.1 > >