From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxhRt-0004TA-FQ for qemu-devel@nongnu.org; Thu, 28 Sep 2017 18:38:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxhRs-0005Pu-Jk for qemu-devel@nongnu.org; Thu, 28 Sep 2017 18:38:29 -0400 MIME-Version: 1.0 In-Reply-To: References: <1788278d-9437-34a0-4a17-d7914d459f77@redhat.com> From: Alistair Francis Date: Thu, 28 Sep 2017 15:37:55 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH v1 1/8] Replace all occurances of __FUNCTION__ with __func__ List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Eric Blake , Alistair Francis , QEMU Developers , Stefano Stabellini , Fam Zheng , Qemu-block , Juan Quintela , "Dr. David Alan Gilbert" , Markus Armbruster , Anthony Perard , qemu-arm , Gerd Hoffmann , Stefan Hajnoczi , Yongbok Kim , "open list:X86" , John Snow , Aurelien Jarno List-ID: On Wed, Sep 27, 2017 at 4:47 PM, Peter Maydell wrote: > On 26 September 2017 at 06:32, Eric Blake wrote: >> On 09/25/2017 07:08 PM, Alistair Francis wrote: >>> diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c >>> index 58005b6619..32687afced 100644 >>> --- a/hw/arm/nseries.c >>> +++ b/hw/arm/nseries.c >>> @@ -463,7 +463,7 @@ static uint32_t mipid_txrx(void *opaque, uint32_t cmd, int len) >>> uint8_t ret; >>> >>> if (len > 9) { >>> - hw_error("%s: FIXME: bad SPI word width %i\n", __FUNCTION__, len); >>> + hw_error("%s: FIXME: bad SPI word width %i\n", __func__, len); >> >> Not this patch's problem, but it would probably be simpler if hw_error() >> were a macro that automatically prefixed __func__, rather than making >> every caller have to supply it themselves. > > I'm not sure there's a great deal of benefit to that change, because > use of hw_error() in new code is rarely correct (it does an abort() > so it should never be used for guest-triggered conditions, which is > about the only time that you might be interested in a guest register > dump rather than just asserting). Most of its existing uses are in > crufty old device models. Ok, another excuse to leave it out :) Thanks, Alistair > > thanks > -- PMM From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alistair Francis Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v1 1/8] Replace all occurances of __FUNCTION__ with __func__ Date: Thu, 28 Sep 2017 15:37:55 -0700 Message-ID: References: <1788278d-9437-34a0-4a17-d7914d459f77@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxhRr-0002ct-Ql for xen-devel@lists.xenproject.org; Thu, 28 Sep 2017 22:38:27 +0000 Received: by mail-wr0-f196.google.com with SMTP id 97so3408836wrb.0 for ; Thu, 28 Sep 2017 15:38:26 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Peter Maydell Cc: Stefano Stabellini , Fam Zheng , Qemu-block , Juan Quintela , Markus Armbruster , Aurelien Jarno , QEMU Developers , Alistair Francis , John Snow , Yongbok Kim , qemu-arm , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , "open list:X86" , Eric Blake , "Dr. David Alan Gilbert" List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBTZXAgMjcsIDIwMTcgYXQgNDo0NyBQTSwgUGV0ZXIgTWF5ZGVsbCA8cGV0ZXIubWF5 ZGVsbEBsaW5hcm8ub3JnPiB3cm90ZToKPiBPbiAyNiBTZXB0ZW1iZXIgMjAxNyBhdCAwNjozMiwg RXJpYyBCbGFrZSA8ZWJsYWtlQHJlZGhhdC5jb20+IHdyb3RlOgo+PiBPbiAwOS8yNS8yMDE3IDA3 OjA4IFBNLCBBbGlzdGFpciBGcmFuY2lzIHdyb3RlOgo+Pj4gZGlmZiAtLWdpdCBhL2h3L2FybS9u c2VyaWVzLmMgYi9ody9hcm0vbnNlcmllcy5jCj4+PiBpbmRleCA1ODAwNWI2NjE5Li4zMjY4N2Fm Y2VkIDEwMDY0NAo+Pj4gLS0tIGEvaHcvYXJtL25zZXJpZXMuYwo+Pj4gKysrIGIvaHcvYXJtL25z ZXJpZXMuYwo+Pj4gQEAgLTQ2Myw3ICs0NjMsNyBAQCBzdGF0aWMgdWludDMyX3QgbWlwaWRfdHhy eCh2b2lkICpvcGFxdWUsIHVpbnQzMl90IGNtZCwgaW50IGxlbikKPj4+ICAgICAgdWludDhfdCBy ZXQ7Cj4+Pgo+Pj4gICAgICBpZiAobGVuID4gOSkgewo+Pj4gLSAgICAgICAgaHdfZXJyb3IoIiVz OiBGSVhNRTogYmFkIFNQSSB3b3JkIHdpZHRoICVpXG4iLCBfX0ZVTkNUSU9OX18sIGxlbik7Cj4+ PiArICAgICAgICBod19lcnJvcigiJXM6IEZJWE1FOiBiYWQgU1BJIHdvcmQgd2lkdGggJWlcbiIs IF9fZnVuY19fLCBsZW4pOwo+Pgo+PiBOb3QgdGhpcyBwYXRjaCdzIHByb2JsZW0sIGJ1dCBpdCB3 b3VsZCBwcm9iYWJseSBiZSBzaW1wbGVyIGlmIGh3X2Vycm9yKCkKPj4gd2VyZSBhIG1hY3JvIHRo YXQgYXV0b21hdGljYWxseSBwcmVmaXhlZCBfX2Z1bmNfXywgcmF0aGVyIHRoYW4gbWFraW5nCj4+ IGV2ZXJ5IGNhbGxlciBoYXZlIHRvIHN1cHBseSBpdCB0aGVtc2VsdmVzLgo+Cj4gSSdtIG5vdCBz dXJlIHRoZXJlJ3MgYSBncmVhdCBkZWFsIG9mIGJlbmVmaXQgdG8gdGhhdCBjaGFuZ2UsIGJlY2F1 c2UKPiB1c2Ugb2YgaHdfZXJyb3IoKSBpbiBuZXcgY29kZSBpcyByYXJlbHkgY29ycmVjdCAoaXQg ZG9lcyBhbiBhYm9ydCgpCj4gc28gaXQgc2hvdWxkIG5ldmVyIGJlIHVzZWQgZm9yIGd1ZXN0LXRy aWdnZXJlZCBjb25kaXRpb25zLCB3aGljaCBpcwo+IGFib3V0IHRoZSBvbmx5IHRpbWUgdGhhdCB5 b3UgbWlnaHQgYmUgaW50ZXJlc3RlZCBpbiBhIGd1ZXN0IHJlZ2lzdGVyCj4gZHVtcCByYXRoZXIg dGhhbiBqdXN0IGFzc2VydGluZykuIE1vc3Qgb2YgaXRzIGV4aXN0aW5nIHVzZXMgYXJlIGluCj4g Y3J1ZnR5IG9sZCBkZXZpY2UgbW9kZWxzLgoKT2ssIGFub3RoZXIgZXhjdXNlIHRvIGxlYXZlIGl0 IG91dCA6KQoKVGhhbmtzLApBbGlzdGFpcgoKPgo+IHRoYW5rcwo+IC0tIFBNTQoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcg bGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRl dmVsCg==