From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F0BC38BF9 for ; Mon, 24 Feb 2020 21:55:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7AB120CC7 for ; Mon, 24 Feb 2020 21:55:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZxCKUK7m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7AB120CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Lh8-0003rR-Si for qemu-devel@archiver.kernel.org; Mon, 24 Feb 2020 16:55:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57077) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6LBV-0000tL-Hu for qemu-devel@nongnu.org; Mon, 24 Feb 2020 16:22:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6LBU-0007oj-EQ for qemu-devel@nongnu.org; Mon, 24 Feb 2020 16:22:37 -0500 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]:37710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j6LBU-0007oV-6a; Mon, 24 Feb 2020 16:22:36 -0500 Received: by mail-lj1-x241.google.com with SMTP id q23so11753755ljm.4; Mon, 24 Feb 2020 13:22:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=k9AuazKj5Lyr5/IGPo5NEYoU+N88UD1nQwcmMZGXpLQ=; b=ZxCKUK7mnNGWgcJdPCeCbRtDmY9Dqt9OpWufgqFslAsrLrrDx3xstVR+u78xUltfOJ OfXkk9Qss65ugChez7fi/j3iGAJxbADwTxW4Oi+cu6E4Xc12ihzBTN68gAUewnyax+oP W3kQheUDSt16cswmGdviQ0+GTM6HA1JH9eRb68e3SFzOl4ykQMhxhqHWSVDGWUBR/S09 6FBg4P3/T/n0u0IE3Qdx1Q0WOU0Auklfwh9ltRnGihf1afahO96Tmf/6ovA4TuaYovvC goykd1Cx4mBz4cF98WdfjdEDeZl3dCvXzF73ZZDyvNs9WAapSxzYnNJ0nrQMBJzxmhKy M2zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=k9AuazKj5Lyr5/IGPo5NEYoU+N88UD1nQwcmMZGXpLQ=; b=Vb6/F6Fw46vczp+CAfWUl86D41+qQRKgRILjD64vPWbSJd/yrbKrrpvPv2xeNZ6ZHJ k4DOIYjnciw80jOOfeM6hVeTY3pqnBV0nX88dQNYRxNXGLITHqtS6LZ8DFfxKOlvMYWI ajP0baiw8pkpwjgYtMPpevHMJc16sVvmuuAsHEGJBmxyApKOCfe476Uoy5IZ3CwbfFd0 iCY3y8YRH3CoRaYVPAp3h+37Z/VKeNroCyhwXZFEEKYqw/jER6HQjEXMWmTxDV29jz0N a2+Nm6twWXnqPCvgxJ5qDdODSjOlFrJG8/tTV/JMKOUowyZ/NoKJaBuYmllimHwdC/vT jvvg== X-Gm-Message-State: APjAAAW/kkCCpH5m6bdyEbSO76ed27ydY+ZwTYtWlge1F0bGz12AIT9y 60d5mEABn6KqI9yky8WqFYqIBr0r65iX1l9asg8= X-Google-Smtp-Source: APXvYqw6NrRbRxTQ9KCys73FK8/6DZ9vhE0vqvhMHTI2T0jK2LoRuJRO1uSjr6avIlPXQVYIcOmiOUYnvqYnq0gNR2g= X-Received: by 2002:a2e:7818:: with SMTP id t24mr30769610ljc.195.1582579354670; Mon, 24 Feb 2020 13:22:34 -0800 (PST) MIME-Version: 1.0 References: <20200224204828.23167-1-philmd@redhat.com> <20200224204828.23167-2-philmd@redhat.com> In-Reply-To: <20200224204828.23167-2-philmd@redhat.com> From: Alistair Francis Date: Mon, 24 Feb 2020 13:14:59 -0800 Message-ID: Subject: Re: [PATCH v2 01/32] memory: Correctly return alias region type To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::241 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Jason Wang , Mark Cave-Ayland , "qemu-devel@nongnu.org Developers" , KONRAD Frederic , Alistair Francis , "Edgar E. Iglesias" , Subbaraya Sundeep , Qemu-block , QEMU Trivial , Magnus Damm , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Joel Stanley , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Aleksandar Rikalo , David Gibson , Artyom Tarasenko , Eduardo Habkost , Jean-Christophe Dubois , Alistair Francis , Fabien Chouteau , qemu-arm , Peter Chubb , "open list:New World" , Richard Henderson , Kevin Wolf , "open list:RISC-V" , Igor Mitsyanko , Bastian Koppelmann , Laurent Vivier , Max Reitz , Michael Walle , Palmer Dabbelt , Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Feb 24, 2020 at 12:49 PM Philippe Mathieu-Daud=C3=A9 wrote: > > Since memory region aliases are neither rom nor ram, they are > described as i/o, which is often incorrect. Return instead the > type of the original region we are aliasing. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > Cc: qemu-trivial@nongnu.org > > memory.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/memory.c b/memory.c > index aeaa8dcc9e..ce1179874e 100644 > --- a/memory.c > +++ b/memory.c > @@ -2818,6 +2818,9 @@ void address_space_destroy(AddressSpace *as) > > static const char *memory_region_type(MemoryRegion *mr) > { > + if (mr->alias) { > + return memory_region_type(mr->alias); > + } > if (memory_region_is_ram_device(mr)) { > return "ramd"; > } else if (memory_region_is_romd(mr)) { > -- > 2.21.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1j6LBf-0001N2-Ip for mharc-qemu-riscv@gnu.org; Mon, 24 Feb 2020 16:22:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57150) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6LBd-0001Gv-9t for qemu-riscv@nongnu.org; Mon, 24 Feb 2020 16:22:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6LBc-0007sG-Au for qemu-riscv@nongnu.org; Mon, 24 Feb 2020 16:22:45 -0500 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]:37710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j6LBU-0007oV-6a; Mon, 24 Feb 2020 16:22:36 -0500 Received: by mail-lj1-x241.google.com with SMTP id q23so11753755ljm.4; Mon, 24 Feb 2020 13:22:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=k9AuazKj5Lyr5/IGPo5NEYoU+N88UD1nQwcmMZGXpLQ=; b=ZxCKUK7mnNGWgcJdPCeCbRtDmY9Dqt9OpWufgqFslAsrLrrDx3xstVR+u78xUltfOJ OfXkk9Qss65ugChez7fi/j3iGAJxbADwTxW4Oi+cu6E4Xc12ihzBTN68gAUewnyax+oP W3kQheUDSt16cswmGdviQ0+GTM6HA1JH9eRb68e3SFzOl4ykQMhxhqHWSVDGWUBR/S09 6FBg4P3/T/n0u0IE3Qdx1Q0WOU0Auklfwh9ltRnGihf1afahO96Tmf/6ovA4TuaYovvC goykd1Cx4mBz4cF98WdfjdEDeZl3dCvXzF73ZZDyvNs9WAapSxzYnNJ0nrQMBJzxmhKy M2zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=k9AuazKj5Lyr5/IGPo5NEYoU+N88UD1nQwcmMZGXpLQ=; b=Vb6/F6Fw46vczp+CAfWUl86D41+qQRKgRILjD64vPWbSJd/yrbKrrpvPv2xeNZ6ZHJ k4DOIYjnciw80jOOfeM6hVeTY3pqnBV0nX88dQNYRxNXGLITHqtS6LZ8DFfxKOlvMYWI ajP0baiw8pkpwjgYtMPpevHMJc16sVvmuuAsHEGJBmxyApKOCfe476Uoy5IZ3CwbfFd0 iCY3y8YRH3CoRaYVPAp3h+37Z/VKeNroCyhwXZFEEKYqw/jER6HQjEXMWmTxDV29jz0N a2+Nm6twWXnqPCvgxJ5qDdODSjOlFrJG8/tTV/JMKOUowyZ/NoKJaBuYmllimHwdC/vT jvvg== X-Gm-Message-State: APjAAAW/kkCCpH5m6bdyEbSO76ed27ydY+ZwTYtWlge1F0bGz12AIT9y 60d5mEABn6KqI9yky8WqFYqIBr0r65iX1l9asg8= X-Google-Smtp-Source: APXvYqw6NrRbRxTQ9KCys73FK8/6DZ9vhE0vqvhMHTI2T0jK2LoRuJRO1uSjr6avIlPXQVYIcOmiOUYnvqYnq0gNR2g= X-Received: by 2002:a2e:7818:: with SMTP id t24mr30769610ljc.195.1582579354670; Mon, 24 Feb 2020 13:22:34 -0800 (PST) MIME-Version: 1.0 References: <20200224204828.23167-1-philmd@redhat.com> <20200224204828.23167-2-philmd@redhat.com> In-Reply-To: <20200224204828.23167-2-philmd@redhat.com> From: Alistair Francis Date: Mon, 24 Feb 2020 13:14:59 -0800 Message-ID: Subject: Re: [PATCH v2 01/32] memory: Correctly return alias region type To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: Peter Maydell , Paolo Bonzini , "qemu-devel@nongnu.org Developers" , Sagar Karandikar , "Michael S. Tsirkin" , Jason Wang , Mark Cave-Ayland , KONRAD Frederic , Alistair Francis , "Edgar E. Iglesias" , Max Reitz , Qemu-block , QEMU Trivial , Magnus Damm , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Joel Stanley , Palmer Dabbelt , Aleksandar Rikalo , Richard Henderson , Artyom Tarasenko , Eduardo Habkost , Alistair Francis , Fabien Chouteau , qemu-arm , Peter Chubb , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Subbaraya Sundeep , David Gibson , Kevin Wolf , "open list:RISC-V" , Igor Mitsyanko , Laurent Vivier , Jean-Christophe Dubois , Michael Walle , "open list:New World" , Aleksandar Markovic , Bastian Koppelmann , Aurelien Jarno Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::241 X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Feb 2020 21:22:46 -0000 On Mon, Feb 24, 2020 at 12:49 PM Philippe Mathieu-Daud=C3=A9 wrote: > > Since memory region aliases are neither rom nor ram, they are > described as i/o, which is often incorrect. Return instead the > type of the original region we are aliasing. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > Cc: qemu-trivial@nongnu.org > > memory.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/memory.c b/memory.c > index aeaa8dcc9e..ce1179874e 100644 > --- a/memory.c > +++ b/memory.c > @@ -2818,6 +2818,9 @@ void address_space_destroy(AddressSpace *as) > > static const char *memory_region_type(MemoryRegion *mr) > { > + if (mr->alias) { > + return memory_region_type(mr->alias); > + } > if (memory_region_is_ram_device(mr)) { > return "ramd"; > } else if (memory_region_is_romd(mr)) { > -- > 2.21.1 > >