From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49837)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alistair23@gmail.com>) id 1ad6LP-0004iA-F6
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 20:21:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alistair23@gmail.com>) id 1ad6LO-00070v-KT
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 20:21:51 -0500
Received: from mail-ob0-x243.google.com ([2607:f8b0:4003:c01::243]:35443)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alistair23@gmail.com>) id 1ad6LO-00070q-ES
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 20:21:50 -0500
Received: by mail-ob0-x243.google.com with SMTP id e7so66600obv.2
	for <qemu-devel@nongnu.org>; Mon, 07 Mar 2016 17:21:50 -0800 (PST)
MIME-Version: 1.0
Sender: alistair23@gmail.com
In-Reply-To: <CAKmqyKMQU1Susr8LAPn-yi2sY+=xFvunRiwvQB=8ohep7_pT8g@mail.gmail.com>
References: <cover.1455055858.git.alistair.francis@xilinx.com>
	<87d1rfk8ie.fsf@linaro.org>
	<CAKmqyKMQU1Susr8LAPn-yi2sY+=xFvunRiwvQB=8ohep7_pT8g@mail.gmail.com>
From: Alistair Francis <alistair.francis@xilinx.com>
Date: Mon, 7 Mar 2016 17:21:20 -0800
Message-ID: <CAKmqyKMVUA=ELPWjYOe4U6KE+A_2NxeRVOpz=b1Z-Em=phBFDQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 00/16] data-driven device registers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: Edgar Iglesias <edgar.iglesias@xilinx.com>, Peter Maydell <peter.maydell@linaro.org>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Peter Crosthwaite <crosthwaitepeter@gmail.com>, Edgar Iglesias <edgar.iglesias@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>, =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>

On Thu, Mar 3, 2016 at 1:27 PM, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> On Mon, Feb 29, 2016 at 4:26 AM, Alex Benn=C3=A9e <alex.bennee@linaro.org=
> wrote:
>>
>> Alistair Francis <alistair.francis@xilinx.com> writes:
>>
>>> This patch series is based on Peter C's original register API. His
>>> original cover letter is below.
>>>
>>> I have added a new function memory_region_add_subregion_no_print() whic=
h
>>> stops memory regions from being printed by 'info mtree'. This is used t=
o
>>> avoid evey register being printed when running 'info mtree'.
>>
>> OK I've finished my pass of v4. In general I think it is looking OK. I
>> think the main things that remain to be addressed are:
>>
>>   - not breaking up MemoryRegions for each individual register
>>   - adding some access MACROs to aid reading/grepping of macro defined
>>     registers
>>   - some patches have un-related changes in them
>>
>> Let me know when v5 is ready ;-)
>
> Thanks for your review, I'll go through and address your comments.
>

I have made some large changes to the API infrastructure so now only a
single memory region is created.

The individual registers still have all of the control (instead of
moving it to a central area) as I think it allows more customisations
in the future if required.

Thanks,

Alistair