From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bI3AP-0007Ws-3U for qemu-devel@nongnu.org; Tue, 28 Jun 2016 20:15:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bI3AN-0006jV-Ot for qemu-devel@nongnu.org; Tue, 28 Jun 2016 20:15:44 -0400 Received: from mail-ob0-x243.google.com ([2607:f8b0:4003:c01::243]:35128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bI3AN-0006jR-IB for qemu-devel@nongnu.org; Tue, 28 Jun 2016 20:15:43 -0400 Received: by mail-ob0-x243.google.com with SMTP id wj2so423662obc.2 for ; Tue, 28 Jun 2016 17:15:43 -0700 (PDT) MIME-Version: 1.0 Sender: alistair23@gmail.com In-Reply-To: <1465835259-21449-3-git-send-email-fred.konrad@greensocs.com> References: <1465835259-21449-1-git-send-email-fred.konrad@greensocs.com> <1465835259-21449-3-git-send-email-fred.konrad@greensocs.com> From: Alistair Francis Date: Tue, 28 Jun 2016 17:15:13 -0700 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [RFC PATCH 02/11] qemu-clk: allow to attach a clock to a device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= Cc: "qemu-devel@nongnu.org Developers" , Edgar Iglesias , Peter Maydell , Mark Burton , Alistair Francis On Mon, Jun 13, 2016 at 9:27 AM, wrote: > From: KONRAD Frederic > > This allows to attach a clock to a DeviceState. > Contrary to gpios, the clock pins are not contained in the DeviceState but > with the child property so they can appears in the qom-tree. > > Signed-off-by: KONRAD Frederic > --- > include/qemu/qemu-clock.h | 24 +++++++++++++++++++++++- > qemu-clock.c | 22 ++++++++++++++++++++++ > 2 files changed, 45 insertions(+), 1 deletion(-) > > diff --git a/include/qemu/qemu-clock.h b/include/qemu/qemu-clock.h > index e7acd68..a2ba105 100644 > --- a/include/qemu/qemu-clock.h > +++ b/include/qemu/qemu-clock.h > @@ -33,8 +33,30 @@ > typedef struct qemu_clk { > /*< private >*/ > Object parent_obj; > + char *name; /* name of this clock in the device. */ > } *qemu_clk; > > -#endif /* QEMU_CLOCK_H */ > +/** > + * qemu_clk_attach_to_device: > + * @d: the device on which the clock need to be attached. > + * @clk: the clock which need to be attached. > + * @name: the name of the clock can't be NULL. > + * > + * Attach @clk named @name to the device @d. > + * > + */ > +void qemu_clk_attach_to_device(DeviceState *d, qemu_clk clk, dev instead of just d > + const char *name); > > +/** > + * qemu_clk_get_pin: > + * @d: the device which contain the clock. > + * @name: the name of the clock. > + * > + * Get the clock named @name located in the device @d, or NULL if not found. > + * > + * Returns the clock named @name contained in @d. > + */ > +qemu_clk qemu_clk_get_pin(DeviceState *d, const char *name); > > +#endif /* QEMU_CLOCK_H */ > diff --git a/qemu-clock.c b/qemu-clock.c > index 4a47fb4..81f2852 100644 > --- a/qemu-clock.c > +++ b/qemu-clock.c > @@ -23,6 +23,7 @@ > > #include "qemu/qemu-clock.h" > #include "hw/hw.h" > +#include "qapi/error.h" > > /* #define DEBUG_QEMU_CLOCK */ > > @@ -33,6 +34,27 @@ do { printf("qemu-clock: " fmt , ## __VA_ARGS__); } while (0) > #define DPRINTF(fmt, ...) do { } while (0) > #endif > > +void qemu_clk_attach_to_device(DeviceState *d, qemu_clk clk, const char *name) > +{ > + assert(name); > + assert(!clk->name); > + object_property_add_child(OBJECT(d), name, OBJECT(clk), &error_abort); > + clk->name = g_strdup(name); > +} > + > +qemu_clk qemu_clk_get_pin(DeviceState *d, const char *name) > +{ > + gchar *path = NULL; > + Object *clk; > + bool ambiguous; > + > + path = g_strdup_printf("%s/%s", object_get_canonical_path(OBJECT(d)), > + name); > + clk = object_resolve_path(path, &ambiguous); Should ambiguous be passed back to the caller? > + g_free(path); > + return QEMU_CLOCK(clk); Shouldn't you check to see if you got something valid before casting? Thanks, Alistair > +} > + > static const TypeInfo qemu_clk_info = { > .name = TYPE_CLOCK, > .parent = TYPE_OBJECT, > -- > 2.5.5 > >