From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 645AEC4332F for ; Wed, 20 Oct 2021 01:45:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44AB0610D0 for ; Wed, 20 Oct 2021 01:45:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229770AbhJTBrc (ORCPT ); Tue, 19 Oct 2021 21:47:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbhJTBrb (ORCPT ); Tue, 19 Oct 2021 21:47:31 -0400 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76F19C06161C; Tue, 19 Oct 2021 18:45:17 -0700 (PDT) Received: by mail-il1-x12e.google.com with SMTP id a8so20376784ilj.10; Tue, 19 Oct 2021 18:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Lo/jOB9MRYPahQSJIGBGd5rI6irS5O6KXgLYFuOtSiA=; b=L9dglaaFTdi3X1M29JVYhAW3d45Ys+9bqoF7pCQ5K3NTWwBPhLZ7COQnEFHQENUo98 xW85tOsgvCnasrSDlEX3dTobYD0VO53yYQHD0neekojcPCjdEeheNzK56abnnaQyTJ2m RQDrga4/kSdRQPoGCBuUuGb25X/WGX6rzTkm13/kQif5SU65AhddI13OITVcGqtFbzAj MHPH0RXDFCEzhqUY5mOORfrUbs8KeKrJdA7TgeAB5em9yJgiddiUn/+NvHv3GXSS9tfW tk1zDNHLIGNhSnzBlYaFZmmIdeyaZGfqSsMKQwAN4XRbDWYIbV7nvLhLfPksYG7zodAh z5lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lo/jOB9MRYPahQSJIGBGd5rI6irS5O6KXgLYFuOtSiA=; b=m26qGMsHq3RQp29UrH9wItnqDz5RYFbGyMm3OrY0PAVSQyzYHaRVRju706spZBQMUd WusewdABhyf6DWryn+0BgPYw5nhICS4DKtEhi6Ayl3cgbC0YeXmgmr+zDXiGFgVSrads dszi5Z0k0uDbIFA8zBUAmNXetNu7Jk0lJ9sUQK/QUyNi9B5wvkoPt3y+lhn+FpyWt00r Ehf99Q9dFthGO4WTCSM7mYTfV5UNAdKo2/ljs/BimaZNi6Pwj18P7sbgSOiXHS889FI5 MMBOJMpK1i5KcUyGR3o40jR6E+QaAB4QxlHsuOM1stEhM4x2xiQSZ4732GzOty2ysLVL iGaw== X-Gm-Message-State: AOAM533NQflLbR2gNq0fX/rScdg0ZANJSo1+t5+10GzUYmvy+n7kMrkD Gc3KOSoDdO2ZG4DLoMP5ieaNViNm5Vh77Izk2/jeukwgVCkcew== X-Google-Smtp-Source: ABdhPJwDrbnVyNBujwte7Z6f158pSxX3bIvESnjqXy/axaw0IMI5l0ezwjDH7TTLF9QihmXpF365Jzmlnimw7/ZoHH4= X-Received: by 2002:a05:6e02:214a:: with SMTP id d10mr21663993ilv.290.1634694316599; Tue, 19 Oct 2021 18:45:16 -0700 (PDT) MIME-Version: 1.0 References: <20211009114313.17967-1-alistair@alistair23.me> In-Reply-To: From: Alistair Francis Date: Wed, 20 Oct 2021 11:44:50 +1000 Message-ID: Subject: Re: [PATCH v11 1/4] HID: wacom_sys: Add support for flipping the data values To: Dmitry Torokhov Cc: Ping Cheng , Alistair Francis , Shawn Guo , Sascha Hauer , dl-linux-imx , Jiri Kosina , Benjamin Tissoires , linux-input , devicetree , LKML , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 20, 2021 at 11:05 AM Dmitry Torokhov wrote: > > On Wed, Oct 20, 2021 at 09:33:13AM +1000, Alistair Francis wrote: > > On Tue, Oct 19, 2021 at 11:51 AM Dmitry Torokhov > > wrote: > > > > > > We already have touchscreen-inverted-x/y defined in > > > Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml, > > > why are they not sufficient? > > > > The touchscreen-* properties aren't applied to HID devices though, at > > least not that I can tell. > > No, they are not currently, but that does not mean we need to establish > a new set of properties (property names) for HID case. I can update the names to use the existing touchscreen ones. Do you have a hint of where this should be implemented though? Right now (without "HID: wacom: Add support for the AG14 Wacom device") the wacom touchscreen is just registered as a generic HID device. I don't see any good place in hid-core, hid-input or hid-generic to invert the input values for this. Even with my "HID: wacom: Add support for the AG14 Wacom device" patch I don't see a good way of doing this without the raw data parsing. Alistair > > Thanks. > > -- > Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 774B7C433F5 for ; Wed, 20 Oct 2021 01:46:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3404C610E5 for ; Wed, 20 Oct 2021 01:46:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3404C610E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tTtNXxiGlhbCUI+RBoHZmvuOp2xz8h0L7iSNEbYgcT8=; b=vQFAeZZNi0yXV3 KA5Ba2bDxbeRzYICBiqKkTwj1bgj0wHDPv6P4OS0r05A4PqjxmlxN+r8yw48xbe0jaC17p5M1MyWn m0kYaKy5PzVrYD7j8XiyKDpWp7tQlz9Bmmrh06McfyiG8JoW4FG1IUblVcKHENuOfZLyIqtKFhn2O VqVUUy8JA98oG6PVxtfVdBdbi01hutWy2FX2WqbW/fBnW+3l376k2p6MmT3locmPYh8doJnAMQCQF 1WAl0V/4xAktpB+9EwAIqzQ+2plQ4stMbcrsUcBcKP0EcHvsNx5P1mEYFvv8DtqQx8ZEnSpgh0Xrb RbN10CEUuWwimJMoIYXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1md0fR-0038aZ-LO; Wed, 20 Oct 2021 01:45:21 +0000 Received: from mail-il1-x134.google.com ([2607:f8b0:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1md0fN-0038ZY-Jl for linux-arm-kernel@lists.infradead.org; Wed, 20 Oct 2021 01:45:18 +0000 Received: by mail-il1-x134.google.com with SMTP id w10so20377724ilc.13 for ; Tue, 19 Oct 2021 18:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Lo/jOB9MRYPahQSJIGBGd5rI6irS5O6KXgLYFuOtSiA=; b=L9dglaaFTdi3X1M29JVYhAW3d45Ys+9bqoF7pCQ5K3NTWwBPhLZ7COQnEFHQENUo98 xW85tOsgvCnasrSDlEX3dTobYD0VO53yYQHD0neekojcPCjdEeheNzK56abnnaQyTJ2m RQDrga4/kSdRQPoGCBuUuGb25X/WGX6rzTkm13/kQif5SU65AhddI13OITVcGqtFbzAj MHPH0RXDFCEzhqUY5mOORfrUbs8KeKrJdA7TgeAB5em9yJgiddiUn/+NvHv3GXSS9tfW tk1zDNHLIGNhSnzBlYaFZmmIdeyaZGfqSsMKQwAN4XRbDWYIbV7nvLhLfPksYG7zodAh z5lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lo/jOB9MRYPahQSJIGBGd5rI6irS5O6KXgLYFuOtSiA=; b=RJx7YEkt/rXWwk/x0txiTpoUhyQdMS/sZjvOulodWaHzMUWZKYMpl5+ur/r20M6FvL QtvhK2ewf9HfcmlXw8TjZjzZjAoyJfOknEKK80MVJBk3kb/iJwSViopj1SvtKeRygB5h fxzte8kAmGvTHg8F2E+1hSIP5PnA4Ob8vC5EN0HtNjGCAMdEXNjp2Ee4u9MQg0/rX5sv ViGFPsDM8YFOZ+T/z108CQ24j0fgrJyGwp1bVpohUDtNDyH2SU0YmzPOAPSZ2EX1VXhn r/QHVFZzJkcJ+i81a8ldTTx9g7xtckKyzlAC4XYmUrc/ohb4FscCjyPkDcabnjeKy6RQ HZSA== X-Gm-Message-State: AOAM533JYyE2jYkQ+TYIjmNvOpZ2GuUmMiHCe6hHX4nuWgVdBODsyez2 wDDgk2bZOW8WddTsDnaaaTTp30JBcdmMhDFkRos= X-Google-Smtp-Source: ABdhPJwDrbnVyNBujwte7Z6f158pSxX3bIvESnjqXy/axaw0IMI5l0ezwjDH7TTLF9QihmXpF365Jzmlnimw7/ZoHH4= X-Received: by 2002:a05:6e02:214a:: with SMTP id d10mr21663993ilv.290.1634694316599; Tue, 19 Oct 2021 18:45:16 -0700 (PDT) MIME-Version: 1.0 References: <20211009114313.17967-1-alistair@alistair23.me> In-Reply-To: From: Alistair Francis Date: Wed, 20 Oct 2021 11:44:50 +1000 Message-ID: Subject: Re: [PATCH v11 1/4] HID: wacom_sys: Add support for flipping the data values To: Dmitry Torokhov Cc: Ping Cheng , Alistair Francis , Shawn Guo , Sascha Hauer , dl-linux-imx , Jiri Kosina , Benjamin Tissoires , linux-input , devicetree , LKML , linux-arm-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_184517_692110_D9A9E632 X-CRM114-Status: GOOD ( 18.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 20, 2021 at 11:05 AM Dmitry Torokhov wrote: > > On Wed, Oct 20, 2021 at 09:33:13AM +1000, Alistair Francis wrote: > > On Tue, Oct 19, 2021 at 11:51 AM Dmitry Torokhov > > wrote: > > > > > > We already have touchscreen-inverted-x/y defined in > > > Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml, > > > why are they not sufficient? > > > > The touchscreen-* properties aren't applied to HID devices though, at > > least not that I can tell. > > No, they are not currently, but that does not mean we need to establish > a new set of properties (property names) for HID case. I can update the names to use the existing touchscreen ones. Do you have a hint of where this should be implemented though? Right now (without "HID: wacom: Add support for the AG14 Wacom device") the wacom touchscreen is just registered as a generic HID device. I don't see any good place in hid-core, hid-input or hid-generic to invert the input values for this. Even with my "HID: wacom: Add support for the AG14 Wacom device" patch I don't see a good way of doing this without the raw data parsing. Alistair > > Thanks. > > -- > Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel