From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB56DC433E0 for ; Tue, 26 May 2020 16:56:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B565120776 for ; Tue, 26 May 2020 16:56:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Av0d9lQx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B565120776 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdcsp-0002lC-SQ for qemu-devel@archiver.kernel.org; Tue, 26 May 2020 12:56:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdcrj-0000Ru-C1; Tue, 26 May 2020 12:55:47 -0400 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]:47034) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdcri-00037h-5Q; Tue, 26 May 2020 12:55:46 -0400 Received: by mail-io1-xd44.google.com with SMTP id j8so22736109iog.13; Tue, 26 May 2020 09:55:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=c99aHn7ARxhEy/7aKLvR6O5sUhHQpgUNKQAiS/hog2c=; b=Av0d9lQx0qngdzjXS2n9oefHKZtg0qpGrQqaMnR1MrwWwpCtbiCRzZu5Db25kxJBf5 mjaZMCQ9UB7SVkdeUJqcGz3tybciybBRxyHmyRuQcLSVMhXyN9Y1E79RnhsZfNuSchU4 8i1/kDUImULY35vC/aRBppSaeUGQm2GxDmNFQDV5O2XGiKK1nAbvB/Jck4dYkOl5LkN+ 5W23cHQ6NXegmQyAB20b1hdS2Fwu/4xy48CWaEdzh9gDxRZaOwhricqV8t+m0jhsq8Rx 5xoAzIMAgvEpZ3VmNtWxOk6JlBahAHWerMpGct5SYBuoFCLEB5Rg0Y8D1mdQZM+jS13d SlXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=c99aHn7ARxhEy/7aKLvR6O5sUhHQpgUNKQAiS/hog2c=; b=pCw0NIb7Jp3AiSq5npvQB+C8R8SAQ0WjMN8QrhBN/uMt1FrG500j292ghw2KT2dfqg uSZPUYFNJsckhCAQMnfUGAovJGJx1f5y0psWdSnpKC9RQMXZRFF9LWGeDnPAD0fjdkPP NcX9cPfBJxpmgxsArNNB7zIe26P1CS5Qg72GoI368NcaPvZFvjEigYqrb2olS82ILa6j rXbO0Hgn3vUnvzshrstVSskJsBeHxwVxS6BcKmYrQoFgm5u7eahBrCdMoebSQ23rjP+i yXBTUYtmRY/I7xgUxFH2fQiZivazibdbGjiI3mOhJOVgdEaJ+Fw8iHryz2HxZy2CFNgQ Sc4g== X-Gm-Message-State: AOAM533+pCUDPyQJc8ETRnenvc/cNppwPiuTDma5ce3zhCfBPpkkdmKm ka3aTUmAn5Q1jg4NrXsqueI3e+GKwaBzNvPESU8= X-Google-Smtp-Source: ABdhPJzlOX7j2Ndcgv1Ixnu6HU/S1ZPFxu1rjY9Ks5mI3u69zUqVMYSHscD1znUzOxGoZbkB6DU1Qa1KfrkN7WWOZa0= X-Received: by 2002:a05:6638:dd3:: with SMTP id m19mr1959002jaj.106.1590512143958; Tue, 26 May 2020 09:55:43 -0700 (PDT) MIME-Version: 1.0 References: <20200526062252.19852-1-f4bug@amsat.org> <20200526062252.19852-7-f4bug@amsat.org> In-Reply-To: <20200526062252.19852-7-f4bug@amsat.org> From: Alistair Francis Date: Tue, 26 May 2020 09:46:43 -0700 Message-ID: Subject: Re: [PATCH 06/14] hw/display/cirrus_vga: Convert debug printf() to trace event To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::d44; envelope-from=alistair23@gmail.com; helo=mail-io1-xd44.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , QEMU Trivial , Alistair Francis , Mark Cave-Ayland , "qemu-devel@nongnu.org Developers" , Igor Mitsyanko , qemu-arm , Gerd Hoffmann , "Edgar E. Iglesias" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, May 25, 2020 at 11:25 PM Philippe Mathieu-Daud=C3=A9 wrote: > > Convert the final bit of DEBUG_BITBLT to a tracepoint. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > hw/display/cirrus_vga.c | 24 ++++++++++-------------- > hw/display/trace-events | 1 + > 2 files changed, 11 insertions(+), 14 deletions(-) > > diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c > index 76e2dc5bb6..92c197cdde 100644 > --- a/hw/display/cirrus_vga.c > +++ b/hw/display/cirrus_vga.c > @@ -53,7 +53,6 @@ > */ > > //#define DEBUG_CIRRUS > -//#define DEBUG_BITBLT > > /*************************************** > * > @@ -950,19 +949,16 @@ static void cirrus_bitblt_start(CirrusVGAState * s) > s->cirrus_blt_dstaddr &=3D s->cirrus_addr_mask; > s->cirrus_blt_srcaddr &=3D s->cirrus_addr_mask; > > -#ifdef DEBUG_BITBLT > - printf("rop=3D0x%02x mode=3D0x%02x modeext=3D0x%02x w=3D%d h=3D%d dp= itch=3D%d spitch=3D%d daddr=3D0x%08x saddr=3D0x%08x writemask=3D0x%02x\n", > - blt_rop, > - s->cirrus_blt_mode, > - s->cirrus_blt_modeext, > - s->cirrus_blt_width, > - s->cirrus_blt_height, > - s->cirrus_blt_dstpitch, > - s->cirrus_blt_srcpitch, > - s->cirrus_blt_dstaddr, > - s->cirrus_blt_srcaddr, > - s->vga.gr[0x2f]); > -#endif > + trace_vga_cirrus_bitblt_start(blt_rop, > + s->cirrus_blt_mode, > + s->cirrus_blt_modeext, > + s->cirrus_blt_width, > + s->cirrus_blt_height, > + s->cirrus_blt_dstpitch, > + s->cirrus_blt_srcpitch, > + s->cirrus_blt_dstaddr, > + s->cirrus_blt_srcaddr, > + s->vga.gr[0x2f]); > > switch (s->cirrus_blt_mode & CIRRUS_BLTMODE_PIXELWIDTHMASK) { > case CIRRUS_BLTMODE_PIXELWIDTH8: > diff --git a/hw/display/trace-events b/hw/display/trace-events > index c3043e4ced..bb089a5f5e 100644 > --- a/hw/display/trace-events > +++ b/hw/display/trace-events > @@ -134,6 +134,7 @@ vga_cirrus_read_io(uint32_t addr, uint32_t val) "addr= 0x%x, val 0x%x" > vga_cirrus_write_io(uint32_t addr, uint32_t val) "addr 0x%x, val 0x%x" > vga_cirrus_write_blt(uint32_t offset, uint32_t val) "offset 0x%x, val 0x= %x" > vga_cirrus_write_gr(uint8_t index, uint8_t val) "GR addr 0x%02x, val 0x%= 02x" > +vga_cirrus_bitblt_start(uint8_t blt_rop, uint8_t blt_mode, uint8_t blt_m= odeext, int blt_width, int blt_height, int blt_dstpitch, int blt_srcpitch, = uint32_t blt_dstaddr, uint32_t blt_srcaddr, uint8_t gr_val) "rop=3D0x%02x m= ode=3D0x%02x modeext=3D0x%02x w=3D%d h=3D%d dpitch=3D%d spitch=3D%d daddr= =3D0x%08"PRIx32" saddr=3D0x%08"PRIx32" writemask=3D0x%02x" > > # sii9022.c > sii9022_read_reg(uint8_t addr, uint8_t val) "addr 0x%02x, val 0x%02x" > -- > 2.21.3 > >