From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C269C33CA9 for ; Sun, 12 Jan 2020 09:45:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50145222D9 for ; Sun, 12 Jan 2020 09:45:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W2uztqtC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732478AbgALJoD (ORCPT ); Sun, 12 Jan 2020 04:44:03 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:40269 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732457AbgALJoD (ORCPT ); Sun, 12 Jan 2020 04:44:03 -0500 Received: by mail-lf1-f68.google.com with SMTP id i23so4693748lfo.7 for ; Sun, 12 Jan 2020 01:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=A5r5kQmyydbNcxW0sdL6UsroI3lvbIoMVRcAXoxkjxE=; b=W2uztqtCCOsZvughBCHSR7Y+yQr1mxzDn1SFDI/rWwPWFtLXZFMbLggsMh8BhdNUGK 3DKBY7SeDxtbN6j4hgyKCM5XORMj8s7TsXhBBN7Oe1YdVna7cpkmv1eUw7WtE1slV4rM YXDYcoU8dmMIfv6qoDuY1y77XNYwXYBIh5L2OhvmIz21gFsKI5l73QU7NRXlAMW1avSS cwECYjHgLZE7j6QRDqSOobx6NFJBLSTC6L2l4xU23ru4U4UVFnryMejhwtLsIw8KGd8T aP1rcE1AsHitYur54ayIPaxs6vpXkYRMYfwbXl3YuCMRpqqZlSN3dMyI2s09n+imtO8K ivcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=A5r5kQmyydbNcxW0sdL6UsroI3lvbIoMVRcAXoxkjxE=; b=S9bG+7bi7XltukyuLJn6NbEturJU3/F780kOs5h9eZwZztZXBlvimtnrY8HU/x++Y5 Jo9JAFWH5GQcuxQjQAIzqgdDP25FBza178NPSshT5ApFtz68eiCZxqHcJ6rI1+Xo35Ry 5eKIMD5+GrmVqDRm03hRorgTa3n1MLAXXjY0JuOKG8SWLG8a/xsQAeDAbUY8CdQ1w8z0 MQt1VOmi3SIzRYq+lJVqkMqG41YnCVyk4z7US3iE3OQj+7Zzh+ZjtlkH94QRYQCGwxPR S4UdUZrG8OJc0wc2eBj7DYp94HXFl8SoQlUd1l4vVXqSVdxLjApVBpWWQGD5b7548HMs BHZQ== X-Gm-Message-State: APjAAAWPYTmvPggYtuIoTb80XTmfIiXoR2TCHpIwSg7h8ByfqZw/7Zik rGCY8czmbIsFSxV0J/6YjDDxUtDocld09EF46W9LvH9O X-Google-Smtp-Source: APXvYqxudU83t852Cung1NJ91OYhHW64oFFGsNTbxqcJwhUfkWZZCHQPQzNyAs+FFdhZr50z28lxbu77NQ5sBJUz1O4= X-Received: by 2002:ac2:5f68:: with SMTP id c8mr4913919lfc.196.1578822241492; Sun, 12 Jan 2020 01:44:01 -0800 (PST) MIME-Version: 1.0 References: <20200109152133.23649-1-philmd@redhat.com> <20200109152133.23649-7-philmd@redhat.com> In-Reply-To: <20200109152133.23649-7-philmd@redhat.com> From: Alistair Francis Date: Sun, 12 Jan 2020 17:43:33 +0800 Message-ID: Subject: Re: [PATCH 06/15] migration/savevm: Replace current_machine by qdev_get_machine() To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: "qemu-devel@nongnu.org Developers" , Peter Maydell , Eduardo Habkost , "open list:Overall" , Juan Quintela , "open list:New World" , Marcelo Tosatti , "Dr. David Alan Gilbert" , qemu-arm , Alistair Francis , Paolo Bonzini , David Gibson , Richard Henderson Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Jan 9, 2020 at 11:30 PM Philippe Mathieu-Daud=C3=A9 wrote: > > As we want to remove the global current_machine, > replace MACHINE_GET_CLASS(current_machine) by > MACHINE_GET_CLASS(qdev_get_machine()). > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > migration/savevm.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/migration/savevm.c b/migration/savevm.c > index 59efc1981d..0e8b6a4715 100644 > --- a/migration/savevm.c > +++ b/migration/savevm.c > @@ -292,7 +292,8 @@ static uint32_t get_validatable_capabilities_count(vo= id) > static int configuration_pre_save(void *opaque) > { > SaveState *state =3D opaque; > - const char *current_name =3D MACHINE_GET_CLASS(current_machine)->nam= e; > + MachineClass *mc =3D MACHINE_GET_CLASS(qdev_get_machine()); > + const char *current_name =3D mc->name; > MigrationState *s =3D migrate_get_current(); > int i, j; > > @@ -362,7 +363,8 @@ static bool configuration_validate_capabilities(SaveS= tate *state) > static int configuration_post_load(void *opaque, int version_id) > { > SaveState *state =3D opaque; > - const char *current_name =3D MACHINE_GET_CLASS(current_machine)->nam= e; > + MachineClass *mc =3D MACHINE_GET_CLASS(qdev_get_machine()); > + const char *current_name =3D mc->name; > > if (strncmp(state->name, current_name, state->len) !=3D 0) { > error_report("Machine type received is '%.*s' and local is '%s'"= , > @@ -615,9 +617,7 @@ static void dump_vmstate_vmsd(FILE *out_file, > > static void dump_machine_type(FILE *out_file) > { > - MachineClass *mc; > - > - mc =3D MACHINE_GET_CLASS(current_machine); > + MachineClass *mc =3D MACHINE_GET_CLASS(qdev_get_machine()); > > fprintf(out_file, " \"vmschkmachine\": {\n"); > fprintf(out_file, " \"Name\": \"%s\"\n", mc->name); > -- > 2.21.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17FDBC32771 for ; Sun, 12 Jan 2020 09:45:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D41952187F for ; Sun, 12 Jan 2020 09:45:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W2uztqtC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D41952187F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqZns-0002Zw-Ur for qemu-devel@archiver.kernel.org; Sun, 12 Jan 2020 04:45:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54145) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqZmu-0001eL-8K for qemu-devel@nongnu.org; Sun, 12 Jan 2020 04:44:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iqZms-0000Pl-U8 for qemu-devel@nongnu.org; Sun, 12 Jan 2020 04:44:03 -0500 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]:39166) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iqZms-0000K0-MA; Sun, 12 Jan 2020 04:44:02 -0500 Received: by mail-lf1-x142.google.com with SMTP id y1so4706294lfb.6; Sun, 12 Jan 2020 01:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=A5r5kQmyydbNcxW0sdL6UsroI3lvbIoMVRcAXoxkjxE=; b=W2uztqtCCOsZvughBCHSR7Y+yQr1mxzDn1SFDI/rWwPWFtLXZFMbLggsMh8BhdNUGK 3DKBY7SeDxtbN6j4hgyKCM5XORMj8s7TsXhBBN7Oe1YdVna7cpkmv1eUw7WtE1slV4rM YXDYcoU8dmMIfv6qoDuY1y77XNYwXYBIh5L2OhvmIz21gFsKI5l73QU7NRXlAMW1avSS cwECYjHgLZE7j6QRDqSOobx6NFJBLSTC6L2l4xU23ru4U4UVFnryMejhwtLsIw8KGd8T aP1rcE1AsHitYur54ayIPaxs6vpXkYRMYfwbXl3YuCMRpqqZlSN3dMyI2s09n+imtO8K ivcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=A5r5kQmyydbNcxW0sdL6UsroI3lvbIoMVRcAXoxkjxE=; b=Rp87kQ8svPUnQywqnRbvnceuqJeYvnuiSuBhhv6STlxOf+cVhyWcZOEz6cN994clC6 CzbtWP/1Z5zi1TyDA/+eVA8ErKNKpLKjzJlP572JPFPfktDCMrqtFYBfyhXbXjCE/W4y bVgl48sOSuSjQDOQNKK0gOHKA0LpdaC+Vhnb9ruZy+EgS+obUjNWQKzNo/BGoKzZyWmE AyHUJ/0v3JD/aVZmgR1E5zEQOx+hzRc1+c46q3G7u3FSvtZjkXaOjIpnNZ9bUJJKPEkc r9HmCbYmDpo4gfdecsGNhYIpILckJW+dT/QPrkIwZaYZcDGcMt9mHmkR2GZVyT9YHoIj yMBg== X-Gm-Message-State: APjAAAVcidQ1mNRSIVVpyou9wbMb8678Te7121W5tI1LCV0kwLNq4G2g 8gGa69SZoda3gh9EBvUzzRcINUk8E9HyA+FyEko= X-Google-Smtp-Source: APXvYqxudU83t852Cung1NJ91OYhHW64oFFGsNTbxqcJwhUfkWZZCHQPQzNyAs+FFdhZr50z28lxbu77NQ5sBJUz1O4= X-Received: by 2002:ac2:5f68:: with SMTP id c8mr4913919lfc.196.1578822241492; Sun, 12 Jan 2020 01:44:01 -0800 (PST) MIME-Version: 1.0 References: <20200109152133.23649-1-philmd@redhat.com> <20200109152133.23649-7-philmd@redhat.com> In-Reply-To: <20200109152133.23649-7-philmd@redhat.com> From: Alistair Francis Date: Sun, 12 Jan 2020 17:43:33 +0800 Message-ID: Subject: Re: [PATCH 06/15] migration/savevm: Replace current_machine by qdev_get_machine() To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::142 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , "open list:Overall" , Juan Quintela , Marcelo Tosatti , "qemu-devel@nongnu.org Developers" , "Dr. David Alan Gilbert" , qemu-arm , "open list:New World" , Paolo Bonzini , Alistair Francis , Richard Henderson , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jan 9, 2020 at 11:30 PM Philippe Mathieu-Daud=C3=A9 wrote: > > As we want to remove the global current_machine, > replace MACHINE_GET_CLASS(current_machine) by > MACHINE_GET_CLASS(qdev_get_machine()). > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > migration/savevm.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/migration/savevm.c b/migration/savevm.c > index 59efc1981d..0e8b6a4715 100644 > --- a/migration/savevm.c > +++ b/migration/savevm.c > @@ -292,7 +292,8 @@ static uint32_t get_validatable_capabilities_count(vo= id) > static int configuration_pre_save(void *opaque) > { > SaveState *state =3D opaque; > - const char *current_name =3D MACHINE_GET_CLASS(current_machine)->nam= e; > + MachineClass *mc =3D MACHINE_GET_CLASS(qdev_get_machine()); > + const char *current_name =3D mc->name; > MigrationState *s =3D migrate_get_current(); > int i, j; > > @@ -362,7 +363,8 @@ static bool configuration_validate_capabilities(SaveS= tate *state) > static int configuration_post_load(void *opaque, int version_id) > { > SaveState *state =3D opaque; > - const char *current_name =3D MACHINE_GET_CLASS(current_machine)->nam= e; > + MachineClass *mc =3D MACHINE_GET_CLASS(qdev_get_machine()); > + const char *current_name =3D mc->name; > > if (strncmp(state->name, current_name, state->len) !=3D 0) { > error_report("Machine type received is '%.*s' and local is '%s'"= , > @@ -615,9 +617,7 @@ static void dump_vmstate_vmsd(FILE *out_file, > > static void dump_machine_type(FILE *out_file) > { > - MachineClass *mc; > - > - mc =3D MACHINE_GET_CLASS(current_machine); > + MachineClass *mc =3D MACHINE_GET_CLASS(qdev_get_machine()); > > fprintf(out_file, " \"vmschkmachine\": {\n"); > fprintf(out_file, " \"Name\": \"%s\"\n", mc->name); > -- > 2.21.1 > >