From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CADCCA9EAF for ; Mon, 21 Oct 2019 20:57:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D5B02084B for ; Mon, 21 Oct 2019 20:57:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DGHXapOf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D5B02084B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMek7-00032g-C3 for qemu-devel@archiver.kernel.org; Mon, 21 Oct 2019 16:57:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42215) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMejQ-0002Q5-Jk for qemu-devel@nongnu.org; Mon, 21 Oct 2019 16:56:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMejP-0004vB-Kr for qemu-devel@nongnu.org; Mon, 21 Oct 2019 16:56:48 -0400 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]:42782) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMejP-0004sZ-D0; Mon, 21 Oct 2019 16:56:47 -0400 Received: by mail-lf1-x144.google.com with SMTP id z12so11234738lfj.9; Mon, 21 Oct 2019 13:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3Tk342f2DcStfjZLw2ZHCFQBn5YgGbRBBcgwXLtH6i8=; b=DGHXapOfedWnXux0qmsHTjTBFeaHjRaU3O3dHuhcArSbFG9/UMoPbtV8fJIZ4vXduw Dyx8ecx36HMCkZSDYVxCpS8Y2T54fxRa+B968h1DiWd8ZNdieuq+lTioc8GBBshadQ1I y5brwFbqXwh7ZaXYTwBWX6W2mhlCiW22HHBcCQhkXzOPQAhw4LKKi1ASQ86bN6LxRaFd 5QP4r1ps0rbaY0FF/QMQV2nDDCRIjLUAZyMML7KyQGprSNWmEisYHxuCO5wW/vDQKY57 x4tWgvoSmz1T6JZP+mTnGpo18xE4/ISxRwtwyw4TMyrRbih97+PX+6DMbSbPHFWDrCgu vjWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3Tk342f2DcStfjZLw2ZHCFQBn5YgGbRBBcgwXLtH6i8=; b=haCsEmzYGEHEQyXzAugkFd7IpwyOlNFFTMlOk1Bh8UvyKeeCcKNlTxT/0miXBtSYQU 1mmWooHEQLPCtCXTKlfn8jIsJ46H4XF1mvHS1/dbK5OsY0V4TpO8+pbFvB46XtzIg14u UIzVI7fVBX/4U27MvMNKZhO7lTAwvFPnu6HTp7fcnlkIqXB0y5qpenFYIM8EpWyuYqVo mM/W7w/r6E5HE2IYZ0fDd9rbwitcFDV6v14Ks8W5y81+BBpbAWdWqFDNpo2/QOGA4WW5 rjSJwXrj0JxDZMgmcqBG0uX3pTJnV3RCVZajPIE0ngmdSIxWjpmx8bhCEXC2se3qvxr3 qvGQ== X-Gm-Message-State: APjAAAUxjvRz1kI1z7AnZgsRJzKvhQ8aC85GW6krDWpUzNC0nXzX0dnK n0i+rnaBoVnaz3Uos/Z0Xh39HE4mjmA0QfB7ge4= X-Google-Smtp-Source: APXvYqyib+1X+c3k+PTUfFsg0S4lQwy6/hSg+Qv416F9OA/Mh4sxeJs+K/f8xzmEsfmGPHHMo2jDfk7uPG7kyRajSWA= X-Received: by 2002:a19:f018:: with SMTP id p24mr5613247lfc.93.1571691406146; Mon, 21 Oct 2019 13:56:46 -0700 (PDT) MIME-Version: 1.0 References: <20191020225650.3671-1-philmd@redhat.com> <20191020225650.3671-7-philmd@redhat.com> In-Reply-To: <20191020225650.3671-7-philmd@redhat.com> From: Alistair Francis Date: Mon, 21 Oct 2019 13:51:27 -0700 Message-ID: Subject: Re: [PATCH 06/21] hw/arm/digic4: Inline digic4_board_setup_ram() function To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::144 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Burton , Jan Kiszka , Peter Maydell , Mark Cave-Ayland , "qemu-devel@nongnu.org Developers" , KONRAD Frederic , "Edgar E. Iglesias" , Rob Herring , Andrey Smirnov , Helge Deller , "Michael S. Tsirkin" , Markus Armbruster , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Antony Pavlov , Aleksandar Rikalo , David Gibson , Artyom Tarasenko , Joel Stanley , Eduardo Habkost , Alistair Francis , Leif Lindholm , Beniamino Galvani , qemu-arm , Peter Chubb , Fabien Chouteau , Paolo Bonzini , Richard Henderson , Radoslaw Biernacki , Thomas Huth , Andrew Baumann , Jean-Christophe Dubois , Andrew Jeffery , Michael Walle , "open list:New World" , Aleksandar Markovic , Igor Mammedov , Aurelien Jarno , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sun, Oct 20, 2019 at 4:07 PM Philippe Mathieu-Daud=C3=A9 wrote: > > Having the RAM creation code in a separate function is not > very helpful. Move this code directly inside the board_init() > function, this will later allow the board to have the QOM > ownership of the RAM. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > hw/arm/digic_boards.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c > index 304e4d1a29..ef3fc2b6a5 100644 > --- a/hw/arm/digic_boards.c > +++ b/hw/arm/digic_boards.c > @@ -53,12 +53,6 @@ typedef struct DigicBoard { > const char *rom1_def_filename; > } DigicBoard; > > -static void digic4_board_setup_ram(DigicBoardState *s, hwaddr ram_size) > -{ > - memory_region_allocate_system_memory(&s->ram, NULL, "ram", ram_size)= ; > - memory_region_add_subregion(get_system_memory(), 0, &s->ram); > -} > - > static void digic4_board_init(DigicBoard *board) > { > Error *err =3D NULL; > @@ -72,7 +66,8 @@ static void digic4_board_init(DigicBoard *board) > exit(1); > } > > - digic4_board_setup_ram(s, board->ram_size); > + memory_region_allocate_system_memory(&s->ram, NULL, "ram", board->ra= m_size); > + memory_region_add_subregion(get_system_memory(), 0, &s->ram); > > if (board->add_rom0) { > board->add_rom0(s, DIGIC4_ROM0_BASE, board->rom0_def_filename); > -- > 2.21.0 > >