From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21FC2C433DF for ; Tue, 26 May 2020 17:35:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC3432053B for ; Tue, 26 May 2020 17:35:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Mz5eKXZ1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC3432053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jddTi-0005fW-Uf for qemu-devel@archiver.kernel.org; Tue, 26 May 2020 13:35:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jddSa-00044s-A3; Tue, 26 May 2020 13:33:52 -0400 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]:46424) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jddSY-0002mg-Tg; Tue, 26 May 2020 13:33:52 -0400 Received: by mail-qk1-x744.google.com with SMTP id c12so2559395qkk.13; Tue, 26 May 2020 10:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=0Dr7A8+ioW84EKnz0a2eSHIkSFmUZeUruSLYmyCx8cE=; b=Mz5eKXZ1c3zs0Uroi1BqXJvHw4z0A/esYHlw17mM+rLGE10B3SqEZU394FoUDi21Wr s1H1ensFarsc9p5dFcGIUzmSW2xbjeiLOOYIOwzTUhxK8QIUo7TF744cW963nX2095nE MhzChYqnpI1ibwin3WoE+2kUH9WWnpAkQ0jPfWNbMjE5qSY//ApiXth8Mpj1ksZNU/Mf 6JhBcMzAbRmqfcK4RoqZlQ+YwsC7Riv6DSGaHZTLSzYUCObveQvqqP0QAIkTgMr4YM+S fJzBCmI/sPgvu0OyK3b8Rq6YmgvIif5tmaK4Wj3ZPpUCyP0Kc096ZhWFZCs6+3hhKwo/ F4xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0Dr7A8+ioW84EKnz0a2eSHIkSFmUZeUruSLYmyCx8cE=; b=M1eI4tZQGZlwxD1SaFnTADCwziujsBOImBvtFB/o+FJcvP1SR26LbXZaN/39K0q/EV ZkjS2+QWretlxhR160Ue3Nyg6CiHVWhTw6TjlHQ/CglcymmsLLQg+BAlAIR5RPBfYVvi C2K0TplY32tTLlnGEwgyUKx9hvezv+9WU82OdFMOrKVsed3R/Z28BCrQVkuprC60+yix wuMll5qNWNJ6Hqg6Su610oihrH6CxNpxIWUmgzgNQpXWOKqcl98c6RYpVKR+ROntEEkr ux4PYGWcUgnJMeZ0qcZH7lBt560VyBmsIqXf6EoPvn5JXJuSK8IJraw5pJvcYVf2pund MOyw== X-Gm-Message-State: AOAM531KKoqvyGVkXgw+GZLvxaTOs3E0xECtp1tkVN/GrZcsMad1MV2C LflK/d5t9bGvcBebhOZB3W6aCk13MPDGm1oNm/s= X-Google-Smtp-Source: ABdhPJyzrZEIzFEgdfUEzSz70ZeijYW2LeFpqhO1hMREYhxK6qz2+po/PgcAeXAHwrG9FGaegza+Qj+akYywa6f/e3c= X-Received: by 2002:a37:484c:: with SMTP id v73mr2483097qka.496.1590514427871; Tue, 26 May 2020 10:33:47 -0700 (PDT) MIME-Version: 1.0 References: <20200526062252.19852-1-f4bug@amsat.org> <20200526062252.19852-10-f4bug@amsat.org> In-Reply-To: <20200526062252.19852-10-f4bug@amsat.org> From: Alistair Francis Date: Tue, 26 May 2020 10:24:49 -0700 Message-ID: Subject: Re: [PATCH 09/14] hw/display/xlnx_dp: Replace disabled DPRINTF() by error_report() To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::744; envelope-from=alistair23@gmail.com; helo=mail-qk1-x744.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , QEMU Trivial , Alistair Francis , Mark Cave-Ayland , "qemu-devel@nongnu.org Developers" , Igor Mitsyanko , qemu-arm , Gerd Hoffmann , "Edgar E. Iglesias" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, May 25, 2020 at 11:29 PM Philippe Mathieu-Daud=C3=A9 wrote: > > DPRINTF() calls are disabled by default, so when unexpected > data is used, the whole process abort without information. > > Display a bit of information with error_report() before crashing. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > hw/display/xlnx_dp.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c > index 3e5fb44e06..8d940cd8d1 100644 > --- a/hw/display/xlnx_dp.c > +++ b/hw/display/xlnx_dp.c > @@ -1,5 +1,5 @@ > /* > - * xlnx_dp.c > + * Xilinx Display Port > * > * Copyright (C) 2015 : GreenSocs Ltd > * http://www.greensocs.com/ , email: info@greensocs.com > @@ -24,6 +24,7 @@ > > #include "qemu/osdep.h" > #include "qapi/error.h" > +#include "qemu/error-report.h" > #include "qemu/log.h" > #include "qemu/module.h" > #include "hw/display/xlnx_dp.h" > @@ -465,7 +466,7 @@ static uint8_t xlnx_dp_aux_pop_tx_fifo(XlnxDPState *s= ) > uint8_t ret; > > if (fifo8_is_empty(&s->tx_fifo)) { > - DPRINTF("tx_fifo underflow..\n"); > + error_report("%s: TX_FIFO underflow", __func__); > abort(); > } > ret =3D fifo8_pop(&s->tx_fifo); > @@ -525,6 +526,7 @@ static void xlnx_dp_aux_set_command(XlnxDPState *s, u= int32_t value) > qemu_log_mask(LOG_UNIMP, "xlnx_dp: Write i2c status not implemen= ted\n"); > break; > default: > + error_report("%s: invalid command: %u", __func__, cmd); > abort(); > } > > @@ -631,8 +633,8 @@ static void xlnx_dp_change_graphic_fmt(XlnxDPState *s= ) > s->g_plane.format =3D PIXMAN_b8g8r8; > break; > default: > - DPRINTF("error: unsupported graphic format %u.\n", > - s->avbufm_registers[AV_BUF_FORMAT] & DP_GRAPHIC_MASK); > + error_report("%s: unsupported graphic format %u", __func__, > + s->avbufm_registers[AV_BUF_FORMAT] & DP_GRAPHIC_MAS= K); > abort(); > } > > @@ -647,8 +649,8 @@ static void xlnx_dp_change_graphic_fmt(XlnxDPState *s= ) > s->v_plane.format =3D PIXMAN_x8b8g8r8; > break; > default: > - DPRINTF("error: unsupported video format %u.\n", > - s->avbufm_registers[AV_BUF_FORMAT] & DP_NL_VID_FMT_MASK)= ; > + error_report("%s: unsupported video format %u", __func__, > + s->avbufm_registers[AV_BUF_FORMAT] & DP_NL_VID_FMT_= MASK); > abort(); > } > > -- > 2.21.3 > >