From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B8ACC2D0CE for ; Tue, 21 Jan 2020 22:20:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5901217F4 for ; Tue, 21 Jan 2020 22:20:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CmJ24gh8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5901217F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iu1t7-0003in-15 for qemu-devel@archiver.kernel.org; Tue, 21 Jan 2020 17:20:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51815) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iu1sU-0003DL-6s for qemu-devel@nongnu.org; Tue, 21 Jan 2020 17:20:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iu1sT-0005xe-6V for qemu-devel@nongnu.org; Tue, 21 Jan 2020 17:20:06 -0500 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]:42543) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iu1sS-0005xS-Tx; Tue, 21 Jan 2020 17:20:05 -0500 Received: by mail-lj1-x242.google.com with SMTP id y4so4518950ljj.9; Tue, 21 Jan 2020 14:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=JHFzAIFwxyGpvLCTen745Sva46nruWDZw5EOHo0p+hY=; b=CmJ24gh8g2WudUN3wVoYj7KA+9mwELvtIEimtw5v6bZb8Y55Sp2QnkOBBB8B83TaPe x4tU7fjKZSkeEDeTxKKFDleyNn3l24oMMSsdvc1HEhSlRuS52BVgjoX9v0DoKRjPTMDe MYUsOCW68uJQ9C6Dq3eDLxnLzo/nmWLCYNPnj3XK5GbnZrezTNZVxGnz3VRNhC5JipGe eVCeZ4HAaOeQdJ4XOKDzrNyEpyProns0r+w3H5tHStce6k5fCEzY319WTjUME23aNjEH CNM+HLoIWuHKY8qcto9exjAreomqdqU+MWdzfih2QGpGihXEJz5CmKTF629f17lwvCWV gRgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JHFzAIFwxyGpvLCTen745Sva46nruWDZw5EOHo0p+hY=; b=dtC/nYSegA0Lo+0ydCnGaq+lzh13aNF/Bq85zNzteOnJL6j+4R5XbirczyeGOpOx1I XCA3xMQ7N7ffWXIAr1GS+bxFlq5na0YMWT0dDJuJ05PkbktfoAjoKqt19qnSqLH1GL+t Pmggs7d/NEDE4keZf6UKHJ8DwGQeOq9Uh5GvanSGxJkgFzZVn2QgqhUSl1MAqJLtkKNP Cbq1dxGXMcIS2BaSVayOS4/5E9UAZ1XmuJCYYGucsbgFeHUoZMYj9CZj0mwjQvlxUQU+ FlZjzrgnzdzrbWNqiH1FqoQGaLocs7SZB0qu5NaDoO+OC3UAEgQGUE/9AYTnTjNQD8aR 1gPA== X-Gm-Message-State: APjAAAUwhb4ZG4awNoF/wYUJPWh6xZHfTnQixWJDJCW5PHVtP8wmex+9 ZFgxoii21H3i2NNvD+BNRY7IM4WBsMlJXeT7Rtc= X-Google-Smtp-Source: APXvYqwRTDMqPRIJquhpc/YmHMy/zmFu49PD0J5K46noQWRlWp3GS8Of/c9N221ybUksyzl/RRjCHGiwoGJYhAyfmH0= X-Received: by 2002:a2e:8755:: with SMTP id q21mr17659585ljj.156.1579645203388; Tue, 21 Jan 2020 14:20:03 -0800 (PST) MIME-Version: 1.0 References: <20200121213853.9601-1-f4bug@amsat.org> In-Reply-To: <20200121213853.9601-1-f4bug@amsat.org> From: Alistair Francis Date: Wed, 22 Jan 2020 08:19:35 +1000 Message-ID: Subject: Re: [PATCH] hw/misc/stm32f4xx_syscfg: Fix copy/paste error To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::242 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Peter Maydell , Alistair Francis , "qemu-devel@nongnu.org Developers" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jan 22, 2020 at 7:39 AM Philippe Mathieu-Daud=C3=A9 wrote: > > Missed in 870c034da0b, hopefully reported by Coverity. > > Fixes: Coverity CID 1412793 (Incorrect expression) > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > hw/misc/stm32f4xx_syscfg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/stm32f4xx_syscfg.c b/hw/misc/stm32f4xx_syscfg.c > index dbcdca59f8..f960e4ea1e 100644 > --- a/hw/misc/stm32f4xx_syscfg.c > +++ b/hw/misc/stm32f4xx_syscfg.c > @@ -47,7 +47,7 @@ static void stm32f4xx_syscfg_set_irq(void *opaque, int = irq, int level) > STM32F4xxSyscfgState *s =3D opaque; > int icrreg =3D irq / 4; > int startbit =3D (irq & 3) * 4; > - uint8_t config =3D config =3D irq / 16; > + uint8_t config =3D irq / 16; > > trace_stm32f4xx_syscfg_set_irq(irq / 16, irq % 16, level); > > -- > 2.21.1 > >