All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 1/4] board/qemu/riscv32-virt: Update linux config
Date: Wed, 20 Mar 2019 15:50:14 -0700	[thread overview]
Message-ID: <CAKmqyKNyuMCs68wbV=M+2-Rn9pUQ9RZ0JaJNx=w93GgZJerZ3w@mail.gmail.com> (raw)
In-Reply-To: <3f551905-3796-fadb-7501-52fadbf575e7@mind.be>

On Wed, Mar 20, 2019 at 12:20 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>
>  Hi Alistair,
>
> On 20/03/2019 01:38, Alistair Francis wrote:
> > Update the Linux defconfig. This defconfig is the in tree defconfig with
> > 32-bit support enabled.
>
>  I would prefer two patches: a first patch that just converts the current
> linux.config into a config fragment, without changing anything, and then a
> second patch that adds features.
>
>  To do the first patch, just do
>
> make linux-configure
> cp output/build/linux*/.config /tmp/riscv32.config
> (select BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG)
> make linux-reconfigure
> utils/diffconfig -m output/build/linux*/.config /tmp/riscv32.config > \
>         board/qemu/riscv32-virt/linux.config.fragment
> (set BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES)
> make linux-reconfigure
> diff -u output/build/linux*/.config /tmp/riscv32.config
>
>  For the second patch, you either use the same procedure as above, or you just
> manually add the relevant symbols from the fragment.

Ok, I have updated this in the v6.

>
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > ---
> >  board/qemu/riscv32-virt/linux.config | 35 +++++++++++-----------------
> >  configs/qemu_riscv32_virt_defconfig  |  4 ++--
> >  2 files changed, 15 insertions(+), 24 deletions(-)
> >
> > diff --git a/board/qemu/riscv32-virt/linux.config b/board/qemu/riscv32-virt/linux.config
> > index c25583f768..fa8a9fd650 100644
> > --- a/board/qemu/riscv32-virt/linux.config
> > +++ b/board/qemu/riscv32-virt/linux.config
> > @@ -1,23 +1,14 @@
> > +CONFIG_32BIT=y
> > +CONFIG_PAGE_OFFSET=0xC0000000
>
>  This makes no sense... These are blind symbols, so their values will be ignored.
>
>  Or am I missing something?

I have removed this one, it is generated by the kernel's menuconfig
but they don't seem to be required.

>
> [snip]
> > diff --git a/configs/qemu_riscv32_virt_defconfig b/configs/qemu_riscv32_virt_defconfig
> > index 6f9a61b11c..15b4c5624c 100644
> > --- a/configs/qemu_riscv32_virt_defconfig
> > +++ b/configs/qemu_riscv32_virt_defconfig
> > @@ -18,8 +18,8 @@ BR2_LINUX_KERNEL=y
> >  BR2_LINUX_KERNEL_CUSTOM_GIT=y
> >  BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/riscv/riscv-linux.git"
> >  BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="8fe28cb58bcb235034b64cbbb7550a8a43fd88be"
> > -BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
> > -BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/riscv32-virt/linux.config"
> > +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
> > +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/qemu/riscv32-virt/linux.config"
>
>  Since it's a fragment, better call it linux.config.fragment or linux.fragment
> (we have both currently, but a bit more of linux.config.fragment).

Fxied!

Alistair

>
>  Regards,
>  Arnout
>

      reply	other threads:[~2019-03-20 22:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20  0:38 [Buildroot] [PATCH v5 1/4] board/qemu/riscv32-virt: Update linux config Alistair Francis
2019-03-20  0:38 ` [Buildroot] [PATCH v5 3/4] configs: qemu_riscv*_virt: Use OpenSBI by default Alistair Francis
2019-03-20  0:38 ` [Buildroot] [PATCH v5 2/4] boot/opensbi: new package Alistair Francis
2019-03-20 21:12   ` Thomas Petazzoni
2019-03-20 21:28     ` Alistair Francis
2019-03-20 21:44       ` Thomas Petazzoni
2019-03-21 16:36     ` Mark Corbin
2019-03-21 16:57       ` Thomas Petazzoni
2019-03-23  6:44         ` Alistair Francis
2019-03-20  0:38 ` [Buildroot] [PATCH v5 4/4] boot/riscv-pk: Deprecate riscv-pk and BBL Alistair Francis
2019-03-20 19:20 ` [Buildroot] [PATCH v5 1/4] board/qemu/riscv32-virt: Update linux config Arnout Vandecappelle
2019-03-20 22:50   ` Alistair Francis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKmqyKNyuMCs68wbV=M+2-Rn9pUQ9RZ0JaJNx=w93GgZJerZ3w@mail.gmail.com' \
    --to=alistair23@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.