All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Alistair Francis <alistair@alistair23.me>,
	linux-input@vger.kernel.org, dl-linux-imx <linux-imx@nxp.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] input/touchscreen: Add device tree support to wacom_i2c
Date: Wed, 20 Jan 2021 22:51:24 -0800	[thread overview]
Message-ID: <CAKmqyKOFe0_JgFA1_9vemW40g-daBt5RY=S9CAXU5Yj-FftGGw@mail.gmail.com> (raw)
In-Reply-To: <YAeSpUIzV/3dWPC+@google.com>

On Tue, Jan 19, 2021 at 6:17 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> On Sat, Jan 16, 2021 at 08:24:27PM -0800, Alistair Francis wrote:
> > Allow the wacom-i2c device to be exposed via device tree.
>
> The patch seems incomplete. I see we are reading and storing properties,
> but we are not using them whatsoever, so I do not see the reason to have
> this in this form.

Good point. I am trying to split up the work, but I guess here I split
it up a little too much. I'm sending a v2 that should fix this.

Alistair

>
> Thanks.
>
> --
> Dmitry

  reply	other threads:[~2021-01-21  6:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-17  4:24 [PATCH 1/3] devicetree/bindings: Initial commit of wacom,wacom-i2c Alistair Francis
2021-01-17  4:24 ` [PATCH 2/3] input/touchscreen: Add device tree support to wacom_i2c Alistair Francis
2021-01-20  2:17   ` Dmitry Torokhov
2021-01-21  6:51     ` Alistair Francis [this message]
2021-01-17  4:24 ` [PATCH 3/3] arch/arm: reMarkable2: Enable wacom_i2c Alistair Francis
2021-01-20  2:15 ` [PATCH 1/3] devicetree/bindings: Initial commit of wacom,wacom-i2c Dmitry Torokhov
2021-01-20  6:15   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKmqyKOFe0_JgFA1_9vemW40g-daBt5RY=S9CAXU5Yj-FftGGw@mail.gmail.com' \
    --to=alistair23@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.