From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48CC4C432BE for ; Sun, 15 Aug 2021 11:56:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C048610E7 for ; Sun, 15 Aug 2021 11:56:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237845AbhHOL4z (ORCPT ); Sun, 15 Aug 2021 07:56:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbhHOL4x (ORCPT ); Sun, 15 Aug 2021 07:56:53 -0400 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B41DC061764; Sun, 15 Aug 2021 04:56:24 -0700 (PDT) Received: by mail-io1-xd30.google.com with SMTP id j18so4086655ioj.8; Sun, 15 Aug 2021 04:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WKPXHo4mcX7xDNr3Qfy2ytPy2yrYvE6/voU48e47FhY=; b=jHihczY6+kYqTKLMrPpO/5Y/F8bNFOHWT2HlLznT4p4U37/A6Un98FXRrwqQ/EEqrf VAgtqPzdqC6/LcRGYAwb9tzZ8YhNZnoCTJTmwLPf6wsj0QUrs/KJfd5kFRC4ZJ4fS5Qs fZ8SYSLVN/dzqjnF4WFJ0rLegMM1dB/LTd/R1Fy+QFr6HVLraOtgTRqYfM7N3pudUkno pzczuDBP9gVjupvNd2LxfLeNdDyC0QgqqupsVXC2frmpMMwnBTcktLBewuw/G6H4JAg3 a6JYQ9/w/cKqGlca9sh+2fzisuGh8TubPyjred9/5wkl/XxzQZpOJf9McRRAJD/jol9u 3eQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WKPXHo4mcX7xDNr3Qfy2ytPy2yrYvE6/voU48e47FhY=; b=IJEkllJ0/7T3ljR7nr3s+R3kGGuB/a2lygUVKS9iGTEty+CT6dasuT+DwGYfEFnab8 XgiJNSyqcGpRLNSTZRv7BxsUWf9kHSor4yi+NO9rzbdZ1A8kHwfAHrVoIYibNoRdGYnP gpkyWRHS+nNSklbl7y2XuzQMj+Oa2zOKMde1zSNjhkK+hGDiajAGPN3o4B9lCaNn1tJg ziSeJAljYwj27WRd3E5nihsQ5dmb+4CIS8OrzcBvmoVVjyPMwzJnUvfbdbDtr/Qc2soc lFrGOJjkboE8ajqMXyXsscACxEh8d+ZAfYtUtroStgyiEf0gL96ww3BJfSaznxnRkFtS y5CQ== X-Gm-Message-State: AOAM530N8G1Eef6BAU4COarJj4N4Gf1Lko56gDajS6/gUiQb3HOQQ6uT H9fY80g13hrX5G05ki8T0OPxTkYwQ12zatTx2R8= X-Google-Smtp-Source: ABdhPJxtLiCDisGQyFqO/tNALjrJn75wU23SFH9Eo0P29bXH4NS8pqUVXagXQ4QFE/wO1YzfasxFEZW/7VlfnHvegeE= X-Received: by 2002:a05:6638:3048:: with SMTP id u8mr10610500jak.91.1629028583494; Sun, 15 Aug 2021 04:56:23 -0700 (PDT) MIME-Version: 1.0 References: <20210807103940.152-1-alistair@alistair23.me> <20210807103940.152-3-alistair@alistair23.me> In-Reply-To: From: Alistair Francis Date: Sun, 15 Aug 2021 21:55:57 +1000 Message-ID: Subject: Re: [PATCH v10 02/11] mfd: simple-mfd-i2c: Add a Kconfig name To: Lee Jones Cc: Alistair Francis , Rob Herring , lgirdwood@gmail.com, Mark Brown , dl-linux-imx , Sascha Hauer , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 10, 2021 at 5:53 PM Lee Jones wrote: > > On Sat, 07 Aug 2021, Alistair Francis wrote: > > You need a better commit message. > > What are you doing? > Why are you doing it? > What happens if you don't do it? > > > Signed-off-by: Alistair Francis > > --- > > drivers/mfd/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > I guess there's no harm in it. > > That does mean you'll need a bespoke defconfig to run your build, > which is not advisable for generic maintenance and testing purposes. > What architecture does your H/W operate on? My hardware uses the ARMv7 i.MX architecture. I'm testing it with the `imx_v6_v7_defconfig` config. Alistair > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > index 6a3fd2d75f96..09a939f8b7ff 100644 > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -1176,7 +1176,7 @@ config MFD_SI476X_CORE > > module will be called si476x-core. > > > > config MFD_SIMPLE_MFD_I2C > > - tristate > > + tristate "Simple MFD device" > > That's not right. You're saying: > > "Simple Multi-Functional Device device" > > It should be something more like: > > "Simple Multi-Functional Device support (I2C)" > > > depends on I2C > > select REGMAP_I2C > > help > > -- > Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF] > Senior Technical Lead - Developer Services > Linaro.org =E2=94=82 Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog