Re: [Qemu-devel] [PATCH v1 18/29] target-microblaze: dec_msr: Reuse more code when reg-decoding

From: Alistair Francis <alistair23@gmail.com>
To: Edgar Iglesias <edgar.iglesias@gmail.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Edgar Iglesias <edgar.iglesias@xilinx.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>,
	Francisco Iglesias <frasse.iglesias@gmail.com>,
	Alistair Francis <alistair@alistair23.me>,
	Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v1 18/29] target-microblaze: dec_msr: Reuse more code when reg-decoding
Date: Thu, 03 May 2018 21:45:16 +0000	[thread overview]
Message-ID: <CAKmqyKOT_ZPYZSic9QdyyyujaW=8i=cjg+x+thn3VjXtoJyVNg@mail.gmail.com> (raw)
In-Reply-To: <20180503091922.28733-19-edgar.iglesias@gmail.com>

On Thu, May 3, 2018 at 2:40 AM Edgar E. Iglesias <edgar.iglesias@gmail.com>
wrote:

> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

> Reuse more code when decoding register numbers.

> No functional changes.

> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>   target/microblaze/translate.c | 38 +++++++++-----------------------------
>   1 file changed, 9 insertions(+), 29 deletions(-)

> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index d2788451fe..05449fb941 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -531,11 +531,9 @@ static void dec_msr(DisasContext *dc)
>               case 1:
>                   msr_write(dc, cpu_R[dc->ra]);
>                   break;
> -            case 0x3:
> -                tcg_gen_mov_i32(cpu_SR[SR_EAR], cpu_R[dc->ra]);
> -                break;
> -            case 0x5:
> -                tcg_gen_mov_i32(cpu_SR[SR_ESR], cpu_R[dc->ra]);
> +            case SR_EAR:
> +            case SR_ESR:
> +                tcg_gen_mov_i32(cpu_SR[sr], cpu_R[dc->ra]);
>                   break;
>               case 0x7:
>                   tcg_gen_andi_i32(cpu_SR[SR_FSR], cpu_R[dc->ra], 31);
> @@ -562,17 +560,11 @@ static void dec_msr(DisasContext *dc)
>               case 1:
>                   msr_read(dc, cpu_R[dc->rd]);
>                   break;
> -            case 0x3:
> -                tcg_gen_mov_i32(cpu_R[dc->rd], cpu_SR[SR_EAR]);
> -                break;
> -            case 0x5:
> -                tcg_gen_mov_i32(cpu_R[dc->rd], cpu_SR[SR_ESR]);
> -                break;
> -             case 0x7:
> -                tcg_gen_mov_i32(cpu_R[dc->rd], cpu_SR[SR_FSR]);
> -                break;
> -            case 0xb:
> -                tcg_gen_mov_i32(cpu_R[dc->rd], cpu_SR[SR_BTR]);
> +            case SR_EAR:
> +            case SR_ESR:
> +            case SR_FSR:
> +            case SR_BTR:
> +                tcg_gen_mov_i32(cpu_R[dc->rd], cpu_SR[sr]);
>                   break;
>               case 0x800:
>                   tcg_gen_ld_i32(cpu_R[dc->rd],
> @@ -582,19 +574,7 @@ static void dec_msr(DisasContext *dc)
>                   tcg_gen_ld_i32(cpu_R[dc->rd],
>                                  cpu_env, offsetof(CPUMBState, shr));
>                   break;
> -            case 0x2000:
> -            case 0x2001:
> -            case 0x2002:
> -            case 0x2003:
> -            case 0x2004:
> -            case 0x2005:
> -            case 0x2006:
> -            case 0x2007:
> -            case 0x2008:
> -            case 0x2009:
> -            case 0x200a:
> -            case 0x200b:
> -            case 0x200c:
> +            case 0x2000 ... 0x200c:
>                   rn = sr & 0xf;
>                   tcg_gen_ld_i32(cpu_R[dc->rd],
>                                 cpu_env, offsetof(CPUMBState,
pvr.regs[rn]));
> --
> 2.14.1