From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49158C2D0A3 for ; Mon, 16 Nov 2020 16:46:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9810D222B9 for ; Mon, 16 Nov 2020 16:46:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="soqM/Sei" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9810D222B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kehdg-0005bX-H4 for qemu-devel@archiver.kernel.org; Mon, 16 Nov 2020 11:46:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kehQA-0008Ic-7k; Mon, 16 Nov 2020 11:32:05 -0500 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]:38996) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kehQ7-00078e-R6; Mon, 16 Nov 2020 11:32:01 -0500 Received: by mail-io1-xd44.google.com with SMTP id j23so2145161iog.6; Mon, 16 Nov 2020 08:31:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K0XipTWujXiNWwh8ZYB969l148TX9roKPYYgxCYiaik=; b=soqM/SeiBjs1po98yFsEc6eZjJaHud0shZWqp4lVZCNybDmDUQ+StFMJbEEth1PopS GSFNQiymVlRx+LFcszxLgJ1KbXin5Em1w0IMRi1781t87YCDwoOxtX/UEW5Byv2LNEu9 LyUn0EdCkpXwLVp5nYBEwxgMOnhdJaN/cTre+cV8VGMDSatW1fgI+Aaor1qzTkzK8z/g k0cjTDOMldIiavVoUUiLh4fvhGZoP8acowCEDqBx16hmJI3mX8RSDRmXHLaG7++ZoTbV yLnr1ok+BOb8To0v0taPWdW49eqd0V9G9+Shs2EA+1N4m/G1QxwyKKw2LGXV8Et1pSJ4 HUHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K0XipTWujXiNWwh8ZYB969l148TX9roKPYYgxCYiaik=; b=JQYIl/FWgAVWRNHHMtoIuKeM9lKxSLNVR05iD62Vq//9NrLr+45NhjqLv7UznRqi+C xNWjvUONtzGxj0DtW8ckZ1+eu96zG8Pr15xmDT5KeByf8RyLuO5BFnUEy95jWZ5hkJ5u UhN/47paRxFLnlj5RD20K2otXdSXd6/LQbIpmETB2oZ2kyM3c5lYvrvXvM0yx02lUfZa TY4w64PUZeJnPvTcG1Aru7RFlfKZb4/SaImXr4RmSAG2IxXqhGtJzofQbc+oTqA6fdsg u5lb8gFkdzUncenKR6Lwi07fDIbZgc7Nq+3gqFpC5DwcAfUHFmfBVfMBZqsfwJ/PGDbp CJgg== X-Gm-Message-State: AOAM530ZL+XFCEEB9/9CPjYBuO3j1UFVyn72xg8XR47L5mN/XYU4GxNO 4sMmcDYlfprXsYL/R/lW5xvXlB5IkVvsAy48N08= X-Google-Smtp-Source: ABdhPJw4Tt0gontzi6TchllUZw0PVS/DJrgBVTdeVT0Zid42pI+f0O7X9ZUSeTM6i0rBj9vi2Jjx36ZuIWWxWf2CMiM= X-Received: by 2002:a02:ce26:: with SMTP id v6mr230044jar.91.1605544316239; Mon, 16 Nov 2020 08:31:56 -0800 (PST) MIME-Version: 1.0 References: <20201115184903.1292715-1-ganqixin@huawei.com> <20201115184903.1292715-13-ganqixin@huawei.com> In-Reply-To: <20201115184903.1292715-13-ganqixin@huawei.com> From: Alistair Francis Date: Mon, 16 Nov 2020 08:19:41 -0800 Message-ID: Subject: Re: [PATCH 12/13] SPI flash devices: put them into the 'storage' category To: Gan Qixin Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::d44; envelope-from=alistair23@gmail.com; helo=mail-io1-xd44.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Zhanghailiang , QEMU Trivial , Alistair Francis , "qemu-devel@nongnu.org Developers" , kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Nov 16, 2020 at 1:30 AM Gan Qixin wrote: > > SPI flash devices have no category, put them into the 'storage' category. > > Signed-off-by: Gan Qixin Reviewed-by: Alistair Francis Alistair > --- > Cc: Alistair Francis > --- > hw/block/m25p80.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index 483925f57a..8dd3ef8559 100644 > --- a/hw/block/m25p80.c > +++ b/hw/block/m25p80.c > @@ -1397,6 +1397,7 @@ static void m25p80_class_init(ObjectClass *klass, void *data) > device_class_set_props(dc, m25p80_properties); > dc->reset = m25p80_reset; > mc->pi = data; > + set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); > } > > static const TypeInfo m25p80_info = { > -- > 2.23.0 > >