From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15820C433EF for ; Tue, 24 May 2022 11:57:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236681AbiEXL5i (ORCPT ); Tue, 24 May 2022 07:57:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230099AbiEXL5f (ORCPT ); Tue, 24 May 2022 07:57:35 -0400 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6025A62BD8; Tue, 24 May 2022 04:57:34 -0700 (PDT) Received: by mail-io1-xd2d.google.com with SMTP id b4so3394953iog.11; Tue, 24 May 2022 04:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EIAXXXRwo1YYdT9BrP9x6eL1UouOtf5nysexYYh5ocs=; b=RZi92208R6ZRLaqgjJ35GcMxLld23k/r9kHNFWbPbdA6ButLl2XPyd9axlRNARHviQ SXBtr2LoqecHLoFxKSOzat2OmCJuPwf245P8WAx8fhG13Y2b6kkIBFu11X/QWQVvHblb bgkQ4C5Sl3rb9K/2X1wsR7+yuxnztqQFxJZYrZbzKCR6XDMGj21cuEmYA6/GJ5nWWRPP rp7Xgr+GSuPbGkB81uJqSkXVJa4xgBl8G3Lp2zHdNya6S0MYS3+0fP7wrfVqAxoK76Zt Oi64nxv+CcS/JlJt9PsSdqgiuk2xkbJQHqU8agqzacivXOS4nofqzU0mTkqDnvDZ9hGd pT7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EIAXXXRwo1YYdT9BrP9x6eL1UouOtf5nysexYYh5ocs=; b=uwrerqdnvJjzuN80DeWJNPBsOjoTwEbYNHXsuxOdal3pWakSduNGbIKpung41OjYTP G07rJi29DBSC2KShCBuhsUWrqpbI/5rZrBZ6/vuYD6LFcW8QvQc2IYGXitFI8r6Qnc0G nVfYTbAee7L4v7nm6rOynKQptTYUK/hUbMyIMhdj8i8slMi/PIzj35qWa4Gcc0p+my83 wUt8zIHMCVk+t8qBoit9INgrkjGZ1cZgYfCuA4RaqWP7eZzeelwCn+8mn+iR6v8iuMhB v/FX4AkYhQ1e02I5d1ud1h+yl5y6EMVHQFpoavrUHVQExjJJxuuhhYHT/ZtwW2R2Z5Lz 5LnA== X-Gm-Message-State: AOAM533HscE5njfNiwvR0Y9iTjbOK/4oKeL/yfRs8aVqtwCzfWZSR+ov nVTtJyCBv7kaeK/5rhOupSBPiRZfhEdgWBjfzY0= X-Google-Smtp-Source: ABdhPJwgkWUFiDvAjFIEaXbe+SSxraGzllK9weXeN8GA2IY0gLlrSCYsidO8nXwFSbttdncy3ecz91vvYjUQD3KE63A= X-Received: by 2002:a05:6638:498e:b0:32e:be76:f908 with SMTP id cv14-20020a056638498e00b0032ebe76f908mr5837862jab.66.1653393453532; Tue, 24 May 2022 04:57:33 -0700 (PDT) MIME-Version: 1.0 References: <20220323120021.361137-1-alistair@alistair23.me> In-Reply-To: From: Alistair Francis Date: Tue, 24 May 2022 21:57:07 +1000 Message-ID: Subject: Re: [PATCH v7 0/4] Add support for the Cypress cyttsp5 To: Alistair Francis Cc: linux-input , devicetree , linux-arm-kernel , Linux Kernel Mailing List , Henrik Rydberg , Linus Walleij , Rob Herring , Dmitry Torokhov , Andreas Kemnade Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2022 at 10:25 PM Alistair Francis wrote: > > On Wed, Mar 23, 2022 at 10:00 PM Alistair Francis > wrote: > > > > This patch series builds on top of [1] and adds support for the cyttsp5 > > touchscreen controller for the reMarkable 2. > > > > I first tried to add an I2C HID device. Although the cyttsp5 has some HID > > looking aspects it is not HID compatible. Just in trying to probe the device > > I found: > > - The HID descriptor has extra padding > > - The HID descriptor sets the high bytes of the descriptor length > > - The HID descriptor has extra unrecognised tags > > - The HID reset command doesn't appear to work > > > > I don't think there is a way to use the I2C HID framework with the cyttsp5. > > For anyone interested you can see the work here [2]. In that branch though I > > can only obtain a HID descriptor, nothing else works without more core > > changes. > > > > So instead I rebased the series from [1]. Converted to the new yaml DTS > > documentation, added regulator support and fixed a x/y miscalculation bug. > > The DT bindings have been reviewed, any comments on the driver > implementation? It has been tested on a few different devices Any comments? It would be great to try and get this in 5.19 Alistair > > Alistair > > > > > 1: https://lwn.net/ml/linux-kernel/20180703094309.18514-1-mylene.josserand@bootlin.com/ > > 2: https://github.com/alistair23/linux/commits/rM2-mainline-cyttsp5-hid > > > > v7: > > - Fix device tree warnings > > v6: > > - Use reg for the button properties > > v5: > > - Address review comments from v4 > > > > Alistair Francis (4): > > Input: Add driver for Cypress Generation 5 touchscreen > > dt-bindings: input: Add Cypress TT2100 touchscreen controller > > ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen > > ARM: dts: imx7d-remarkable2: Enable the cyttsp5 > > > > .../input/touchscreen/cypress,tt21000.yaml | 101 ++ > > arch/arm/boot/dts/imx7d-remarkable2.dts | 100 ++ > > arch/arm/configs/imx_v6_v7_defconfig | 1 + > > drivers/input/touchscreen/Kconfig | 16 + > > drivers/input/touchscreen/Makefile | 1 + > > drivers/input/touchscreen/cyttsp5.c | 902 ++++++++++++++++++ > > 6 files changed, 1121 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml > > create mode 100644 drivers/input/touchscreen/cyttsp5.c > > > > -- > > 2.35.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2733CC433F5 for ; Tue, 24 May 2022 11:58:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=apObRJHH/uv2QNmnDM577xkvehQm63/8Zx/JSWeCVnQ=; b=kBn6O7xzfoMTZ0 rUxd968FXG6NNefMUP2EJzR7JJQJaFTdpNcAqA+y3fq4Jak5Lse5nn5hw8JTqPXHpDdJtKxuIsb5F 4QNXWNxTE3pH1g/6ZYkUdncholSwzutNxA0VswPjRMH64fudD5HRkcJ7DaS+zIaJZ9wRv2W88JGRL CMLByVm49SnOXXT0RlB0rEIirqaZracYQ5NPHlUZ7FsJOf2yiieiHq+UftLIpPDL9/I40zc2iiVpW RwCD6u7soDaEmyyLsDHFAw12+gaRdhKKeawAn+NccQS+eIKYhhPF7fxKIxuZi4pSrIi37meSuub9G QXU0IfgHSwLBAGRs8tTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntTAS-007sfp-LU; Tue, 24 May 2022 11:57:40 +0000 Received: from mail-io1-xd30.google.com ([2607:f8b0:4864:20::d30]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntTAO-007sel-ON for linux-arm-kernel@lists.infradead.org; Tue, 24 May 2022 11:57:38 +0000 Received: by mail-io1-xd30.google.com with SMTP id d198so13023787iof.12 for ; Tue, 24 May 2022 04:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EIAXXXRwo1YYdT9BrP9x6eL1UouOtf5nysexYYh5ocs=; b=RZi92208R6ZRLaqgjJ35GcMxLld23k/r9kHNFWbPbdA6ButLl2XPyd9axlRNARHviQ SXBtr2LoqecHLoFxKSOzat2OmCJuPwf245P8WAx8fhG13Y2b6kkIBFu11X/QWQVvHblb bgkQ4C5Sl3rb9K/2X1wsR7+yuxnztqQFxJZYrZbzKCR6XDMGj21cuEmYA6/GJ5nWWRPP rp7Xgr+GSuPbGkB81uJqSkXVJa4xgBl8G3Lp2zHdNya6S0MYS3+0fP7wrfVqAxoK76Zt Oi64nxv+CcS/JlJt9PsSdqgiuk2xkbJQHqU8agqzacivXOS4nofqzU0mTkqDnvDZ9hGd pT7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EIAXXXRwo1YYdT9BrP9x6eL1UouOtf5nysexYYh5ocs=; b=wInVqczoSU09ODId2/7dZbPhENLkRM0ySGzgZgeGjTsJrLLC3f2lUtiwso2c/FHr+f CideMpoyfmuuMaY5BtyL7kF0amiVkDHA1WNqHvSuDHysAKowA48DS1LPpemMGclM40hi ssHh4+0cKe09Mf8gL3FfgxdPAzJ4JEVeU4pnihCGtiw7VC+2wztq8GaQC+Qq489eBPSu kdat0qT4ggQTlEFPyBkXgyZ2A572//86AxdEe2XDWMNoO5lZxWIpLAddKHi76QSjguhI qQaLd5k/rwygcCccp0uRDUnCGLuSNZOn7a0x1urDEo0PsAs3YhEPPAuwqn0jnI17FIzV AUyg== X-Gm-Message-State: AOAM533N3ssX2fyHXZ4ytr6vP2WwhwOvLV6sPEO36PqUfZz23/E3kmAY u+m9d/LY8xxwxd4DmMo/fPrHN/T8S1AFEcPiuOI= X-Google-Smtp-Source: ABdhPJwgkWUFiDvAjFIEaXbe+SSxraGzllK9weXeN8GA2IY0gLlrSCYsidO8nXwFSbttdncy3ecz91vvYjUQD3KE63A= X-Received: by 2002:a05:6638:498e:b0:32e:be76:f908 with SMTP id cv14-20020a056638498e00b0032ebe76f908mr5837862jab.66.1653393453532; Tue, 24 May 2022 04:57:33 -0700 (PDT) MIME-Version: 1.0 References: <20220323120021.361137-1-alistair@alistair23.me> In-Reply-To: From: Alistair Francis Date: Tue, 24 May 2022 21:57:07 +1000 Message-ID: Subject: Re: [PATCH v7 0/4] Add support for the Cypress cyttsp5 To: Alistair Francis Cc: linux-input , devicetree , linux-arm-kernel , Linux Kernel Mailing List , Henrik Rydberg , Linus Walleij , Rob Herring , Dmitry Torokhov , Andreas Kemnade X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220524_045736_833448_65B0E872 X-CRM114-Status: GOOD ( 30.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 20, 2022 at 10:25 PM Alistair Francis wrote: > > On Wed, Mar 23, 2022 at 10:00 PM Alistair Francis > wrote: > > > > This patch series builds on top of [1] and adds support for the cyttsp5 > > touchscreen controller for the reMarkable 2. > > > > I first tried to add an I2C HID device. Although the cyttsp5 has some HID > > looking aspects it is not HID compatible. Just in trying to probe the device > > I found: > > - The HID descriptor has extra padding > > - The HID descriptor sets the high bytes of the descriptor length > > - The HID descriptor has extra unrecognised tags > > - The HID reset command doesn't appear to work > > > > I don't think there is a way to use the I2C HID framework with the cyttsp5. > > For anyone interested you can see the work here [2]. In that branch though I > > can only obtain a HID descriptor, nothing else works without more core > > changes. > > > > So instead I rebased the series from [1]. Converted to the new yaml DTS > > documentation, added regulator support and fixed a x/y miscalculation bug. > > The DT bindings have been reviewed, any comments on the driver > implementation? It has been tested on a few different devices Any comments? It would be great to try and get this in 5.19 Alistair > > Alistair > > > > > 1: https://lwn.net/ml/linux-kernel/20180703094309.18514-1-mylene.josserand@bootlin.com/ > > 2: https://github.com/alistair23/linux/commits/rM2-mainline-cyttsp5-hid > > > > v7: > > - Fix device tree warnings > > v6: > > - Use reg for the button properties > > v5: > > - Address review comments from v4 > > > > Alistair Francis (4): > > Input: Add driver for Cypress Generation 5 touchscreen > > dt-bindings: input: Add Cypress TT2100 touchscreen controller > > ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen > > ARM: dts: imx7d-remarkable2: Enable the cyttsp5 > > > > .../input/touchscreen/cypress,tt21000.yaml | 101 ++ > > arch/arm/boot/dts/imx7d-remarkable2.dts | 100 ++ > > arch/arm/configs/imx_v6_v7_defconfig | 1 + > > drivers/input/touchscreen/Kconfig | 16 + > > drivers/input/touchscreen/Makefile | 1 + > > drivers/input/touchscreen/cyttsp5.c | 902 ++++++++++++++++++ > > 6 files changed, 1121 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml > > create mode 100644 drivers/input/touchscreen/cyttsp5.c > > > > -- > > 2.35.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel