From: Alistair Francis <alistair23@gmail.com>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Andrew Jeffery <andrew@aj.id.au>,
Alistair Francis <alistair@alistair23.me>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>, Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH 5/6] aspeed/smc: Let the SSI core layer define the bus name
Date: Tue, 8 Mar 2022 16:41:56 +1000 [thread overview]
Message-ID: <CAKmqyKOxi+0VJUd+a2oJCoRoz1=3RE335BySrO8p5UsYM45ofg@mail.gmail.com> (raw)
In-Reply-To: <20220307071856.1410731-6-clg@kaod.org>
On Mon, Mar 7, 2022 at 5:34 PM Cédric Le Goater <clg@kaod.org> wrote:
>
> If no id is provided, qdev automatically assigns a unique ename with
> the following pattern "<type>.<index>".
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> hw/ssi/aspeed_smc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
> index f194182beacf..113f31899a6b 100644
> --- a/hw/ssi/aspeed_smc.c
> +++ b/hw/ssi/aspeed_smc.c
> @@ -1130,7 +1130,7 @@ static void aspeed_smc_realize(DeviceState *dev, Error **errp)
> /* DMA irq. Keep it first for the initialization in the SoC */
> sysbus_init_irq(sbd, &s->irq);
>
> - s->spi = ssi_create_bus(dev, "spi");
> + s->spi = ssi_create_bus(dev, NULL);
>
> /* Setup cs_lines for peripherals */
> s->cs_lines = g_new0(qemu_irq, asc->max_cs);
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2022-03-08 6:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 7:18 [PATCH 0/6] aspeed/smc: 'num_cs' cleanup Cédric Le Goater
2022-03-07 7:18 ` [PATCH 1/6] aspeed/smc: Use max number of CE instead of 'num_cs' Cédric Le Goater
2022-03-07 10:19 ` Philippe Mathieu-Daudé
2022-03-07 11:03 ` Alistair Francis
2022-03-07 7:18 ` [PATCH 2/6] aspeed: Rework aspeed_board_init_flashes() interface Cédric Le Goater
2022-03-07 10:21 ` Philippe Mathieu-Daudé
2022-03-07 20:51 ` Alistair Francis
2022-03-07 7:18 ` [PATCH 3/6] aspeed/smc: Remove 'num_cs' field Cédric Le Goater
2022-03-07 10:22 ` Philippe Mathieu-Daudé
2022-03-07 11:05 ` Alistair Francis
2022-03-07 7:18 ` [PATCH 4/6] aspeed/smc: Rename 'max_peripherals' to 'max_cs' Cédric Le Goater
2022-03-07 10:21 ` Philippe Mathieu-Daudé
2022-03-07 11:07 ` Alistair Francis
2022-03-07 7:18 ` [PATCH 5/6] aspeed/smc: Let the SSI core layer define the bus name Cédric Le Goater
2022-03-07 10:25 ` Philippe Mathieu-Daudé
2022-03-07 10:36 ` Cédric Le Goater
2022-03-08 6:41 ` Alistair Francis [this message]
2022-03-07 7:18 ` [PATCH 6/6] aspeed/smc: Fix error log Cédric Le Goater
2022-03-07 10:23 ` Philippe Mathieu-Daudé
2022-03-07 11:01 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKOxi+0VJUd+a2oJCoRoz1=3RE335BySrO8p5UsYM45ofg@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.