All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: Alistair Francis <alistair@alistair23.me>
Cc: linux-input <linux-input@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Henrik Rydberg <rydberg@bitmath.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Andreas Kemnade <andreas@kemnade.info>
Subject: Re: [PATCH v7 0/4] Add support for the Cypress cyttsp5
Date: Wed, 20 Apr 2022 22:25:06 +1000	[thread overview]
Message-ID: <CAKmqyKP5CRDx4acc6yg9SwADaGTNqKmDUrBs2ODXR30OZuunoA@mail.gmail.com> (raw)
In-Reply-To: <20220323120021.361137-1-alistair@alistair23.me>

On Wed, Mar 23, 2022 at 10:00 PM Alistair Francis
<alistair@alistair23.me> wrote:
>
> This patch series builds on top of [1] and adds support for the cyttsp5
> touchscreen controller for the reMarkable 2.
>
> I first tried to add an I2C HID device. Although the cyttsp5 has some HID
> looking aspects it is not HID compatible. Just in trying to probe the device
> I found:
>  - The HID descriptor has extra padding
>  - The HID descriptor sets the high bytes of the descriptor length
>  - The HID descriptor has extra unrecognised tags
>  - The HID reset command doesn't appear to work
>
> I don't think there is a way to use the I2C HID framework with the cyttsp5.
> For anyone interested you can see the work here [2]. In that branch though I
> can only obtain a HID descriptor, nothing else works without more core
> changes.
>
> So instead I rebased the series from [1]. Converted to the new yaml DTS
> documentation, added regulator support and fixed a x/y miscalculation bug.

The DT bindings have been reviewed, any comments on the driver
implementation? It has been tested on a few different devices

Alistair

>
> 1: https://lwn.net/ml/linux-kernel/20180703094309.18514-1-mylene.josserand@bootlin.com/
> 2: https://github.com/alistair23/linux/commits/rM2-mainline-cyttsp5-hid
>
> v7:
>  - Fix device tree warnings
> v6:
>  - Use reg for the button properties
> v5:
>  - Address review comments from v4
>
> Alistair Francis (4):
>   Input: Add driver for Cypress Generation 5 touchscreen
>   dt-bindings: input: Add Cypress TT2100 touchscreen controller
>   ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen
>   ARM: dts: imx7d-remarkable2: Enable the cyttsp5
>
>  .../input/touchscreen/cypress,tt21000.yaml    | 101 ++
>  arch/arm/boot/dts/imx7d-remarkable2.dts       | 100 ++
>  arch/arm/configs/imx_v6_v7_defconfig          |   1 +
>  drivers/input/touchscreen/Kconfig             |  16 +
>  drivers/input/touchscreen/Makefile            |   1 +
>  drivers/input/touchscreen/cyttsp5.c           | 902 ++++++++++++++++++
>  6 files changed, 1121 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
>  create mode 100644 drivers/input/touchscreen/cyttsp5.c
>
> --
> 2.35.1
>

WARNING: multiple messages have this Message-ID
From: Alistair Francis <alistair23@gmail.com>
To: Alistair Francis <alistair@alistair23.me>
Cc: linux-input <linux-input@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Henrik Rydberg <rydberg@bitmath.org>,
	 Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	 Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Andreas Kemnade <andreas@kemnade.info>
Subject: Re: [PATCH v7 0/4] Add support for the Cypress cyttsp5
Date: Wed, 20 Apr 2022 22:25:06 +1000	[thread overview]
Message-ID: <CAKmqyKP5CRDx4acc6yg9SwADaGTNqKmDUrBs2ODXR30OZuunoA@mail.gmail.com> (raw)
In-Reply-To: <20220323120021.361137-1-alistair@alistair23.me>

On Wed, Mar 23, 2022 at 10:00 PM Alistair Francis
<alistair@alistair23.me> wrote:
>
> This patch series builds on top of [1] and adds support for the cyttsp5
> touchscreen controller for the reMarkable 2.
>
> I first tried to add an I2C HID device. Although the cyttsp5 has some HID
> looking aspects it is not HID compatible. Just in trying to probe the device
> I found:
>  - The HID descriptor has extra padding
>  - The HID descriptor sets the high bytes of the descriptor length
>  - The HID descriptor has extra unrecognised tags
>  - The HID reset command doesn't appear to work
>
> I don't think there is a way to use the I2C HID framework with the cyttsp5.
> For anyone interested you can see the work here [2]. In that branch though I
> can only obtain a HID descriptor, nothing else works without more core
> changes.
>
> So instead I rebased the series from [1]. Converted to the new yaml DTS
> documentation, added regulator support and fixed a x/y miscalculation bug.

The DT bindings have been reviewed, any comments on the driver
implementation? It has been tested on a few different devices

Alistair

>
> 1: https://lwn.net/ml/linux-kernel/20180703094309.18514-1-mylene.josserand@bootlin.com/
> 2: https://github.com/alistair23/linux/commits/rM2-mainline-cyttsp5-hid
>
> v7:
>  - Fix device tree warnings
> v6:
>  - Use reg for the button properties
> v5:
>  - Address review comments from v4
>
> Alistair Francis (4):
>   Input: Add driver for Cypress Generation 5 touchscreen
>   dt-bindings: input: Add Cypress TT2100 touchscreen controller
>   ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen
>   ARM: dts: imx7d-remarkable2: Enable the cyttsp5
>
>  .../input/touchscreen/cypress,tt21000.yaml    | 101 ++
>  arch/arm/boot/dts/imx7d-remarkable2.dts       | 100 ++
>  arch/arm/configs/imx_v6_v7_defconfig          |   1 +
>  drivers/input/touchscreen/Kconfig             |  16 +
>  drivers/input/touchscreen/Makefile            |   1 +
>  drivers/input/touchscreen/cyttsp5.c           | 902 ++++++++++++++++++
>  6 files changed, 1121 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
>  create mode 100644 drivers/input/touchscreen/cyttsp5.c
>
> --
> 2.35.1
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-04-20 12:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23 12:00 [PATCH v7 0/4] Add support for the Cypress cyttsp5 Alistair Francis
2022-03-23 12:00 ` Alistair Francis
2022-03-23 12:00 ` [PATCH v7 1/4] Input: Add driver for Cypress Generation 5 touchscreen Alistair Francis
2022-03-23 12:00   ` Alistair Francis
2022-03-23 12:00 ` [PATCH v7 2/4] dt-bindings: input: Add Cypress TT2100 touchscreen controller Alistair Francis
2022-03-23 12:00   ` Alistair Francis
2022-03-29 23:12   ` Rob Herring
2022-03-29 23:12     ` Rob Herring
2022-03-23 12:00 ` [PATCH v7 3/4] ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen Alistair Francis
2022-03-23 12:00   ` Alistair Francis
2022-03-23 12:00 ` [PATCH v7 4/4] ARM: dts: imx7d-remarkable2: Enable the cyttsp5 Alistair Francis
2022-03-23 12:00   ` Alistair Francis
2022-04-20 12:25 ` Alistair Francis [this message]
2022-04-20 12:25   ` [PATCH v7 0/4] Add support for the Cypress cyttsp5 Alistair Francis
2022-05-24 11:57   ` Alistair Francis
2022-05-24 11:57     ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKmqyKP5CRDx4acc6yg9SwADaGTNqKmDUrBs2ODXR30OZuunoA@mail.gmail.com \
    --to=alistair23@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=andreas@kemnade.info \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rydberg@bitmath.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.