From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3740C433EF for ; Wed, 20 Apr 2022 12:25:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378481AbiDTM2X (ORCPT ); Wed, 20 Apr 2022 08:28:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353130AbiDTM2T (ORCPT ); Wed, 20 Apr 2022 08:28:19 -0400 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 642D61C91D; Wed, 20 Apr 2022 05:25:33 -0700 (PDT) Received: by mail-il1-x132.google.com with SMTP id h4so853249ilq.8; Wed, 20 Apr 2022 05:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hRURk4DN2eZqCTEqfyXp6e+58OlcNywvCaEhVw8AW1k=; b=NhfhqCCs3Hf2EcKb/RtIq/hjv48Ps2GXEYJ25dNCUTbtl1svXYZdaLXsrgj7QWWPdM 3oPVrUA81IyvWsn6DwAwMq/wFx4wtiCNIZ4QMETSQs8O1/Ye+puhovoY8VYUq1iH/jXX XrqVbKAbZpXr39qKer3R/EqS37otJinwycoykfbrxTXYCCQpBa/ljq9oFdjT6hziWSS7 9D1VG3znG9Hyl+SjpRiJLYwyJ/6/CFz0ltHThGbWLEEy6Bpf4OHCM43Hf1lncvlyeP2v t9bW6z6eQS1zHeK4eOBVQWQoY/2TdPvuLDlrwSEql08qeayxkYpHay7K4KcQoTyPt6vf HlZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hRURk4DN2eZqCTEqfyXp6e+58OlcNywvCaEhVw8AW1k=; b=fifMWz89yuIEqxuYDnpGPu4HwuFKgu3v7UnJ+ANgAwCEsrUUd0d922k/2/YYQfpFwU P48RZYdYZKbhQh7F5YgvQq7NSC8n1uqQh8WXXpnD/unK3s7RZ2dStE0EmpvuH6BvFCsX 8hz6xLmb5BjbWnvJcRZkbWwuvNFPhFIFovvpdOSGZYVehaWZ2MYkb/1/P7rzUqEmfzPX KZepdddMAA0A79aOi1AiFDjd+LZurzDzkLKmiesIJSHTQVV6FytknjehsxcaENiwz9VA VpAygZbCqeP48f6Nv46jMQs44wlYI/u0GkbCNcnVUe/ISs9el81aXqNu9f6xqPzyvvP9 P+5A== X-Gm-Message-State: AOAM533H9j9G9utLPNz7zLKtA3dxhHq/3q0DR+5ruvmuBwYKH7YXaR2A ZKgG2vFCPZw8YGdMQs80L7A59xLPdHwTYzg3INQ= X-Google-Smtp-Source: ABdhPJxR05XY11iOWutfHq8oz3L83XIEM/5S8NVV9L7I7mrKegnWO3BlDIq1sHEfoLPpDNiMs/wLF6X1KXkixVdCtjk= X-Received: by 2002:a92:6012:0:b0:2bd:fb5f:d627 with SMTP id u18-20020a926012000000b002bdfb5fd627mr8766792ilb.86.1650457532838; Wed, 20 Apr 2022 05:25:32 -0700 (PDT) MIME-Version: 1.0 References: <20220323120021.361137-1-alistair@alistair23.me> In-Reply-To: <20220323120021.361137-1-alistair@alistair23.me> From: Alistair Francis Date: Wed, 20 Apr 2022 22:25:06 +1000 Message-ID: Subject: Re: [PATCH v7 0/4] Add support for the Cypress cyttsp5 To: Alistair Francis Cc: linux-input , devicetree , linux-arm-kernel , Linux Kernel Mailing List , Henrik Rydberg , Linus Walleij , Rob Herring , Dmitry Torokhov , Andreas Kemnade Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 23, 2022 at 10:00 PM Alistair Francis wrote: > > This patch series builds on top of [1] and adds support for the cyttsp5 > touchscreen controller for the reMarkable 2. > > I first tried to add an I2C HID device. Although the cyttsp5 has some HID > looking aspects it is not HID compatible. Just in trying to probe the device > I found: > - The HID descriptor has extra padding > - The HID descriptor sets the high bytes of the descriptor length > - The HID descriptor has extra unrecognised tags > - The HID reset command doesn't appear to work > > I don't think there is a way to use the I2C HID framework with the cyttsp5. > For anyone interested you can see the work here [2]. In that branch though I > can only obtain a HID descriptor, nothing else works without more core > changes. > > So instead I rebased the series from [1]. Converted to the new yaml DTS > documentation, added regulator support and fixed a x/y miscalculation bug. The DT bindings have been reviewed, any comments on the driver implementation? It has been tested on a few different devices Alistair > > 1: https://lwn.net/ml/linux-kernel/20180703094309.18514-1-mylene.josserand@bootlin.com/ > 2: https://github.com/alistair23/linux/commits/rM2-mainline-cyttsp5-hid > > v7: > - Fix device tree warnings > v6: > - Use reg for the button properties > v5: > - Address review comments from v4 > > Alistair Francis (4): > Input: Add driver for Cypress Generation 5 touchscreen > dt-bindings: input: Add Cypress TT2100 touchscreen controller > ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen > ARM: dts: imx7d-remarkable2: Enable the cyttsp5 > > .../input/touchscreen/cypress,tt21000.yaml | 101 ++ > arch/arm/boot/dts/imx7d-remarkable2.dts | 100 ++ > arch/arm/configs/imx_v6_v7_defconfig | 1 + > drivers/input/touchscreen/Kconfig | 16 + > drivers/input/touchscreen/Makefile | 1 + > drivers/input/touchscreen/cyttsp5.c | 902 ++++++++++++++++++ > 6 files changed, 1121 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml > create mode 100644 drivers/input/touchscreen/cyttsp5.c > > -- > 2.35.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E571CC433EF for ; Wed, 20 Apr 2022 12:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8phnE7ZAPpfnqVuJaxbxJDBNXytW+cOA5KoIz1TdfNs=; b=qmB/NTsESpItIU 6tsWGzvddW3QdY+5YMY9zyM8rbuJt6ckzK5Pz3KxgkwtPQ0EECEI5U6gR0DBeB+2RqF0Yx5hvilLw On60TC1UkzmKhOCYfbtaTBGYog2hq6hT5/JYFA7nfVrQM7ee5PWyl06SCiH0zovw/LODW99pwnB4f siOJ9odYjAeWwRfcbs2So77Tgr4UtEQlyX9Hvura+XREsEBiubyzk/LHlQRwU4VQoByv/YiBejVDf Hg+UrAj7vpmNLG/eAFj6C5zHm+dlkq2hJyIKg1OQLfzxAsN6TxDH4LsOBNLjeieKj7v3k94xKg/Dy YrjpLGKwtH9qZDgbp7gQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh9Or-008xwU-4F; Wed, 20 Apr 2022 12:25:37 +0000 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh9Oo-008xvs-0e for linux-arm-kernel@lists.infradead.org; Wed, 20 Apr 2022 12:25:35 +0000 Received: by mail-il1-x131.google.com with SMTP id i8so855599ila.5 for ; Wed, 20 Apr 2022 05:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hRURk4DN2eZqCTEqfyXp6e+58OlcNywvCaEhVw8AW1k=; b=NhfhqCCs3Hf2EcKb/RtIq/hjv48Ps2GXEYJ25dNCUTbtl1svXYZdaLXsrgj7QWWPdM 3oPVrUA81IyvWsn6DwAwMq/wFx4wtiCNIZ4QMETSQs8O1/Ye+puhovoY8VYUq1iH/jXX XrqVbKAbZpXr39qKer3R/EqS37otJinwycoykfbrxTXYCCQpBa/ljq9oFdjT6hziWSS7 9D1VG3znG9Hyl+SjpRiJLYwyJ/6/CFz0ltHThGbWLEEy6Bpf4OHCM43Hf1lncvlyeP2v t9bW6z6eQS1zHeK4eOBVQWQoY/2TdPvuLDlrwSEql08qeayxkYpHay7K4KcQoTyPt6vf HlZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hRURk4DN2eZqCTEqfyXp6e+58OlcNywvCaEhVw8AW1k=; b=WxvWvi+RNphygojFWJ8pxJs6BuqCT08oOB/XzinYnpzLUobjxeGKDfC4Usjb7VUCls Zwlak/DK0oaAqCcGO5SzPRh3okmkdbRbzfJwe0oqnXC5l7wftPvDik1HYn0xYUHACICE k4sfpiGcHHTQ6gXaKtjmNIHokz2WhmJ2sfigWssbdquqADxASMqeNxC1bfhcNeNSti9w Zed4aw7Z8KzWbohZZDG9H0nP3gBTZBzuBFPfu2MSkJ6g0nvbtgY1wo31P0TUf8qO5V0l g7Yjt4JSZNu82T9FH5UlzC58w6+xleQj9LVWjAlglM00z6/guQf06y9TqamUbuFuIv8e 0Lsw== X-Gm-Message-State: AOAM530e9O2ZQ9Nj4iLxZ6B4onvD9aEoTdyIBKaFL6Skn4LFFf0cP9zD zzIsuz4OYaK/RIKiWIjaDfByqGJ0qNgVFw6kyD0= X-Google-Smtp-Source: ABdhPJxR05XY11iOWutfHq8oz3L83XIEM/5S8NVV9L7I7mrKegnWO3BlDIq1sHEfoLPpDNiMs/wLF6X1KXkixVdCtjk= X-Received: by 2002:a92:6012:0:b0:2bd:fb5f:d627 with SMTP id u18-20020a926012000000b002bdfb5fd627mr8766792ilb.86.1650457532838; Wed, 20 Apr 2022 05:25:32 -0700 (PDT) MIME-Version: 1.0 References: <20220323120021.361137-1-alistair@alistair23.me> In-Reply-To: <20220323120021.361137-1-alistair@alistair23.me> From: Alistair Francis Date: Wed, 20 Apr 2022 22:25:06 +1000 Message-ID: Subject: Re: [PATCH v7 0/4] Add support for the Cypress cyttsp5 To: Alistair Francis Cc: linux-input , devicetree , linux-arm-kernel , Linux Kernel Mailing List , Henrik Rydberg , Linus Walleij , Rob Herring , Dmitry Torokhov , Andreas Kemnade X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_052534_097966_4F88983B X-CRM114-Status: GOOD ( 25.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 23, 2022 at 10:00 PM Alistair Francis wrote: > > This patch series builds on top of [1] and adds support for the cyttsp5 > touchscreen controller for the reMarkable 2. > > I first tried to add an I2C HID device. Although the cyttsp5 has some HID > looking aspects it is not HID compatible. Just in trying to probe the device > I found: > - The HID descriptor has extra padding > - The HID descriptor sets the high bytes of the descriptor length > - The HID descriptor has extra unrecognised tags > - The HID reset command doesn't appear to work > > I don't think there is a way to use the I2C HID framework with the cyttsp5. > For anyone interested you can see the work here [2]. In that branch though I > can only obtain a HID descriptor, nothing else works without more core > changes. > > So instead I rebased the series from [1]. Converted to the new yaml DTS > documentation, added regulator support and fixed a x/y miscalculation bug. The DT bindings have been reviewed, any comments on the driver implementation? It has been tested on a few different devices Alistair > > 1: https://lwn.net/ml/linux-kernel/20180703094309.18514-1-mylene.josserand@bootlin.com/ > 2: https://github.com/alistair23/linux/commits/rM2-mainline-cyttsp5-hid > > v7: > - Fix device tree warnings > v6: > - Use reg for the button properties > v5: > - Address review comments from v4 > > Alistair Francis (4): > Input: Add driver for Cypress Generation 5 touchscreen > dt-bindings: input: Add Cypress TT2100 touchscreen controller > ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen > ARM: dts: imx7d-remarkable2: Enable the cyttsp5 > > .../input/touchscreen/cypress,tt21000.yaml | 101 ++ > arch/arm/boot/dts/imx7d-remarkable2.dts | 100 ++ > arch/arm/configs/imx_v6_v7_defconfig | 1 + > drivers/input/touchscreen/Kconfig | 16 + > drivers/input/touchscreen/Makefile | 1 + > drivers/input/touchscreen/cyttsp5.c | 902 ++++++++++++++++++ > 6 files changed, 1121 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml > create mode 100644 drivers/input/touchscreen/cyttsp5.c > > -- > 2.35.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel