From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0F4BC433F5 for ; Thu, 6 Jan 2022 21:31:35 +0000 (UTC) Received: from localhost ([::1]:46344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5aMA-0005ou-Sz for qemu-devel@archiver.kernel.org; Thu, 06 Jan 2022 16:31:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5aLM-0004zJ-PN; Thu, 06 Jan 2022 16:30:44 -0500 Received: from [2607:f8b0:4864:20::133] (port=41865 helo=mail-il1-x133.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5aLL-0002Dj-61; Thu, 06 Jan 2022 16:30:44 -0500 Received: by mail-il1-x133.google.com with SMTP id r16so1413997ile.8; Thu, 06 Jan 2022 13:30:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EHDqSzQq9d5rvs/fWBJCpGh6zHf8jrG5WwPdUWwMyXM=; b=dqG2cIO6KptW68YgjwqyNheBcixS50kBIoKw6NVVLubxJJXa/J+Rp7CpAujHoDxYjR pwh64gzjlHjRwFi1Ank2C69RA5WV79Jx4zTvE/8cj7290dDM0Aic09JhiYUIMQjFxSX8 hdhmPRZIbZl/WFmxe4Bo1R0eTSYXKqIS3hiub7VnIUaYAU2kaEnu2NRVfSKS4Q3h35NH iWltrX4DLKKrI/xgzUXWHiVO5A9Z+BuXBAoxGs9NZ4G9oN/KwP6bVy2aW2I79JmEo7BI 82cCl214HAqWb7wSKV14OviqXd/MfrIRVGLav/kyNl1AJyurd1g+K4nRFfmbyzMHnUJk y36A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EHDqSzQq9d5rvs/fWBJCpGh6zHf8jrG5WwPdUWwMyXM=; b=5f6Hs5YuRaR1ICbSQuQyCtSE9FRZLTGpWkkVTXXntSqy0GWSAR/5gbs1iK3tD4JfGq gdjSDsjQVmFu8R62NdBayfCKWtUlZjQm3NM4IliwBcSZVDXjhS5rrk4o7hQYksxveTGt Gu/vx6sAaORM0rgyyoECrntl1YwxfoKVhxtmqpqsc3fm5n4Gz4tPPtFsZUY8qDVGzi+Q Es/jFA3y+SCNGzF4L12XsxZ3pggKMrtNWrsJHSYs3pk9pTkWaMKvg09N+ShbBpoDDQeG LUbiYPbFSyk/IFu8ddXX5GHB7oyJXx6x3c+CtIgL212wwYVbYuQAFOVoXmwahfj2v0ge eO2A== X-Gm-Message-State: AOAM533DFCwqVjLPN7sgYsbQMKWd6q2d9Bw0xnlozTluaoRa90/vllv/ Neyxs0hxeRfFqdTWMfqO4GQnDeRKS7yBvUcg9vQ= X-Google-Smtp-Source: ABdhPJwA9SCEbsMGgMzmgIY0dWI2keuo7ceaxVTH3TYQ38WzVu67+6kVddsLI1FO55nxKZtgi8RpJo5fifKouluXSUA= X-Received: by 2002:a05:6e02:1569:: with SMTP id k9mr27251063ilu.290.1641504641577; Thu, 06 Jan 2022 13:30:41 -0800 (PST) MIME-Version: 1.0 References: <20220106134020.1628889-1-philipp.tomsich@vrull.eu> In-Reply-To: <20220106134020.1628889-1-philipp.tomsich@vrull.eu> From: Alistair Francis Date: Fri, 7 Jan 2022 07:30:15 +1000 Message-ID: Subject: Re: [PATCH] target/riscv: Fix position of 'experimental' comment To: Philipp Tomsich Content-Type: text/plain; charset="UTF-8" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::133 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::133; envelope-from=alistair23@gmail.com; helo=mail-il1-x133.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V" , Bin Meng , Vineet Gupta , "qemu-devel@nongnu.org Developers" , Alistair Francis , Palmer Dabbelt Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jan 7, 2022 at 12:30 AM Philipp Tomsich wrote: > > When commit 0643c12e4b dropped the 'x-' prefix for Zb[abcs] and set > them to be enabled by default, the comment about experimental > extensions was kept in place above them. This moves it down a few > lines to only cover experimental extensions. > > References: 0643c12e4b ("target/riscv: Enable bitmanip Zb[abcs] instructions") > > Signed-off-by: Philipp Tomsich Reviewed-by: Alistair Francis Alistair > > --- > > target/riscv/cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c > index 6ef3314bce..e322e729d2 100644 > --- a/target/riscv/cpu.c > +++ b/target/riscv/cpu.c > @@ -640,11 +640,12 @@ static Property riscv_cpu_properties[] = { > DEFINE_PROP_UINT16("vlen", RISCVCPU, cfg.vlen, 128), > DEFINE_PROP_UINT16("elen", RISCVCPU, cfg.elen, 64), > > - /* These are experimental so mark with 'x-' */ > DEFINE_PROP_BOOL("zba", RISCVCPU, cfg.ext_zba, true), > DEFINE_PROP_BOOL("zbb", RISCVCPU, cfg.ext_zbb, true), > DEFINE_PROP_BOOL("zbc", RISCVCPU, cfg.ext_zbc, true), > DEFINE_PROP_BOOL("zbs", RISCVCPU, cfg.ext_zbs, true), > + > + /* These are experimental so mark with 'x-' */ > DEFINE_PROP_BOOL("x-h", RISCVCPU, cfg.ext_h, false), > DEFINE_PROP_BOOL("x-j", RISCVCPU, cfg.ext_j, false), > /* ePMP 0.9.3 */ > -- > 2.33.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1n5aLN-00051F-U0 for mharc-qemu-riscv@gnu.org; Thu, 06 Jan 2022 16:30:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5aLM-0004zJ-PN; Thu, 06 Jan 2022 16:30:44 -0500 Received: from [2607:f8b0:4864:20::133] (port=41865 helo=mail-il1-x133.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5aLL-0002Dj-61; Thu, 06 Jan 2022 16:30:44 -0500 Received: by mail-il1-x133.google.com with SMTP id r16so1413997ile.8; Thu, 06 Jan 2022 13:30:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EHDqSzQq9d5rvs/fWBJCpGh6zHf8jrG5WwPdUWwMyXM=; b=dqG2cIO6KptW68YgjwqyNheBcixS50kBIoKw6NVVLubxJJXa/J+Rp7CpAujHoDxYjR pwh64gzjlHjRwFi1Ank2C69RA5WV79Jx4zTvE/8cj7290dDM0Aic09JhiYUIMQjFxSX8 hdhmPRZIbZl/WFmxe4Bo1R0eTSYXKqIS3hiub7VnIUaYAU2kaEnu2NRVfSKS4Q3h35NH iWltrX4DLKKrI/xgzUXWHiVO5A9Z+BuXBAoxGs9NZ4G9oN/KwP6bVy2aW2I79JmEo7BI 82cCl214HAqWb7wSKV14OviqXd/MfrIRVGLav/kyNl1AJyurd1g+K4nRFfmbyzMHnUJk y36A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EHDqSzQq9d5rvs/fWBJCpGh6zHf8jrG5WwPdUWwMyXM=; b=5f6Hs5YuRaR1ICbSQuQyCtSE9FRZLTGpWkkVTXXntSqy0GWSAR/5gbs1iK3tD4JfGq gdjSDsjQVmFu8R62NdBayfCKWtUlZjQm3NM4IliwBcSZVDXjhS5rrk4o7hQYksxveTGt Gu/vx6sAaORM0rgyyoECrntl1YwxfoKVhxtmqpqsc3fm5n4Gz4tPPtFsZUY8qDVGzi+Q Es/jFA3y+SCNGzF4L12XsxZ3pggKMrtNWrsJHSYs3pk9pTkWaMKvg09N+ShbBpoDDQeG LUbiYPbFSyk/IFu8ddXX5GHB7oyJXx6x3c+CtIgL212wwYVbYuQAFOVoXmwahfj2v0ge eO2A== X-Gm-Message-State: AOAM533DFCwqVjLPN7sgYsbQMKWd6q2d9Bw0xnlozTluaoRa90/vllv/ Neyxs0hxeRfFqdTWMfqO4GQnDeRKS7yBvUcg9vQ= X-Google-Smtp-Source: ABdhPJwA9SCEbsMGgMzmgIY0dWI2keuo7ceaxVTH3TYQ38WzVu67+6kVddsLI1FO55nxKZtgi8RpJo5fifKouluXSUA= X-Received: by 2002:a05:6e02:1569:: with SMTP id k9mr27251063ilu.290.1641504641577; Thu, 06 Jan 2022 13:30:41 -0800 (PST) MIME-Version: 1.0 References: <20220106134020.1628889-1-philipp.tomsich@vrull.eu> In-Reply-To: <20220106134020.1628889-1-philipp.tomsich@vrull.eu> From: Alistair Francis Date: Fri, 7 Jan 2022 07:30:15 +1000 Message-ID: Subject: Re: [PATCH] target/riscv: Fix position of 'experimental' comment To: Philipp Tomsich Cc: "qemu-devel@nongnu.org Developers" , "open list:RISC-V" , Bin Meng , Vineet Gupta , Alistair Francis , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::133 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::133; envelope-from=alistair23@gmail.com; helo=mail-il1-x133.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jan 2022 21:30:45 -0000 On Fri, Jan 7, 2022 at 12:30 AM Philipp Tomsich wrote: > > When commit 0643c12e4b dropped the 'x-' prefix for Zb[abcs] and set > them to be enabled by default, the comment about experimental > extensions was kept in place above them. This moves it down a few > lines to only cover experimental extensions. > > References: 0643c12e4b ("target/riscv: Enable bitmanip Zb[abcs] instructions") > > Signed-off-by: Philipp Tomsich Reviewed-by: Alistair Francis Alistair > > --- > > target/riscv/cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c > index 6ef3314bce..e322e729d2 100644 > --- a/target/riscv/cpu.c > +++ b/target/riscv/cpu.c > @@ -640,11 +640,12 @@ static Property riscv_cpu_properties[] = { > DEFINE_PROP_UINT16("vlen", RISCVCPU, cfg.vlen, 128), > DEFINE_PROP_UINT16("elen", RISCVCPU, cfg.elen, 64), > > - /* These are experimental so mark with 'x-' */ > DEFINE_PROP_BOOL("zba", RISCVCPU, cfg.ext_zba, true), > DEFINE_PROP_BOOL("zbb", RISCVCPU, cfg.ext_zbb, true), > DEFINE_PROP_BOOL("zbc", RISCVCPU, cfg.ext_zbc, true), > DEFINE_PROP_BOOL("zbs", RISCVCPU, cfg.ext_zbs, true), > + > + /* These are experimental so mark with 'x-' */ > DEFINE_PROP_BOOL("x-h", RISCVCPU, cfg.ext_h, false), > DEFINE_PROP_BOOL("x-j", RISCVCPU, cfg.ext_j, false), > /* ePMP 0.9.3 */ > -- > 2.33.1 > >