From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQFfs-0004nI-77 for qemu-devel@nongnu.org; Wed, 28 Jun 2017 12:18:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQFfr-00030V-C3 for qemu-devel@nongnu.org; Wed, 28 Jun 2017 12:18:40 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:36629) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dQFfr-00030M-6J for qemu-devel@nongnu.org; Wed, 28 Jun 2017 12:18:39 -0400 Received: by mail-wm0-x241.google.com with SMTP id y5so12432619wmh.3 for ; Wed, 28 Jun 2017 09:18:39 -0700 (PDT) MIME-Version: 1.0 Sender: alistair23@gmail.com In-Reply-To: <20170628061540.GL4859@toto> References: <55b6931c368b67ece2f0bd7d8e83092727df1e3c.1498596157.git.alistair.francis@xilinx.com> <20170627211037.GE2201@toto> <20170628061540.GL4859@toto> From: Alistair Francis Date: Wed, 28 Jun 2017 09:18:07 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [RFC v1 3/3] char-socket: Report TCP socket waiting as a warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" Cc: Alistair Francis , "qemu-devel@nongnu.org Developers" , Markus Armbruster On Tue, Jun 27, 2017 at 11:15 PM, Edgar E. Iglesias wrote: > On Tue, Jun 27, 2017 at 05:17:58PM -0700, Alistair Francis wrote: >> On Tue, Jun 27, 2017 at 2:10 PM, Edgar E. Iglesias >> wrote: >> > On Tue, Jun 27, 2017 at 01:45:48PM -0700, Alistair Francis wrote: >> >> When QEMU is waiting for a TCP socket connection it reports that message as >> >> an error. This isn't an error it is a warnign so let's change the report to >> >> use warning_report() instead. >> > >> > Hi Alistair, >> > >> > Isn't this more like an informational message rather than a warning? >> > >> > A warning would indicate to me that something unexpected and perhaps wrong happened. >> > In this case, there's nothing wrong going on. >> > >> > We may need more classes, like 'info:' and/or maybe others... >> >> Hey Edgar, >> >> That is a good point. I can add a info_report() as well then that >> copies the warning_report() function but prefixes with 'info: '. > > > Hi, > > Yes, or another way is to pass the class of message as an argument, > e.g like qemu_log_mask does it. Ah! That is a good idea. Something like this: report(ERROR, "message, ...) report(WARN, "message, ...) report(INFO, "message, ...) which gets converted to adding prefixes to the message. Thanks, Alistair > > Best regards, > Edgar > > > > >> >> Thanks, >> Alistair >> >> > >> > Cheers, >> > Edgar >> > >> > >> > >> >> >> >> Signed-off-by: Alistair Francis >> >> --- >> >> >> >> chardev/char-socket.c | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/chardev/char-socket.c b/chardev/char-socket.c >> >> index ccc499cfa1..5a56628e74 100644 >> >> --- a/chardev/char-socket.c >> >> +++ b/chardev/char-socket.c >> >> @@ -765,7 +765,7 @@ static int tcp_chr_wait_connected(Chardev *chr, Error **errp) >> >> * in TLS and telnet cases, only wait for an accepted socket */ >> >> while (!s->ioc) { >> >> if (s->is_listen) { >> >> - error_report("QEMU waiting for connection on: %s", >> >> + warning_report("QEMU waiting for connection on: %s", >> >> chr->filename); >> >> qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), true, NULL); >> >> tcp_chr_accept(QIO_CHANNEL(s->listen_ioc), G_IO_IN, chr); >> >> -- >> >> 2.11.0 >> >> >> >> >