All of lore.kernel.org
 help / color / mirror / Atom feed
From: JongSeok Won <wjs890204@gmail.com>
To: ofono@ofono.org
Subject: [PATCH] build: require glib >= 2.60
Date: Tue, 16 Feb 2021 18:31:54 +0900	[thread overview]
Message-ID: <CAKnLNuQdXPXVYrcJpmvbH8U5xsSR54JT4KxmyNNHeXoaCnTncg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

Build failure in the latest version has occurred with glib 2.56.4.

src/simutil.c: In function ‘validate_utf8_tlv’:
> src/simutil.c:779:9: error: implicit declaration of function
> ‘g_utf8_validate_len’; did you mean ‘g_utf8_validate’?
> [-Werror=implicit-function-declaration]
>   return g_utf8_validate_len((const char *)tlv + 2, len, NULL);
>          ^~~~~~~~~~~~~~~~~~~
>          g_utf8_validate
>

According to glib documentation, "g_utf8_validate_len" is supported since
2.60
So, I sent this patch.

Regards,
JongSeok Won

---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index d4efc8a8..f195c862 100644
--- a/configure.ac
+++ b/configure.ac
@@ -63,8 +63,8 @@ AC_CHECK_FUNC(signalfd, dummy=yes,
 AC_CHECK_LIB(dl, dlopen, dummy=yes,
  AC_MSG_ERROR(dynamic linking loader is required))

-PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.32, dummy=yes,
- AC_MSG_ERROR(GLib >= 2.32 is required))
+PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.60, dummy=yes,
+ AC_MSG_ERROR(GLib >= 2.60 is required))
 AC_SUBST(GLIB_CFLAGS)
 AC_SUBST(GLIB_LIBS)
 --

[-- Attachment #2: attachment.htm --]
[-- Type: text/html, Size: 1790 bytes --]

             reply	other threads:[~2021-02-16  9:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16  9:31 JongSeok Won [this message]
2021-02-26  5:41 [PATCH] build: require glib >= 2.60 JongSeok Won
2021-03-05 14:49 ` Denis Kenzior
2021-03-08  9:22   ` JongSeok Won
2021-03-08  9:33     ` JongSeok Won
2021-04-30 14:47       ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKnLNuQdXPXVYrcJpmvbH8U5xsSR54JT4KxmyNNHeXoaCnTncg@mail.gmail.com \
    --to=wjs890204@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.