All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rami Rosen <roszenrami@gmail.com>
To: Daniel Mack <daniel@zonque.org>
Cc: htejun@fb.com, daniel@iogearbox.net, ast@fb.com,
	David Miller <davem@davemloft.net>,
	kafai@fb.com, fw@strlen.de, pablo@netfilter.org,
	harald@redhat.com, Netdev <netdev@vger.kernel.org>,
	Sargun Dhillon <sargun@sargun.me>,
	cgroups@vger.kernel.org
Subject: Re: [PATCH v4 2/6] cgroup: add support for eBPF programs
Date: Wed, 7 Sep 2016 07:58:19 +0300	[thread overview]
Message-ID: <CAKoUAr=M6Mmqmrz=uRh6SEUXMki4m0yR+cGNZJUNe3pGk6NhNw@mail.gmail.com> (raw)
In-Reply-To: <1473169568-30525-3-git-send-email-daniel@zonque.org>

Hi,


+ * __cgroup_bpf_update() - Update the pinned program of a cgroup, and
+ *                         propagate the change to descendants
+ * @cgrp: The cgroup which descendants to traverse

Missing here is @parent

+ * @prog: A new program to pin
+ * @type: Type of pinning operation (ingress/egress)

...

> +void __cgroup_bpf_update(struct cgroup *cgrp,
> +                        struct cgroup *parent,
> +                        struct bpf_prog *prog,
> +                        enum bpf_attach_type type)
> +{

Regards,
Rami Rosen

  parent reply	other threads:[~2016-09-07  4:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06 13:46 [PATCH v4 0/6] Add eBPF hooks for cgroups Daniel Mack
2016-09-06 13:46 ` [PATCH v4 1/6] bpf: add new prog type for cgroup socket filtering Daniel Mack
2016-09-06 13:46 ` [PATCH v4 2/6] cgroup: add support for eBPF programs Daniel Mack
     [not found]   ` <1473169568-30525-3-git-send-email-daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org>
2016-09-06 17:18     ` Daniel Borkmann
     [not found]       ` <57CEFA48.6010101-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>
2016-09-07  8:04         ` Daniel Mack
2016-09-07  4:58   ` Rami Rosen [this message]
2016-09-07  5:00   ` kbuild test robot
2016-09-06 13:46 ` [PATCH v4 3/6] bpf: add BPF_PROG_ATTACH and BPF_PROG_DETACH commands Daniel Mack
2016-09-06 13:46 ` [PATCH v4 4/6] net: filter: run cgroup eBPF ingress programs Daniel Mack
2016-09-06 13:46 ` [PATCH v4 5/6] net: core: run cgroup eBPF egress programs Daniel Mack
2016-09-06 13:46 ` [PATCH v4 6/6] samples: bpf: add userspace example for attaching eBPF programs to cgroups Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKoUAr=M6Mmqmrz=uRh6SEUXMki4m0yR+cGNZJUNe3pGk6NhNw@mail.gmail.com' \
    --to=roszenrami@gmail.com \
    --cc=ast@fb.com \
    --cc=cgroups@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=daniel@zonque.org \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=harald@redhat.com \
    --cc=htejun@fb.com \
    --cc=kafai@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=sargun@sargun.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.