From: Shuah Khan <shuahkhan@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Maarten Lankhorst <maarten.lankhorst@canonical.com>,
Greg KH <gregkh@linuxfoundation.org>,
Waiman Long <Waiman.Long@hp.com>, Ingo Molnar <mingo@kernel.org>,
Rik van Riel <riel@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Scott J Norton <scott.norton@hp.com>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH 2/2 v6] locking/selftest: Support queued rwlock
Date: Tue, 5 Aug 2014 09:05:53 -0600 [thread overview]
Message-ID: <CAKocOOM=c2jaW_D27Z_iHoSzknp38j0gh_Exa3iTf5CzFkmPJA@mail.gmail.com> (raw)
In-Reply-To: <20140805145437.GL9918@twins.programming.kicks-ass.net>
On Tue, Aug 5, 2014 at 8:54 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, Aug 05, 2014 at 04:44:34PM +0200, Maarten Lankhorst wrote:
>> op 05-08-14 16:41, Peter Zijlstra schreef:
>
>> >> A bit off topic for this patch, however relevant for tests in general.
>> >> Is there a reason why these locking selftests need to be under lib?
>> >> Can they be consolidated under tools/testing/selftests?
>> > tools/ seems wrong as its very much not userspace.
>> Could be moved to kernel/locking though now that all other locking moved there. :-)
>
> Yes, I suppose we could do that; IIRC the reason I left it where it is
> is because there are more tests in lib/.
Maybe if tools doesn't sounds right, we could move testing from under tools
and have it be testing
We have several selftests spread around in the kernel tree. It makes it easier
to pull them under a single make target devtest. I sent in a patch add devtest
target that runs tests that are under tools/testing/selftests a couple of
weeks ago, hopefully it will be included in 3.17. I am working towards pulling
more kernel selftests that exist under this devtest umbrella. That is
the motivation
behind starting this conversation. :)
-- Shuah
next prev parent reply other threads:[~2014-08-05 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 18:53 [PATCH 0/2 v6] lockdep: add support for queued rwlock Waiman Long
2014-07-29 18:53 ` [PATCH 1/2 v6] locking/lockdep: Restrict the use of recursive read_lock() with qrwlock Waiman Long
2014-07-29 18:53 ` [PATCH 2/2 v6] locking/selftest: Support queued rwlock Waiman Long
2014-08-05 13:28 ` Peter Zijlstra
2014-08-05 14:07 ` Shuah Khan
2014-08-05 14:41 ` Peter Zijlstra
2014-08-05 14:44 ` Maarten Lankhorst
2014-08-05 14:54 ` Peter Zijlstra
2014-08-05 15:05 ` Shuah Khan [this message]
2014-08-05 15:25 ` Peter Zijlstra
2014-08-05 15:45 ` Shuah Khan
2014-08-06 17:24 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKocOOM=c2jaW_D27Z_iHoSzknp38j0gh_Exa3iTf5CzFkmPJA@mail.gmail.com' \
--to=shuahkhan@gmail.com \
--cc=Waiman.Long@hp.com \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@canonical.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=scott.norton@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.