From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH V4 1/3] OPP: Redefine bindings to overcome shortcomings Date: Tue, 5 May 2015 17:13:33 +0530 Message-ID: References: <20150504121209.GM15510@sirena.org.uk> <20150505105714.GA22845@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20150505105714.GA22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Rafael Wysocki , Rob Herring , Arnd Bergmann , Nishanth Menon , Mike Turquette , Stephen Boyd , Linaro Kernel Mailman List , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Grant Likely , "olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org" , Sudeep Holla , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Viswanath Puttagunta , Lucas Stach , Thomas Petazzoni , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Thomas Abraham , Abhilash Kesavan , Kevin Hilman , santosh List-Id: devicetree@vger.kernel.org On 5 May 2015 at 16:27, Mark Brown wrote: > No, it doesn't - you're not answering the question about what this is > for. I don't know how this information will be used finally. Probably the platform driver will do the configuration based on the volt-cur pair. > To know if this makes sense I need to know what you beleive "setting the > current" does. If you literally mean setting the current it makes no > sense at all. If you mean something else that something else should > probably be written into the binding. Yeah, that was a wrong statement. We can't configure current separately. Does this diff make it any better ? diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt index c96dc77121b7..a57e88ab4554 100644 --- a/Documentation/devicetree/bindings/power/opp.txt +++ b/Documentation/devicetree/bindings/power/opp.txt @@ -59,16 +59,18 @@ properties. regulators are specified in device's DT node. - opp-microamp: current in micro Amperes. It can contain entries for multiple - regulators. + regulators. This can be referenced (along with voltage and freqency) while + programming the regulator. A single regulator's current is specified with an array of size one or three. Single entry is for target current and three entries are for currents. Entries for multiple regulators must be present in the same order as - regulators are specified in device's DT node. If few regulators don't provide - capability to configure current, then values for then should be marked as - zero. + regulators are specified in device's DT node. If current value for few + regulators isn't required to be passed, then values for such regulators should + be marked as zero. If it isn't required for any regulator, then this property + need not be present. - clock-latency-ns: Specifies the maximum possible transition latency (in nanoseconds) for switching to this OPP from any other OPP. (Restoring my laptop after a corrupted disk, and so sending it from gmail, might be a bit corrupted).. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@linaro.org (Viresh Kumar) Date: Tue, 5 May 2015 17:13:33 +0530 Subject: [PATCH V4 1/3] OPP: Redefine bindings to overcome shortcomings In-Reply-To: <20150505105714.GA22845@sirena.org.uk> References: <20150504121209.GM15510@sirena.org.uk> <20150505105714.GA22845@sirena.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 5 May 2015 at 16:27, Mark Brown wrote: > No, it doesn't - you're not answering the question about what this is > for. I don't know how this information will be used finally. Probably the platform driver will do the configuration based on the volt-cur pair. > To know if this makes sense I need to know what you beleive "setting the > current" does. If you literally mean setting the current it makes no > sense at all. If you mean something else that something else should > probably be written into the binding. Yeah, that was a wrong statement. We can't configure current separately. Does this diff make it any better ? diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt index c96dc77121b7..a57e88ab4554 100644 --- a/Documentation/devicetree/bindings/power/opp.txt +++ b/Documentation/devicetree/bindings/power/opp.txt @@ -59,16 +59,18 @@ properties. regulators are specified in device's DT node. - opp-microamp: current in micro Amperes. It can contain entries for multiple - regulators. + regulators. This can be referenced (along with voltage and freqency) while + programming the regulator. A single regulator's current is specified with an array of size one or three. Single entry is for target current and three entries are for currents. Entries for multiple regulators must be present in the same order as - regulators are specified in device's DT node. If few regulators don't provide - capability to configure current, then values for then should be marked as - zero. + regulators are specified in device's DT node. If current value for few + regulators isn't required to be passed, then values for such regulators should + be marked as zero. If it isn't required for any regulator, then this property + need not be present. - clock-latency-ns: Specifies the maximum possible transition latency (in nanoseconds) for switching to this OPP from any other OPP. (Restoring my laptop after a corrupted disk, and so sending it from gmail, might be a bit corrupted)..