From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH v5 07/18] thermal: exynos: Modify exynos thermal code to use device tree for cpu cooling configuration Date: Wed, 21 Jan 2015 15:25:09 +0530 Message-ID: References: <1412872737-624-1-git-send-email-l.majewski@samsung.com> <1421666462-7606-1-git-send-email-l.majewski@samsung.com> <1421666462-7606-8-git-send-email-l.majewski@samsung.com> <20150121093304.7ac02a27@amdc2363> <20150121104719.69f20ca8@amdc2363> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-oi0-f54.google.com ([209.85.218.54]:38531 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546AbbAUJzK (ORCPT ); Wed, 21 Jan 2015 04:55:10 -0500 Received: by mail-oi0-f54.google.com with SMTP id v63so482621oia.13 for ; Wed, 21 Jan 2015 01:55:10 -0800 (PST) In-Reply-To: <20150121104719.69f20ca8@amdc2363> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Lukasz Majewski Cc: Eduardo Valentin , Zhang Rui , Kukjin Kim , Kukjin Kim , Linux PM list , "linux-samsung-soc@vger.kernel.org" , Bartlomiej Zolnierkiewicz , Lukasz Majewski , Amit Daniel Kachhap , Abhilash Kesavan , Abhilash Kesavan , Kyungmin Park , Chanwoo Choi On 21 January 2015 at 15:17, Lukasz Majewski wrote: > In previous versions I've only checked for cpu 0. > > If you think that it is enough to explicitly check only for cpu 0 and > forget about above "fail safe" code (when. e.g. CPU3 has defined > cooling-cells), then I'm fine with it. I don't know what bindings are you following, but cpufreq-dt's bindings say that it has to be present in cpu0. Anyway, this driver isn't for a multi-cluster system and so cpu0 should be fine. > As I've mention - it would be maintainer's call if one trades potential > regression for patch separation. I am just asking it to split into a separate patch, not that I will get it through cpufreq. Eduardo can take it, but it should be a separate patch.