All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
	"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Nishanth Menon <nm@ti.com>, Kgene Kim <kgene.kim@samsung.com>,
	jinchoi@broadcom.com, Lan Tianyu <tianyu.lan@intel.com>,
	Sebastian Capella <sebastian.capella@linaro.org>,
	Jonghwan Choi <jhbird.choi@samsung.com>
Subject: Re: [PATCH V5 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}()
Date: Mon, 17 Feb 2014 11:38:53 +0530	[thread overview]
Message-ID: <CAKohpo=7Kbvh5UN9iZ6V3e=1ZY6y5_grQjxj6raEL_djHnMZrQ@mail.gmail.com> (raw)
In-Reply-To: <52FE71BD.3020103@wwwdotorg.org>

On 15 February 2014 01:12, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 02/12/2014 11:50 PM, Viresh Kumar wrote:
>> This patchset creates/calls cpufreq suspend/resume callbacks from dpm_{suspend|resume}()
>> for handling suspend/resume of cpufreq governors and core.
>
> Are these patches for 3.14 or 3.15?

3.15

> I ask because I just tested Linus's master from a few days back (some
> point after v3.14-rc2; commit 9398a10cd964 Merge tag
> 'regulator-v3.14-rc2'), and I see a lot of the following messages during
> suspend and/or resume (about 2-7 times, perhaps more of them from the
> resume path, but it's hard to tell):
>
> cpufreq: __cpufreq_driver_target: Failed to change cpu frequency: -16

That's because you return -EBUSY from your tegra_cpu_init() once
suspend/resume has started. Probably the print message is new here,
and so you are able to see it failing.. Nothing else should have changed
otherwise.

> This series does appear to solve those, so I think at least part of it
> needs to be applied for 3.14.

Because we disallow calls to __cpufreq_driver_target() after suspend/
resume have started.

> Also, I sometimes see the following during resume. I saw it twice with
> Linus's tree, but then I did 10 more reboot+suspend+resume cycles and
> couldn't repro it, and I saw it once with Linus's tree plus this series
> applied, then couldn't reproduce it in 5 more tries.

> Do you have any idea what the problem might be, and how to solve it?

Not yet, will check..

      parent reply	other threads:[~2014-02-17  6:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13  6:50 [PATCH V5 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}() Viresh Kumar
2014-02-13  6:50 ` [PATCH V5 1/7] cpufreq: suspend governors on system suspend/hibernate Viresh Kumar
2014-02-13  6:50 ` [PATCH V5 2/7] cpufreq: suspend governors from dpm_{suspend|resume}() Viresh Kumar
2014-02-13  6:50 ` [PATCH V5 3/7] cpufreq: call driver's suspend/resume for each policy Viresh Kumar
2014-02-13  6:50 ` [PATCH V5 4/7] cpufreq: Implement cpufreq_generic_suspend() Viresh Kumar
2014-02-13  6:50 ` [PATCH V5 5/7] cpufreq: exynos: Use cpufreq_generic_suspend() Viresh Kumar
2014-02-13  6:50 ` [PATCH V5 6/7] cpufreq: s5pv210: " Viresh Kumar
2014-02-13  6:50 ` [PATCH V5 7/7] cpufreq: Tegra: " Viresh Kumar
2014-02-14 19:42 ` [PATCH V5 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}() Stephen Warren
2014-02-14 20:22   ` Stephen Warren
2014-02-17  6:02     ` Viresh Kumar
2014-02-18 20:31       ` Stephen Warren
2014-02-14 22:23   ` Rafael J. Wysocki
2014-02-15  0:03     ` Stephen Warren
2014-02-17  9:20       ` Viresh Kumar
2014-02-18 20:18         ` Stephen Warren
2014-02-19  4:15           ` Viresh Kumar
2014-02-19 17:26             ` Stephen Warren
2014-02-20  1:49               ` Linaro
2014-02-20  1:50                 ` Linaro
2014-02-20 17:40                   ` Stephen Warren
2014-02-24  6:43                     ` Viresh Kumar
2014-02-24 17:17                       ` Stephen Warren
2014-02-17  6:08   ` Viresh Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKohpo=7Kbvh5UN9iZ6V3e=1ZY6y5_grQjxj6raEL_djHnMZrQ@mail.gmail.com' \
    --to=viresh.kumar@linaro.org \
    --cc=cpufreq@vger.kernel.org \
    --cc=jhbird.choi@samsung.com \
    --cc=jinchoi@broadcom.com \
    --cc=kgene.kim@samsung.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=rjw@rjwysocki.net \
    --cc=sebastian.capella@linaro.org \
    --cc=swarren@wwwdotorg.org \
    --cc=tianyu.lan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.