From: Viresh Kumar <viresh.kumar@linaro.org>
To: jonghwan Choi <jhbird.choi@gmail.com>
Cc: Nishanth Menon <nm@ti.com>,
Jonghwan Choi <jhbird.choi@samsung.com>,
Linux PM list <linux-pm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>,
Amit Daniel Kachhap <amit.daniel@samsung.com>
Subject: Re: [PATCH 1/3] PM / OPP: Add support for descending order for cpufreq table
Date: Mon, 12 May 2014 11:48:33 +0530 [thread overview]
Message-ID: <CAKohpo=wJAMgRqakX_WP+QshhpCqVNnA3e3gg4=s_sHaxfqwoQ@mail.gmail.com> (raw)
In-Reply-To: <CAGZ6kuPzpxh-r9-KfPDOGXQXjqcthMV07Nd_dgwvBd7w+F9A+w@mail.gmail.com>
On 11 May 2014 17:08, jonghwan Choi <jhbird.choi@gmail.com> wrote:
> I already considered it.
> (But it only passes on what cpufreq driver has to do to clock framework.
> For changing clock rate, if changing operation just divides a rate of
> parent it can be solved easily
> But exycpufreq driver is more complicated.
>
> Previously, to change frequency, pll value and clk divider value were
> changed in cpufreq driver.
> Later someone moved the code which changes pll value to clock framework.
> In there, pll values are maintained as table per frequency. And if
> frequency is added/removed, values of
> pll table should be changed.
> when we change the pll value through clk_set_rate, internally to find
> proper pll value, pll table is searched.
> If proper pll value is found, that value is written into the register)
>
> My suggestion is that all these change details should be removed
> according to adding/removing frequency.
> I believe that cpufreq driver just writes a specific value per
> frequency into the register for dvfs(Maybe other work is also needed)
>
> If we just describe the specific value per frequency in dts file, the
> driver will get that information through DT, and use it for DVFS.)
> Then when a new chip is released(if the chip has the same h/w
> interface - register map), we only have to do as above.
We also want to make your life simple, but adding this field to OPP
table isn't the right approach for sure.
Can't you calculate the divider values at run time based on a frequency?
I think it should work. That way you can just code these calculations
in clock driver and things would work smoothly..
If there are problems, tell us what they are and we will try to find some
solution for you. .
next prev parent reply other threads:[~2014-05-12 6:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 6:28 [PATCH 1/3] PM / OPP: Add support for descending order for cpufreq table Jonghwan Choi
2014-04-30 8:25 ` Viresh Kumar
2014-05-03 0:16 ` Jonghwan Choi
2014-05-05 5:54 ` Viresh Kumar
2014-05-05 13:38 ` Nishanth Menon
2014-05-05 14:14 ` Viresh Kumar
2014-05-05 14:23 ` Nishanth Menon
2014-05-05 14:38 ` Viresh Kumar
2014-05-05 14:46 ` Nishanth Menon
2014-05-06 23:43 ` Jonghwan Choi
2014-05-07 1:00 ` Nishanth Menon
2014-05-07 6:04 ` Viresh Kumar
2014-05-08 1:22 ` Jonghwan Choi
2014-05-08 1:55 ` Nishanth Menon
2014-05-08 2:07 ` Jonghwan Choi
2014-05-08 5:55 ` Viresh Kumar
2014-05-09 1:09 ` Jonghwan Choi
2014-05-09 6:00 ` Viresh Kumar
2014-05-09 11:59 ` jonghwan Choi
2014-05-09 13:23 ` Nishanth Menon
2014-05-09 13:23 ` Nishanth Menon
2014-05-11 11:38 ` jonghwan Choi
2014-05-12 6:18 ` Viresh Kumar [this message]
2014-05-08 5:50 ` Viresh Kumar
2014-05-06 17:25 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKohpo=wJAMgRqakX_WP+QshhpCqVNnA3e3gg4=s_sHaxfqwoQ@mail.gmail.com' \
--to=viresh.kumar@linaro.org \
--cc=amit.daniel@samsung.com \
--cc=jhbird.choi@gmail.com \
--cc=jhbird.choi@samsung.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.