From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752180AbaBXGnj (ORCPT ); Mon, 24 Feb 2014 01:43:39 -0500 Received: from mail-oa0-f53.google.com ([209.85.219.53]:49377 "EHLO mail-oa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbaBXGnZ (ORCPT ); Mon, 24 Feb 2014 01:43:25 -0500 MIME-Version: 1.0 In-Reply-To: <53063E01.5030808@wwwdotorg.org> References: <52FE71BD.3020103@wwwdotorg.org> <2869027.iYHxWOSS2C@vostro.rjw.lan> <52FEAECA.5080905@wwwdotorg.org> <5303C018.1020707@wwwdotorg.org> <5304E93C.9000104@wwwdotorg.org> <90EA67AE-7F57-4F43-8967-642903AD72AC@linaro.org> <53063E01.5030808@wwwdotorg.org> Date: Mon, 24 Feb 2014 12:13:24 +0530 Message-ID: Subject: Re: [PATCH V5 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}() From: Viresh Kumar To: Stephen Warren Cc: "Rafael J. Wysocki" , Lists linaro-kernel , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Nishanth Menon , Kgene Kim , "jinchoi@broadcom.com" , Lan Tianyu , Sebastian Capella , Jonghwan Choi Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20 February 2014 23:10, Stephen Warren wrote: > Well, except that still leaves a bunch of errors in the kernel log, and > I have to remember to ignore them:-/ Just for few releases, before this patchset goes in. > It'd be nice if the cpufreq core didn't keep changing its behaviour and > adding new error prints. It really should be up to the cpufreq drivers > to log the errors if they experience any. Hmm... not sure.. Its better to do error prints at a single place, i.e. cpufreq core on behalf of all drivers. If there is a error being returned from some routine, we better print a message for that. Rather than living in the illusion that everything is fine :)