From: Viresh Kumar <viresh.kumar@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
cpufreq@vger.kernel.org, linaro-kernel@lists.linaro.org,
Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] cpufreq: cpufreq-cpu0: NULL is a valid regulator
Date: Mon, 12 Aug 2013 10:49:46 +0530 [thread overview]
Message-ID: <CAKohpoktDH_t0_eYigHMn8ZYm4ZT61yRymC00i1YGhWChE3ArQ@mail.gmail.com> (raw)
In-Reply-To: <1376071592-18930-1-git-send-email-broonie@kernel.org>
On 9 August 2013 23:36, Mark Brown <broonie@kernel.org> wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Since NULL could in theory be a valid regulator we ought to check for
> IS_ERR() rather than for NULL. In practice this is unlikely to be an
> issue but it's better for neatness.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> drivers/cpufreq/cpufreq-cpu0.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
Makes sense.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
next prev parent reply other threads:[~2013-08-12 5:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 18:06 [PATCH] cpufreq: cpufreq-cpu0: NULL is a valid regulator Mark Brown
2013-08-12 5:19 ` Viresh Kumar [this message]
2013-08-13 13:09 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKohpoktDH_t0_eYigHMn8ZYm4ZT61yRymC00i1YGhWChE3ArQ@mail.gmail.com \
--to=viresh.kumar@linaro.org \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.