All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>
Cc: "Lists linaro-kernel" <linaro-kernel@lists.linaro.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Tejun Heo" <tj@kernel.org>, "Ingo Molnar" <mingo@kernel.org>
Subject: Re: [PATCH 2/2] timer: Make sure TIMER_FLAG_MASK bits are free in allocated base
Date: Tue, 11 Mar 2014 18:26:03 +0800	[thread overview]
Message-ID: <CAKohpomHXLVKqzFCbp8qt7gGpdDkc-s5wASRvw1EBwuB_fpceA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402281151180.18573@ionos.tec.linutronix.de>

Hi Thomas,

On 28 February 2014 18:52, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Fri, 28 Feb 2014, Viresh Kumar wrote:
>
>> Currently we are using two lowest bit of base for internal purpose and so they
>> both should be zero in the allocated address. The code was doing the right thing
>> before this patch came in:
>>
>> commit c5f66e99b7cb091e3d51ae8e8156892e8feb7fa3
>> Author: Tejun Heo <tj@kernel.org>
>> Date:   Wed Aug 8 11:10:28 2012 -0700
>>
>>     timer: Implement TIMER_IRQSAFE
>>
>> Tejun probably forgot to update this piece of code which checks if the lowest
>> 'n' bits are zero or not and so wasn't updated according to the new flag. Lets
>> use TIMER_FLAG_MASK in the calculations here, so that this code wouldn't require
>> a change later on with another flag in.
>
> Are you planning to introduce more flag horror? Don't go there. The
> timer_list code is about to be rewritten completely and I'm not going
> to add new features to the existing code base.

Do you already have stuff prepared that can be shared on that? I am asking
because I am working on some CPU isolation stuff for Networking domain and
it looks like I need to add another of these flags :( .. I know its
just not acceptable
and so wanted your thoughts on how can I get things fixed.

Peter asked me to implement something like cpuset.quiesce to move away all
timers/workqueues/etc from a cpuset. It was proposed here:

https://lkml.org/lkml/2014/1/15/186

Now, I was looking to migrate away the timers first but I obviously
shouldn't migrate
the pinned timers. One way out to identify PINNED timers is to mark them PINNED
with the flag bits, which you wouldn't allow. Can you give some other idea with
which I can get this solved.

--
viresh

  parent reply	other threads:[~2014-03-11 10:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28  8:45 [PATCH 1/2] timer: check failure of timer_cpu_notify() before calling init_timer_stats() Viresh Kumar
2014-02-28  8:45 ` [PATCH 2/2] timer: Make sure TIMER_FLAG_MASK bits are free in allocated base Viresh Kumar
2014-02-28 10:52   ` Thomas Gleixner
2014-02-28 16:51     ` Viresh Kumar
2014-03-11 10:26     ` Viresh Kumar [this message]
2014-03-18  8:09       ` Viresh Kumar
2014-03-19 20:32         ` Thomas Gleixner
2014-03-04 11:33   ` [tip:timers/core] " tip-bot for Viresh Kumar
2014-03-04 11:33 ` [tip:timers/core] timer: Check failure of timer_cpu_notify() before calling init_timer_stats() tip-bot for Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKohpomHXLVKqzFCbp8qt7gGpdDkc-s5wASRvw1EBwuB_fpceA@mail.gmail.com \
    --to=viresh.kumar@linaro.org \
    --cc=fweisbec@gmail.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.