From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756057AbaIDEx2 (ORCPT ); Thu, 4 Sep 2014 00:53:28 -0400 Received: from mail-ob0-f170.google.com ([209.85.214.170]:47321 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755946AbaIDExZ (ORCPT ); Thu, 4 Sep 2014 00:53:25 -0400 MIME-Version: 1.0 In-Reply-To: References: <1375475882-3660-1-git-send-email-zoran.markovic@linaro.org> Date: Thu, 4 Sep 2014 10:23:25 +0530 Message-ID: Subject: Re: [RFC PATCH] pm: prevent suspend until power supply events are processed From: Viresh Kumar To: Zoran Markovic Cc: Anton Vorontsov , "linux-kernel@vger.kernel.org" , David Woodhouse , Arve Hjonnevag , Todd Poynor , John Stultz Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4 September 2014 10:21, Viresh Kumar wrote: >>> >> + /* dependent power supplies (e.g. battery) may have changed >>> >> + * state as a result of this event, so poll again and hold >>> >> + * the wakeup_source until all events are processed. >>> >> + */ But isn't this comment still incorrect? Its not about dependent supplies but the race between the work-handler and its enqueuing?