From: Viresh Kumar <viresh.kumar@linaro.org>
To: Saravana Kannan <skannan@codeaurora.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Prarit Bhargava <prarit@redhat.com>
Subject: Re: [PATCH 09/18] cpufreq: Mark policy->governor = NULL for fallback policies
Date: Thu, 12 Feb 2015 15:56:19 +0800 [thread overview]
Message-ID: <CAKohpon-jqD-FC-KGQ_kTNew70fu84Km4fuicHbaMp_T9DW_LA@mail.gmail.com> (raw)
In-Reply-To: <54DC1C62.40303@codeaurora.org>
On 12 February 2015 at 11:22, Saravana Kannan <skannan@codeaurora.org> wrote:
> I don't see anything wrong with scaling_governor showing the last used
> governor when the CPUs are just logically hotplug removed. In the physical
But the governor is *not* used currently by the CPUs and marking it used is
completely wrong.
> hotplug case, the whole directory would go away and the policy would be
> freed. So, this is not a concern there.
Its not relevant here.
> Also, longer term (after your series goes in), I think we actually should
> NOT send POLICY_EXIT on just logical hotplug. That way, the governor
> tunables are not lost across a logical hotplug.
I am not sure about it. For example, after all CPUs of a policy are gone,
the governor is free to be get removed. And so the user should be free
to do rmmod on it.
next prev parent reply other threads:[~2015-02-12 7:56 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 8:36 [PATCH 00/18] cpufreq: don't loose cpufreq history on CPU hotplug Viresh Kumar
2015-01-27 8:36 ` [PATCH 01/18] cpufreq: Drop cpufreq_disabled() check from cpufreq_cpu_{get|put}() Viresh Kumar
2015-02-03 22:17 ` Saravana Kannan
2015-01-27 8:36 ` [PATCH 02/18] cpufreq: Create for_each_policy() Viresh Kumar
2015-02-03 22:22 ` Saravana Kannan
2015-02-04 4:53 ` Viresh Kumar
2015-01-27 8:36 ` [PATCH 03/18] cpufreq: Create for_each_governor() Viresh Kumar
2015-02-03 22:23 ` Saravana Kannan
2015-01-27 8:36 ` [PATCH 04/18] cpufreq: Manage fallback policies in a list Viresh Kumar
2015-02-03 0:41 ` Rafael J. Wysocki
2015-02-03 4:10 ` Viresh Kumar
2015-02-03 15:04 ` Rafael J. Wysocki
2015-02-04 6:18 ` Viresh Kumar
2015-02-03 22:28 ` Saravana Kannan
2015-02-04 6:20 ` Viresh Kumar
2015-02-04 22:28 ` Saravana Kannan
2015-02-04 23:20 ` Rafael J. Wysocki
2015-02-05 1:55 ` Saravana Kannan
2015-02-05 15:11 ` Rafael J. Wysocki
2015-02-05 22:55 ` Saravana Kannan
2015-02-17 8:06 ` Viresh Kumar
2015-02-17 18:15 ` Rafael J. Wysocki
2015-02-18 4:23 ` Viresh Kumar
2015-02-18 21:15 ` Saravana Kannan
2015-02-19 3:24 ` Viresh Kumar
2015-01-27 8:36 ` [PATCH 05/18] cpufreq: Manage governor usage history with 'policy->last_governor' Viresh Kumar
2015-02-12 3:03 ` Saravana Kannan
2015-02-12 7:44 ` Viresh Kumar
2015-02-12 8:00 ` skannan
2015-02-17 8:02 ` Viresh Kumar
2015-01-27 8:36 ` [PATCH 06/18] cpufreq: Reuse policy list instead of per-cpu variable 'cpufreq_cpu_data' Viresh Kumar
2015-02-12 3:13 ` Saravana Kannan
2015-02-12 7:48 ` Viresh Kumar
2015-01-27 8:36 ` [PATCH 07/18] cpufreq: Drop (now) useless check 'cpu > nr_cpu_ids' Viresh Kumar
2015-02-12 3:15 ` Saravana Kannan
2015-02-12 7:50 ` Viresh Kumar
2015-01-27 8:36 ` [PATCH 08/18] cpufreq: Add doc style comment about cpufreq_cpu_{get|put}() Viresh Kumar
2015-02-12 3:19 ` Saravana Kannan
2015-02-12 7:52 ` Viresh Kumar
2015-01-27 8:36 ` [PATCH 09/18] cpufreq: Mark policy->governor = NULL for fallback policies Viresh Kumar
2015-02-12 3:22 ` Saravana Kannan
2015-02-12 7:56 ` Viresh Kumar [this message]
2015-01-27 8:36 ` [PATCH 10/18] cpufreq: Don't allow updating inactive-policies from sysfs Viresh Kumar
2015-02-12 3:24 ` Saravana Kannan
2015-01-27 8:36 ` [PATCH 11/18] cpufreq: Track cpu managing sysfs kobjects separately Viresh Kumar
2015-01-27 8:36 ` [PATCH 12/18] cpufreq: Stop migrating sysfs files on hotplug Viresh Kumar
2015-01-27 8:36 ` [PATCH 13/18] cpufreq: Keep a single path for adding managed CPUs Viresh Kumar
2015-01-27 8:36 ` [PATCH 14/18] cpufreq: Remove cpufreq_update_policy() Viresh Kumar
2015-01-27 8:36 ` [PATCH 15/18] cpufreq: Initialize policy->kobj while allocating policy Viresh Kumar
2015-01-27 8:36 ` [PATCH 16/18] cpufreq: Call cpufreq_policy_put_kobj() from cpufreq_policy_free() Viresh Kumar
2015-01-27 8:36 ` [PATCH 17/18] cpufreq: Restart governor as soon as possible Viresh Kumar
2015-01-27 8:36 ` [PATCH 18/18] cpufreq: Merge __cpufreq_add_dev() and cpufreq_add_dev() Viresh Kumar
2015-01-27 15:06 ` [PATCH 00/18] cpufreq: don't loose cpufreq history on CPU hotplug Rafael J. Wysocki
2015-01-27 14:59 ` Viresh Kumar
2015-01-28 19:35 ` Saravana Kannan
2015-01-29 1:43 ` Viresh Kumar
2015-02-03 0:30 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKohpon-jqD-FC-KGQ_kTNew70fu84Km4fuicHbaMp_T9DW_LA@mail.gmail.com \
--to=viresh.kumar@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=skannan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.