From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934946AbcJUPkt (ORCPT ); Fri, 21 Oct 2016 11:40:49 -0400 Received: from mail-qk0-f170.google.com ([209.85.220.170]:36770 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933754AbcJUPkr (ORCPT ); Fri, 21 Oct 2016 11:40:47 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Viresh Kumar Date: Fri, 21 Oct 2016 21:10:45 +0530 Message-ID: Subject: Re: [PATCH V2 0/8] PM / OPP: Multiple regulator support To: "Rafael J. Wysocki" Cc: Rafael Wysocki , Nishanth Menon , Stephen Boyd , Lists linaro-kernel , Linux PM , Linux Kernel Mailing List , Vincent Guittot , Rob Herring , Dave Gerlach , Mark Brown Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21 October 2016 at 19:09, Rafael J. Wysocki wrote: > On Thu, Oct 20, 2016 at 10:44 AM, Viresh Kumar wrote: >> Hi, >> >> Some platforms (like TI) have complex DVFS configuration for CPU >> devices, where multiple regulators are required to be configured to >> change DVFS state of the device. This was explained well by Nishanth >> earlier [1]. >> >> Some thoughts went into it few months back but then it all got lost. I >> am trying to get that back on track with this thread. >> >> One of the major complaints around multiple regulators case was that the >> DT isn't responsible in any way to represent the ordering in which >> multiple supplies need to be programmed, before or after frequency >> change. It was considered in this patch and such information is left to >> the platform specific OPP driver now, which can register its own >> opp_set_rate() callback with the OPP core and the OPP core will then >> call it during DVFS. >> >> The patches are tested on Exynos5250 (Dual A15). I have hacked around DT >> and code to pass values for multiple regulators and verified that they >> are all properly read by the kernel (using debugfs interface). >> >> Though more testing on real (TI) platforms would be useful. >> >> This is rebased over: linux-next branch in the PM tree. >> >> V1->V2: >> - Ack from Rob for 1st patch >> - Moved the supplies structure to pm_opp.h (Dave) >> - Fixed an compilation warning. > > I need somebody from the OPP camp to review patches [2-8/8] for me. Sure, I have already asked Stephen yesterday to do that. -- viresh