From: Viresh Kumar <viresh.kumar@linaro.org>
To: Xiaoguang Chen <chenxg@marvell.com>
Cc: rjw@sisk.pl, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, njiang1@marvell.com,
zjwu@marvell.com, ylmao@marvell.com, chenxg.marvell@gmail.com
Subject: Re: [PATCH v9] Cpufreq: Fix governor start/stop race condition
Date: Wed, 19 Jun 2013 13:25:36 +0530 [thread overview]
Message-ID: <CAKohponDRcfHyRA-JCW01SC8R-dDiOx1dzBcOU6ag2DUa5_DyA@mail.gmail.com> (raw)
In-Reply-To: <1371625207-26702-1-git-send-email-chenxg@marvell.com>
On 19 June 2013 12:30, Xiaoguang Chen <chenxg@marvell.com> wrote:
> Cpufreq governor's stop and start operation should be kept in sequence.
> If not, there will be unexpected behavior, for example:
>
> There are 4 CPUs and policy->cpu=CPU0, CPU1/2/3 are linked to CPU0.
> The normal sequence is as below:
>
> 1) Current governor is userspace, One application tries to set
> governor to ondemand. It will call __cpufreq_set_policy in which it
> will stop userspace governor and then start ondemand governor.
>
> 2) Current governor is userspace, Now CPU0 hotplugs in CPU3 (put CPU3 online),
> It will call cpufreq_add_policy_cpu in which it first stops userspace
> governor, and then starts userspace governor.
>
> Now if the sequence of above two cases interleaves, It becomes like below:
>
> 1) Application stops userspace governor
> 2) Hotplug stops userspace governor
> 3) Application starts ondemand governor
> 4) Hotplug starts a governor
>
> In step 4, Hotplug is supposed to start userspace governor, But now
> the governor has been changed by application to ondemand, So hotplug
> starts ondemand governor again !!!!
>
> The solution is: Do not allow stop policy's governor multi-times.
> Governor should only be stopped once for one policy, After it is stopped,
> No other governor stop operation should be executed. also add one mutex to
> protect __cpufreq_governor so governor operation can be kept in sequence.
>
> Signed-off-by: Xiaoguang Chen <chenxg@marvell.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/cpufreq.c | 24 ++++++++++++++++++++++++
> include/linux/cpufreq.h | 1 +
> 2 files changed, 25 insertions(+)
All good now. Sorry for the noise :)
next prev parent reply other threads:[~2013-06-19 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 7:00 [PATCH v9] Cpufreq: Fix governor start/stop race condition Xiaoguang Chen
2013-06-19 7:00 ` Xiaoguang Chen
2013-06-19 7:55 ` Viresh Kumar [this message]
2013-06-19 8:28 ` Xiaoguang Chen
2013-06-24 6:04 ` Xiaoguang Chen
2013-06-24 9:41 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKohponDRcfHyRA-JCW01SC8R-dDiOx1dzBcOU6ag2DUa5_DyA@mail.gmail.com \
--to=viresh.kumar@linaro.org \
--cc=chenxg.marvell@gmail.com \
--cc=chenxg@marvell.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=njiang1@marvell.com \
--cc=rjw@sisk.pl \
--cc=ylmao@marvell.com \
--cc=zjwu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.