* Re: [PATCH] arch/x86: Check return value from a notify_die() call
@ 2020-06-21 14:40 ` Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2020-06-21 14:40 UTC (permalink / raw)
To: Bo YU, kernel-janitors
Cc: linux-kernel, Alexandre Chartre, Andy Lutomirski,
Borislav Petkov, Dave Hansen, H. Peter Anvin, Ingo Molnar,
Jann Horn, Kees Cook, Peter Zijlstra, Thomas Gleixner
I propose to improve the previous patch subject.
> This is detected by Coverity scan: #CID: 1464472(CHECKED_RETURN)
>
> FIXES: c94082656dac7(x86: Use enum instead of literals for trap values)
Is the following tag specification more appropriate?
Fixes: c94082656dac7 ("x86: Use enum instead of literals for trap values")
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arch/x86: Check return value from a notify_die() call
@ 2020-06-21 14:40 ` Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2020-06-21 14:40 UTC (permalink / raw)
To: Bo YU, kernel-janitors
Cc: linux-kernel, Alexandre Chartre, Andy Lutomirski,
Borislav Petkov, Dave Hansen, H. Peter Anvin, Ingo Molnar,
Jann Horn, Kees Cook, Peter Zijlstra, Thomas Gleixner
I propose to improve the previous patch subject.
> This is detected by Coverity scan: #CID: 1464472(CHECKED_RETURN)
>
> FIXES: c94082656dac7(x86: Use enum instead of literals for trap values)
Is the following tag specification more appropriate?
Fixes: c94082656dac7 ("x86: Use enum instead of literals for trap values")
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arch/x86: Check return value from a notify_die() call
2020-06-21 14:40 ` Markus Elfring
@ 2020-06-22 0:50 ` Bo YU
-1 siblings, 0 replies; 6+ messages in thread
From: Bo YU @ 2020-06-22 0:50 UTC (permalink / raw)
To: Markus Elfring
Cc: kernel-janitors, open list, Alexandre Chartre, Andy Lutomirski,
Borislav Petkov, Dave Hansen, H. Peter Anvin, Ingo Molnar,
Jann Horn, Kees Cook, Peter Zijlstra, Thomas Gleixner
On Sun, Jun 21, 2020 at 10:40 PM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> I propose to improve the previous patch subject.
>
>
> > This is detected by Coverity scan: #CID: 1464472(CHECKED_RETURN)
> >
> > FIXES: c94082656dac7(x86: Use enum instead of literals for trap values)
>
> Is the following tag specification more appropriate?
>
> Fixes: c94082656dac7 ("x86: Use enum instead of literals for trap values")
Your description looks like more appropriate, thank you.
But I want to receive suggestions from other reviewers also. So I will
send V2 patch as your point
once got confirmed. Sorry.
>
> Regards,
> Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arch/x86: Check return value from a notify_die() call
@ 2020-06-22 0:50 ` Bo YU
0 siblings, 0 replies; 6+ messages in thread
From: Bo YU @ 2020-06-22 0:50 UTC (permalink / raw)
To: Markus Elfring
Cc: kernel-janitors, open list, Alexandre Chartre, Andy Lutomirski,
Borislav Petkov, Dave Hansen, H. Peter Anvin, Ingo Molnar,
Jann Horn, Kees Cook, Peter Zijlstra, Thomas Gleixner
On Sun, Jun 21, 2020 at 10:40 PM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> I propose to improve the previous patch subject.
>
>
> > This is detected by Coverity scan: #CID: 1464472(CHECKED_RETURN)
> >
> > FIXES: c94082656dac7(x86: Use enum instead of literals for trap values)
>
> Is the following tag specification more appropriate?
>
> Fixes: c94082656dac7 ("x86: Use enum instead of literals for trap values")
Your description looks like more appropriate, thank you.
But I want to receive suggestions from other reviewers also. So I will
send V2 patch as your point
once got confirmed. Sorry.
>
> Regards,
> Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arch/x86: Check return value from a notify_die() call
2020-06-22 0:50 ` Bo YU
@ 2020-06-22 6:50 ` Markus Elfring
-1 siblings, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2020-06-22 6:50 UTC (permalink / raw)
To: Bo YU, kernel-janitors
Cc: linux-kernel, Alexandre Chartre, Andy Lutomirski,
Borislav Petkov, Dave Hansen, H. Peter Anvin, Ingo Molnar,
Jann Horn, Kees Cook, Peter Zijlstra, Thomas Gleixner
>>> This is detected by Coverity scan: #CID: 1464472(CHECKED_RETURN)
Can an additional imperative wording be helpful for the change description
(besides an adjusted patch subject)?
>>> FIXES: c94082656dac7(x86: Use enum instead of literals for trap values)
>>
>> Is the following tag specification more appropriate?
>>
>> Fixes: c94082656dac7 ("x86: Use enum instead of literals for trap values")
> Your description looks like more appropriate, thank you.
Thanks for your positive feedback.
> But I want to receive suggestions from other reviewers also. So I will
> send V2 patch as your point once got confirmed. Sorry.
Should the confirmation be sufficient from the available software documentation?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183
I am curious if this patch review will clarify more aspects.
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arch/x86: Check return value from a notify_die() call
@ 2020-06-22 6:50 ` Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2020-06-22 6:50 UTC (permalink / raw)
To: Bo YU, kernel-janitors
Cc: linux-kernel, Alexandre Chartre, Andy Lutomirski,
Borislav Petkov, Dave Hansen, H. Peter Anvin, Ingo Molnar,
Jann Horn, Kees Cook, Peter Zijlstra, Thomas Gleixner
>>> This is detected by Coverity scan: #CID: 1464472(CHECKED_RETURN)
Can an additional imperative wording be helpful for the change description
(besides an adjusted patch subject)?
>>> FIXES: c94082656dac7(x86: Use enum instead of literals for trap values)
>>
>> Is the following tag specification more appropriate?
>>
>> Fixes: c94082656dac7 ("x86: Use enum instead of literals for trap values")
> Your description looks like more appropriate, thank you.
Thanks for your positive feedback.
> But I want to receive suggestions from other reviewers also. So I will
> send V2 patch as your point once got confirmed. Sorry.
Should the confirmation be sufficient from the available software documentation?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?idb5d3449788f85569096780592549d0340e9c0c7#n183
I am curious if this patch review will clarify more aspects.
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-22 6:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-21 14:40 [PATCH] arch/x86: Check return value from a notify_die() call Markus Elfring
2020-06-21 14:40 ` Markus Elfring
2020-06-22 0:50 ` Bo YU
2020-06-22 0:50 ` Bo YU
2020-06-22 6:50 ` Markus Elfring
2020-06-22 6:50 ` Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.