From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ard Biesheuvel Subject: Re: [Linaro-acpi] [PATCH v7 04/17] ARM64 / ACPI: Introduce early_param for "acpi" and pass acpi=force to enable ACPI Date: Fri, 30 Jan 2015 15:12:14 +0000 Message-ID: References: <1421247905-3749-1-git-send-email-hanjun.guo@linaro.org> <1421247905-3749-5-git-send-email-hanjun.guo@linaro.org> <20150128181453.GG31752@e104818-lin.cambridge.arm.com> <54C92804.5090806@codeaurora.org> <20150129151956.GF8951@e104818-lin.cambridge.arm.com> <20150130111311.GA27542@e104818-lin.cambridge.arm.com> <54CB99B5.7070505@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ie0-f169.google.com ([209.85.223.169]:59430 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762547AbbA3PMP (ORCPT ); Fri, 30 Jan 2015 10:12:15 -0500 Received: by mail-ie0-f169.google.com with SMTP id rl12so4040137iec.0 for ; Fri, 30 Jan 2015 07:12:15 -0800 (PST) In-Reply-To: <54CB99B5.7070505@codeaurora.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Timur Tabi Cc: Catalin Marinas , Mark Rutland , Rob Herring , "phoenix.liyi@huawei.com" , Robert Richter , "linux-acpi@vger.kernel.org" , Arnd Bergmann , "linaro-acpi@lists.linaro.org" , Marc Zyngier , Will Deacon , Randy Dunlap , "Rafael J. Wysocki" , lkml , "grant.likely@linaro.org" , "wangyijing@huawei.com" , Mark Brown , "hanjun.guo@linaro.org" , "jcm@redhat.com" , Olof Johansson , Bjorn Helgaas "linux-arm-kernel@lists.infradead.org" On 30 January 2015 at 14:48, Timur Tabi wrote: > Catalin Marinas wrote: >> >> Anyway, rather than a "I-created-an-empty-dtb" property, I would >> actually say something like "dtb-contains-no-hardware-description". > > > Why do we need a property for this? Wouldn't the absence of a hardware > description be the best way to see if the dtb contains no hardware > description? It's like putting a sign on an empty bookshelf that says, > "there are no books here." > So what constitutes a 'hardware description'? A /cpu node? A memory node? I don't think there is a mandated minimal set of nodes, even if booting without cpu and memory nodes doesn't get you very far. So those should go hand in hand: if we are going to implement logic that decides a DTB is considered empty if it has no /cpu node, we should update the boot protocol to mandate the presence of a /cpu node for DT boot, and not change the rules every couple of months if someone's use case requires it. -- Ard. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762618AbbA3PMR (ORCPT ); Fri, 30 Jan 2015 10:12:17 -0500 Received: from mail-ie0-f174.google.com ([209.85.223.174]:43287 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758651AbbA3PMP (ORCPT ); Fri, 30 Jan 2015 10:12:15 -0500 MIME-Version: 1.0 In-Reply-To: <54CB99B5.7070505@codeaurora.org> References: <1421247905-3749-1-git-send-email-hanjun.guo@linaro.org> <1421247905-3749-5-git-send-email-hanjun.guo@linaro.org> <20150128181453.GG31752@e104818-lin.cambridge.arm.com> <54C92804.5090806@codeaurora.org> <20150129151956.GF8951@e104818-lin.cambridge.arm.com> <20150130111311.GA27542@e104818-lin.cambridge.arm.com> <54CB99B5.7070505@codeaurora.org> Date: Fri, 30 Jan 2015 15:12:14 +0000 Message-ID: Subject: Re: [Linaro-acpi] [PATCH v7 04/17] ARM64 / ACPI: Introduce early_param for "acpi" and pass acpi=force to enable ACPI From: Ard Biesheuvel To: Timur Tabi Cc: Catalin Marinas , Mark Rutland , Rob Herring , "phoenix.liyi@huawei.com" , Robert Richter , "linux-acpi@vger.kernel.org" , Arnd Bergmann , "linaro-acpi@lists.linaro.org" , Marc Zyngier , Will Deacon , Randy Dunlap , "Rafael J. Wysocki" , lkml , "grant.likely@linaro.org" , "wangyijing@huawei.com" , Mark Brown , "hanjun.guo@linaro.org" , "jcm@redhat.com" , Olof Johansson , Bjorn Helgaas , "linux-arm-kernel@lists.infradead.org" , Jason Cooper Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30 January 2015 at 14:48, Timur Tabi wrote: > Catalin Marinas wrote: >> >> Anyway, rather than a "I-created-an-empty-dtb" property, I would >> actually say something like "dtb-contains-no-hardware-description". > > > Why do we need a property for this? Wouldn't the absence of a hardware > description be the best way to see if the dtb contains no hardware > description? It's like putting a sign on an empty bookshelf that says, > "there are no books here." > So what constitutes a 'hardware description'? A /cpu node? A memory node? I don't think there is a mandated minimal set of nodes, even if booting without cpu and memory nodes doesn't get you very far. So those should go hand in hand: if we are going to implement logic that decides a DTB is considered empty if it has no /cpu node, we should update the boot protocol to mandate the presence of a /cpu node for DT boot, and not change the rules every couple of months if someone's use case requires it. -- Ard. From mboxrd@z Thu Jan 1 00:00:00 1970 From: ard.biesheuvel@linaro.org (Ard Biesheuvel) Date: Fri, 30 Jan 2015 15:12:14 +0000 Subject: [Linaro-acpi] [PATCH v7 04/17] ARM64 / ACPI: Introduce early_param for "acpi" and pass acpi=force to enable ACPI In-Reply-To: <54CB99B5.7070505@codeaurora.org> References: <1421247905-3749-1-git-send-email-hanjun.guo@linaro.org> <1421247905-3749-5-git-send-email-hanjun.guo@linaro.org> <20150128181453.GG31752@e104818-lin.cambridge.arm.com> <54C92804.5090806@codeaurora.org> <20150129151956.GF8951@e104818-lin.cambridge.arm.com> <20150130111311.GA27542@e104818-lin.cambridge.arm.com> <54CB99B5.7070505@codeaurora.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 30 January 2015 at 14:48, Timur Tabi wrote: > Catalin Marinas wrote: >> >> Anyway, rather than a "I-created-an-empty-dtb" property, I would >> actually say something like "dtb-contains-no-hardware-description". > > > Why do we need a property for this? Wouldn't the absence of a hardware > description be the best way to see if the dtb contains no hardware > description? It's like putting a sign on an empty bookshelf that says, > "there are no books here." > So what constitutes a 'hardware description'? A /cpu node? A memory node? I don't think there is a mandated minimal set of nodes, even if booting without cpu and memory nodes doesn't get you very far. So those should go hand in hand: if we are going to implement logic that decides a DTB is considered empty if it has no /cpu node, we should update the boot protocol to mandate the presence of a /cpu node for DT boot, and not change the rules every couple of months if someone's use case requires it. -- Ard.