From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRdtv-0006cZ-Nd for qemu-devel@nongnu.org; Wed, 10 Sep 2014 05:09:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRdtq-0006bo-Oc for qemu-devel@nongnu.org; Wed, 10 Sep 2014 05:09:19 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:42872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRdtq-0006bd-HS for qemu-devel@nongnu.org; Wed, 10 Sep 2014 05:09:14 -0400 Received: by mail-lb0-f182.google.com with SMTP id v6so4409639lbi.13 for ; Wed, 10 Sep 2014 02:09:13 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1409930126-28449-1-git-send-email-ard.biesheuvel@linaro.org> <1409930126-28449-2-git-send-email-ard.biesheuvel@linaro.org> Date: Wed, 10 Sep 2014 11:09:13 +0200 Message-ID: From: Ard Biesheuvel Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 1/6] hw/arm/virt: Provide flash devices for boot ROMs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Fu Wei , Peter Crosthwaite , QEMU Developers , Christoffer Dall On 9 September 2014 20:20, Peter Maydell wrote: > On 5 September 2014 16:15, Ard Biesheuvel wrote: >> From: Peter Maydell >> >> Add two flash devices to the virt board, so that it can be used for >> running guests which want a bootrom image such as UEFI. We provide >> two flash devices to make it more convenient to provide both a >> read-only UEFI image and a read-write place to store guest-set >> UEFI config variables. The '-bios' command line option is set up >> to provide an image for the first of the two flash devices. >> >> Signed-off-by: Peter Maydell >> Reviewed-by: Paolo Bonzini >> --- >> hw/arm/virt.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 70 insertions(+) > > This one's been around long enough that I'm going to add > it to target-arm.next now. > > There were previously questions about whether we should > have flash or RAM at the bottom, but I think it makes > sense just to have a "like vexpress" config with two > flash devices. This does make telling QEMU about backing > storage for the 2nd flash a little complicated, but I > think anybody seriously running a config like that will > be using the management tools layer anyhow. > You mean having to use -pflash and pad the images out to 64 MB? I wouldn't worry about that.