From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60032)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ard.biesheuvel@linaro.org>) id 1XRQ2E-0002nz-TT
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 14:21:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ard.biesheuvel@linaro.org>) id 1XRQ2A-0000YM-3u
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 14:20:58 -0400
Received: from mail-lb0-f178.google.com ([209.85.217.178]:55647)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ard.biesheuvel@linaro.org>) id 1XRQ29-0000YH-Sr
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 14:20:54 -0400
Received: by mail-lb0-f178.google.com with SMTP id c11so3686792lbj.23
	for <qemu-devel@nongnu.org>; Tue, 09 Sep 2014 11:20:52 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAFEAcA9kSzDnkzx5u=g28=_3K2W2Eae299pEEfzCcp3kSSdf5w@mail.gmail.com>
References: <1409930126-28449-1-git-send-email-ard.biesheuvel@linaro.org>
	<1409930126-28449-7-git-send-email-ard.biesheuvel@linaro.org>
	<CAFEAcA-kQ4jdgT_XYfynEiUVH1qB1Rz1qaX-sSVm3PGqpScepw@mail.gmail.com>
	<CAKv+Gu9s7x1-zf+AZOvEDe+acOdMiKt6yBsr8=UQO8ebL9UtNQ@mail.gmail.com>
	<CAFEAcA9kSzDnkzx5u=g28=_3K2W2Eae299pEEfzCcp3kSSdf5w@mail.gmail.com>
Date: Tue, 9 Sep 2014 20:20:52 +0200
Message-ID: <CAKv+Gu-DgTVozVQEt84KBWSw2rbhWgRNZo4km8wsZGFYW1Y43w@mail.gmail.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 6/6] hw/arm/boot: enable DTB support when
	booting ELF images
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Fu Wei <fu.wei@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Christoffer Dall <christoffer.dall@linaro.org>

On 9 September 2014 20:17, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 9 September 2014 19:15, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>> On 9 September 2014 20:08, Peter Maydell <peter.maydell@linaro.org> wrote:
>>> (Thinking about it, that implies we either need a
>>> rom_del_blob() or we need to tell load_dtb() about
>>> areas of address space it needs to check for overlap
>>> with before it registers the rom blob for the dtb.)
>>>
>>
>> ... or we just call load_elf() again
>
> That won't work, because we'll still trip the overlap
> check in rom_load_all(), won't we?
>

Yeah, you're right. My fingers are moving faster than my brain again

I will go ahead and rework load_dtb() to take a max_size parameter,
and load the dtb only if its size doesn't exceed max_size.

This should be sufficient to (a) implement the ELF case, and (b) not
complicate the other call sites too much