From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995BFC33C8C for ; Tue, 7 Jan 2020 18:00:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 674792187F for ; Tue, 7 Jan 2020 18:00:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GVQwCtK1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728366AbgAGSAL (ORCPT ); Tue, 7 Jan 2020 13:00:11 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:46841 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728292AbgAGSAK (ORCPT ); Tue, 7 Jan 2020 13:00:10 -0500 Received: by mail-wr1-f65.google.com with SMTP id z7so375897wrl.13 for ; Tue, 07 Jan 2020 10:00:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4avhs8wOdmaxMNZFNNhuy5O1rkBv12FPijImt/ejG/k=; b=GVQwCtK1bktHHhkrsp00ucUZWmpd++nsBEXMdIbp323RFHf9VLo2GWVuIGGQxDrn72 03evoRsVpCvCioZn60tKjVS7ukdm0g8fgh+bJw6rb5t6QjEBu8KHJwOo+CBttbaVM1oj OARrMjN/D05/tcKojlbOps/ZSdwKyI0ErZi5r0hxZxztDqobGFxbeEOx72KIkHa7ye7x cRU7s8P6gms6LPnlpGn1+PcA5IrbAX9PIaoyVfH1g7cKk5SShnOtKL/9735Uu8Wqh/NL 72wQ/YlbsUUjO6nPv+tGgrPKpWECzCmaG7ktImsFjbllapEva0lpdJY1ce5Wynawzq0y cLHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4avhs8wOdmaxMNZFNNhuy5O1rkBv12FPijImt/ejG/k=; b=Kq+nL0q1Oyjpu7Lch1C/N8vo/gle3cjJjPzAElTwOL+fz0FyxDPaTTcpwkBFDEsKcd wEycChlu/wAyIgZXDzbw/INfMNU0lj18NXKOGo2vs73kVUvzD0SuZozG4P6qGuT48q26 oZZLB4prPfqYcQYg+JgbPVX5EUwEdbqay+Ytg4y0ciud+x7PBoFSnoPN03mPu6yikRMW /CpCJ75bsMmhQ5du7jLwgv6LkMCWQcEG2SpJ8QAJIk347Mb+eHblWsKjkR1Wki2Invjr U4A3BrZ6gHCojcI5Z6HBwQthj3HYUB+PiX+vFhstYIjqyxFDbHxeJj5gdBR77J1N6zZ6 zXXw== X-Gm-Message-State: APjAAAXiYxIj5ysfr9ojn096FY3nFsWhxdYoc7Sr6IrUmgxhNHwSMzVa 8hUFdN7siQ3RBjT12u6akeTgaQa1SnUMoiG3rqfliA== X-Google-Smtp-Source: APXvYqxHa2a6+kWr8aYxZpPmuWy5I//CVHTMDUE2HGsmk6F+d8ehPOgckaiwtakJNldtm2MHlQSnLYy98xFnjXAFRCU= X-Received: by 2002:a5d:46c1:: with SMTP id g1mr309796wrs.200.1578420008822; Tue, 07 Jan 2020 10:00:08 -0800 (PST) MIME-Version: 1.0 References: <20200107135500.644618-1-nivedita@alum.mit.edu> <20200107142125.GA652888@rani.riverdale.lan> <20200107142732.GB652888@rani.riverdale.lan> <20200107175829.GA1599060@rani.riverdale.lan> In-Reply-To: <20200107175829.GA1599060@rani.riverdale.lan> From: Ard Biesheuvel Date: Tue, 7 Jan 2020 18:59:57 +0100 Message-ID: Subject: Re: [PATCH 0/3] Relocate GOT before calling EFI stub To: Arvind Sankar Cc: Ard Biesheuvel , linux-efi Content-Type: text/plain; charset="UTF-8" Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Tue, 7 Jan 2020 at 18:58, Arvind Sankar wrote: > > On Tue, Jan 07, 2020 at 03:28:31PM +0100, Ard Biesheuvel wrote: > > > > Unfortunately, the command line option implements a weaker form of > > visibility than the pragma, so it probably comes down to setting the > > pragma in a .h file that gets -include'd via the command line so it is > > guaranteed to be seen first. > > Tried hacking that in and it works, tested with gcc 4.6.4. Excellent. But in my testing locally, I don't get any GOT entries in the first place, strangely enough. So what changes in the output for you with visibility hidden compared to before?